From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Jimmy Su <jimmy.su@intel.com>
Cc: linux-media@vger.kernel.org, andy.yeh@intel.com, yhuang@ovt.com,
akeem.chen@ovt.com
Subject: Re: [PATCH v2] UPSTREAM: media: ov8856: skip OTP read in non-zero ACPI D state
Date: Wed, 18 May 2022 20:15:29 +0300 [thread overview]
Message-ID: <YoUpsdTwtBre3Cyf@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20220510151241.12435-1-jimmy.su@intel.com>
Hi Jimmy,
On Tue, May 10, 2022 at 11:12:41PM +0800, Jimmy Su wrote:
> To skip OTP read function while enable non-zero ACPI D state.
> This OTP read only influences streaming output with 3280x2464 &
> 1640x1232 resolution.
This isn't the right way to fix the problem.
Reading the EEPROM (and thus starting streaming) is a problem since the
receiver has been already set up to receive a proper frame. EEPROM reading
should be instead moved to pre_streamon callback.
I suppose this way the sensor's CSI-2 TX is also set in LP-11 mode, as many
CSI-2 receivers expect.
--
Kind regards,
Sakari Ailus
prev parent reply other threads:[~2022-05-18 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 15:12 [PATCH v2] UPSTREAM: media: ov8856: skip OTP read in non-zero ACPI D state Jimmy Su
2022-05-16 11:30 ` Dan Carpenter
2022-05-18 17:15 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoUpsdTwtBre3Cyf@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=akeem.chen@ovt.com \
--cc=andy.yeh@intel.com \
--cc=jimmy.su@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=yhuang@ovt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox