From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 208B9C433EF for ; Fri, 17 Jun 2022 11:48:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236384AbiFQLsf (ORCPT ); Fri, 17 Jun 2022 07:48:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381990AbiFQLse (ORCPT ); Fri, 17 Jun 2022 07:48:34 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 420EE6B0B5 for ; Fri, 17 Jun 2022 04:48:27 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2BC972A5; Fri, 17 Jun 2022 13:48:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1655466504; bh=wJPdAXNzdiHhuvY+RODcmx+zUnAeP2MqAsng5CtuEPM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wKYGJco06mx5e5sKJesv6LYIOVGyIPCt22H4n8cO4EPAGNZtHb0j7XlvjEZGn4rCd YenGGEji/lGxlYglFGWE+Or1gxENZEqyc5NZu2leYWLkbqdw5ytZGMZoX/yxnUZFbk YMjVDT/N7nZW7tXQ766MDXqoYa6PnQowZnca+oTA= Date: Fri, 17 Jun 2022 14:48:12 +0300 From: Laurent Pinchart To: Hans Verkuil Cc: Paul Elder , linux-media@vger.kernel.org, dafna@fastmail.com, heiko@sntech.de, jeanmichel.hautbois@ideasonboard.com, jacopo@jmondi.org, djrscally@gmail.com, helen.koike@collabora.com, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 38/55] media: mc-entity: Add a new helper function to get a remote pad for a pad Message-ID: References: <20220614191127.3420492-1-paul.elder@ideasonboard.com> <20220614191127.3420492-39-paul.elder@ideasonboard.com> <0bc99232-658b-5308-8004-7ae14e979370@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0bc99232-658b-5308-8004-7ae14e979370@xs4all.nl> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Hans, On Fri, Jun 17, 2022 at 01:41:59PM +0200, Hans Verkuil wrote: > On 6/14/22 21:11, Paul Elder wrote: > > From: Laurent Pinchart > > > > The newly added media_entity_remote_source_pad() helper function handles > > use cases where the entity has a link enabled uniqueness constraint > > covering all pads. There are use cases where the constraint covers a > > specific pad only. Add a new media_pad_remote_pad() function to handle > > this. It operates as media_entity_remote_source_pad(), but on a given > > pad instead of on the entity. > > > > Signed-off-by: Laurent Pinchart > > --- > > Documentation/driver-api/media/mc-core.rst | 4 +-- > > drivers/media/mc/mc-entity.c | 31 ++++++++++++++++++++++ > > include/media/media-entity.h | 18 +++++++++++++ > > 3 files changed, 51 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/driver-api/media/mc-core.rst b/Documentation/driver-api/media/mc-core.rst > > index a2d1e32e3abb..83c3bdbf67be 100644 > > --- a/Documentation/driver-api/media/mc-core.rst > > +++ b/Documentation/driver-api/media/mc-core.rst > > @@ -186,8 +186,8 @@ is required and the graph structure can be freed normally. > > > > Helper functions can be used to find a link between two given pads, or a pad > > connected to another pad through an enabled link > > -(:c:func:`media_entity_find_link()`, :c:func:`media_entity_remote_pad()` and > > -:c:func:`media_entity_remote_source_pad()`). > > +(:c:func:`media_entity_find_link()`, :c:func:`media_entity_remote_pad()`, > > +:c:func:`media_entity_remote_source_pad()` and :c:func:`media_pad_remote_pad()`). > > > > Use count and power handling > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c > > index 1febf5a86be6..6429b0510bfb 100644 > > --- a/drivers/media/mc/mc-entity.c > > +++ b/drivers/media/mc/mc-entity.c > > @@ -958,6 +958,37 @@ media_entity_remote_pad_unique(const struct media_entity *entity, > > } > > EXPORT_SYMBOL_GPL(media_entity_remote_pad_unique); > > > > +struct media_pad *media_pad_remote_pad(const struct media_pad *pad) > > +{ > > + struct media_pad *found_pad = NULL; > > + struct media_link *link; > > + > > + list_for_each_entry(link, &pad->entity->links, list) { > > + struct media_pad *remote_pad; > > + > > + if (!(link->flags & MEDIA_LNK_FL_ENABLED)) > > + continue; > > + > > + if (link->sink == pad) > > + remote_pad = link->source; > > + else if (link->source == pad) > > + remote_pad = link->sink; > > + else > > + continue; > > + > > + if (found_pad) > > + return ERR_PTR(-ENOTUNIQ); > > + > > + found_pad = remote_pad; > > + } > > + > > + if (!found_pad) > > + return ERR_PTR(-ENOLINK); > > + > > + return found_pad; > > +} > > +EXPORT_SYMBOL_GPL(media_pad_remote_pad); > > + > > static void media_interface_init(struct media_device *mdev, > > struct media_interface *intf, > > u32 gobj_type, > > diff --git a/include/media/media-entity.h b/include/media/media-entity.h > > index 33d5f52719a0..bfe6a7b10a68 100644 > > --- a/include/media/media-entity.h > > +++ b/include/media/media-entity.h > > @@ -904,6 +904,24 @@ media_entity_remote_source_pad(const struct media_entity *entity) > > return media_entity_remote_pad_unique(entity, MEDIA_PAD_FL_SOURCE); > > } > > > > +/** > > + * media_pad_remote_pad - Find a remote pad connected to a pad > > Same question here: shouldn't this be called media_pad_remote_pad_unique? I'm fine with that (and for the previous patch too). I'll wait for Sakari's opinion and will then make the change. > > + * @pad: The pad > > + * > > + * Search for and return a remote pad connected to @pad through an enabled > > + * link. If multiple (or no) remote pads are found, an error is returned. > > + * > > + * The uniqueness constraint makes this helper function suitable for entities > > + * that support a single active source at a time on a given pad. > > + * > > + * Return: A pointer to the remote pad, or one of the following error pointers > > + * if an error occurs: > > + * > > + * * -ENOTUNIQ - Multiple links are enabled > > + * * -ENOLINK - No connected pad found > > + */ > > +struct media_pad *media_pad_remote_pad(const struct media_pad *pad); > > + > > /** > > * media_entity_is_streaming - Test if an entity is part of a streaming pipeline > > * @entity: The entity > > With that change: > > Acked-by: Hans Verkuil -- Regards, Laurent Pinchart