* [PATCH 1/1] v4l: Kconfig: Drop subdev API option help text @ 2022-07-13 17:39 Sakari Ailus 2022-07-13 17:54 ` Laurent Pinchart 0 siblings, 1 reply; 6+ messages in thread From: Sakari Ailus @ 2022-07-13 17:39 UTC (permalink / raw) To: linux-media; +Cc: laurent.pinchart The config option text was recently removed, also remove the help text. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/v4l2-core/Kconfig | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig index 348559bc24689..60b0c6ee7343a 100644 --- a/drivers/media/v4l2-core/Kconfig +++ b/drivers/media/v4l2-core/Kconfig @@ -11,11 +11,6 @@ config VIDEO_V4L2_I2C config VIDEO_V4L2_SUBDEV_API bool depends on VIDEO_DEV && MEDIA_CONTROLLER - help - Enables the V4L2 sub-device pad-level userspace API used to configure - video format, size and frame rate between hardware blocks. - - This API is mostly used by camera interfaces in embedded platforms. config VIDEO_ADV_DEBUG bool "Enable advanced debug functionality on V4L2 drivers" -- 2.30.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] v4l: Kconfig: Drop subdev API option help text 2022-07-13 17:39 [PATCH 1/1] v4l: Kconfig: Drop subdev API option help text Sakari Ailus @ 2022-07-13 17:54 ` Laurent Pinchart 2022-07-13 19:32 ` Laurent Pinchart 0 siblings, 1 reply; 6+ messages in thread From: Laurent Pinchart @ 2022-07-13 17:54 UTC (permalink / raw) To: Sakari Ailus; +Cc: linux-media Hi Sakari, Thank you for the patch. On Wed, Jul 13, 2022 at 08:39:20PM +0300, Sakari Ailus wrote: > The config option text was recently removed, also remove the help text. > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/media/v4l2-core/Kconfig | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig > index 348559bc24689..60b0c6ee7343a 100644 > --- a/drivers/media/v4l2-core/Kconfig > +++ b/drivers/media/v4l2-core/Kconfig > @@ -11,11 +11,6 @@ config VIDEO_V4L2_I2C > config VIDEO_V4L2_SUBDEV_API > bool > depends on VIDEO_DEV && MEDIA_CONTROLLER > - help > - Enables the V4L2 sub-device pad-level userspace API used to configure > - video format, size and frame rate between hardware blocks. > - > - This API is mostly used by camera interfaces in embedded platforms. > > config VIDEO_ADV_DEBUG > bool "Enable advanced debug functionality on V4L2 drivers" -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] v4l: Kconfig: Drop subdev API option help text 2022-07-13 17:54 ` Laurent Pinchart @ 2022-07-13 19:32 ` Laurent Pinchart 2022-07-13 19:41 ` Sakari Ailus 0 siblings, 1 reply; 6+ messages in thread From: Laurent Pinchart @ 2022-07-13 19:32 UTC (permalink / raw) To: Sakari Ailus; +Cc: linux-media On Wed, Jul 13, 2022 at 08:54:12PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Wed, Jul 13, 2022 at 08:39:20PM +0300, Sakari Ailus wrote: > > The config option text was recently removed, also remove the help text. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Actually, on second thought, isn't it useful to keep the help text as documentation ? > > --- > > drivers/media/v4l2-core/Kconfig | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig > > index 348559bc24689..60b0c6ee7343a 100644 > > --- a/drivers/media/v4l2-core/Kconfig > > +++ b/drivers/media/v4l2-core/Kconfig > > @@ -11,11 +11,6 @@ config VIDEO_V4L2_I2C > > config VIDEO_V4L2_SUBDEV_API > > bool > > depends on VIDEO_DEV && MEDIA_CONTROLLER > > - help > > - Enables the V4L2 sub-device pad-level userspace API used to configure > > - video format, size and frame rate between hardware blocks. > > - > > - This API is mostly used by camera interfaces in embedded platforms. > > > > config VIDEO_ADV_DEBUG > > bool "Enable advanced debug functionality on V4L2 drivers" -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] v4l: Kconfig: Drop subdev API option help text 2022-07-13 19:32 ` Laurent Pinchart @ 2022-07-13 19:41 ` Sakari Ailus 2022-07-13 19:47 ` Laurent Pinchart 0 siblings, 1 reply; 6+ messages in thread From: Sakari Ailus @ 2022-07-13 19:41 UTC (permalink / raw) To: Laurent Pinchart; +Cc: Sakari Ailus, linux-media On Wed, Jul 13, 2022 at 10:32:55PM +0300, Laurent Pinchart wrote: > On Wed, Jul 13, 2022 at 08:54:12PM +0300, Laurent Pinchart wrote: > > Hi Sakari, > > > > Thank you for the patch. > > > > On Wed, Jul 13, 2022 at 08:39:20PM +0300, Sakari Ailus wrote: > > > The config option text was recently removed, also remove the help text. > > > > > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Actually, on second thought, isn't it useful to keep the help text as > documentation ? We haven't generally done that for other such options either. This was intended for end users IMO. -- Sakari Ailus ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] v4l: Kconfig: Drop subdev API option help text 2022-07-13 19:41 ` Sakari Ailus @ 2022-07-13 19:47 ` Laurent Pinchart 2022-07-13 19:55 ` Sakari Ailus 0 siblings, 1 reply; 6+ messages in thread From: Laurent Pinchart @ 2022-07-13 19:47 UTC (permalink / raw) To: Sakari Ailus; +Cc: Sakari Ailus, linux-media On Wed, Jul 13, 2022 at 10:41:01PM +0300, Sakari Ailus wrote: > On Wed, Jul 13, 2022 at 10:32:55PM +0300, Laurent Pinchart wrote: > > On Wed, Jul 13, 2022 at 08:54:12PM +0300, Laurent Pinchart wrote: > > > Hi Sakari, > > > > > > Thank you for the patch. > > > > > > On Wed, Jul 13, 2022 at 08:39:20PM +0300, Sakari Ailus wrote: > > > > The config option text was recently removed, also remove the help text. > > > > > > > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > > > Actually, on second thought, isn't it useful to keep the help text as > > documentation ? > > We haven't generally done that for other such options either. This was > intended for end users IMO. I don't have a strong opinion, but this came to my attention when reviewing your patch that adds selection of GENERIC_PHY_MIPI_DPHY for sun6i. The GENERIC_PHY_MIPI_DPHY symbol isn't user-selectable but has a help text. A short documentation is useful in my opinion. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] v4l: Kconfig: Drop subdev API option help text 2022-07-13 19:47 ` Laurent Pinchart @ 2022-07-13 19:55 ` Sakari Ailus 0 siblings, 0 replies; 6+ messages in thread From: Sakari Ailus @ 2022-07-13 19:55 UTC (permalink / raw) To: Laurent Pinchart; +Cc: Sakari Ailus, linux-media On Wed, Jul 13, 2022 at 10:47:02PM +0300, Laurent Pinchart wrote: > On Wed, Jul 13, 2022 at 10:41:01PM +0300, Sakari Ailus wrote: > > On Wed, Jul 13, 2022 at 10:32:55PM +0300, Laurent Pinchart wrote: > > > On Wed, Jul 13, 2022 at 08:54:12PM +0300, Laurent Pinchart wrote: > > > > Hi Sakari, > > > > > > > > Thank you for the patch. > > > > > > > > On Wed, Jul 13, 2022 at 08:39:20PM +0300, Sakari Ailus wrote: > > > > > The config option text was recently removed, also remove the help text. > > > > > > > > > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > > > > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > > > > > Actually, on second thought, isn't it useful to keep the help text as > > > documentation ? > > > > We haven't generally done that for other such options either. This was > > intended for end users IMO. > > I don't have a strong opinion, but this came to my attention when > reviewing your patch that adds selection of GENERIC_PHY_MIPI_DPHY for > sun6i. The GENERIC_PHY_MIPI_DPHY symbol isn't user-selectable but has a > help text. A short documentation is useful in my opinion. I'll leave it ouf of the next pull request then. We can later on decide to merge it if we like. -- Sakari Ailus ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-13 19:55 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-07-13 17:39 [PATCH 1/1] v4l: Kconfig: Drop subdev API option help text Sakari Ailus 2022-07-13 17:54 ` Laurent Pinchart 2022-07-13 19:32 ` Laurent Pinchart 2022-07-13 19:41 ` Sakari Ailus 2022-07-13 19:47 ` Laurent Pinchart 2022-07-13 19:55 ` Sakari Ailus
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox