public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] v4l: Kconfig: Drop subdev API option help text
Date: Wed, 13 Jul 2022 22:32:55 +0300	[thread overview]
Message-ID: <Ys8d54l85k8Cwxne@pendragon.ideasonboard.com> (raw)
In-Reply-To: <Ys8GxF91rx32ZRAX@pendragon.ideasonboard.com>

On Wed, Jul 13, 2022 at 08:54:12PM +0300, Laurent Pinchart wrote:
> Hi Sakari,
> 
> Thank you for the patch.
> 
> On Wed, Jul 13, 2022 at 08:39:20PM +0300, Sakari Ailus wrote:
> > The config option text was recently removed, also remove the help text.
> > 
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Actually, on second thought, isn't it useful to keep the help text as
documentation ?

> > ---
> >  drivers/media/v4l2-core/Kconfig | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig
> > index 348559bc24689..60b0c6ee7343a 100644
> > --- a/drivers/media/v4l2-core/Kconfig
> > +++ b/drivers/media/v4l2-core/Kconfig
> > @@ -11,11 +11,6 @@ config VIDEO_V4L2_I2C
> >  config VIDEO_V4L2_SUBDEV_API
> >  	bool
> >  	depends on VIDEO_DEV && MEDIA_CONTROLLER
> > -	help
> > -	  Enables the V4L2 sub-device pad-level userspace API used to configure
> > -	  video format, size and frame rate between hardware blocks.
> > -
> > -	  This API is mostly used by camera interfaces in embedded platforms.
> >  
> >  config VIDEO_ADV_DEBUG
> >  	bool "Enable advanced debug functionality on V4L2 drivers"

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2022-07-13 19:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13 17:39 [PATCH 1/1] v4l: Kconfig: Drop subdev API option help text Sakari Ailus
2022-07-13 17:54 ` Laurent Pinchart
2022-07-13 19:32   ` Laurent Pinchart [this message]
2022-07-13 19:41     ` Sakari Ailus
2022-07-13 19:47       ` Laurent Pinchart
2022-07-13 19:55         ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ys8d54l85k8Cwxne@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox