From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Samuel Holland <samuel@sholland.org>
Subject: Re: [PATCH 1/1] media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY
Date: Wed, 13 Jul 2022 22:32:18 +0300 [thread overview]
Message-ID: <Ys8dwhnoH3EjArwM@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220713192540.222794-1-sakari.ailus@linux.intel.com>
Hi Sakari,
Thank you for the patch.
On Wed, Jul 13, 2022 at 10:25:40PM +0300, Sakari Ailus wrote:
> The sun6i-mipi-csi2 and sun6i-a83t-mipi-csi2 drivers depend on the generic
> MIPI D-PHY support. Select it. This fixes a linking problem when either of
> these drivers is enabled and GENERIC_PHY_MIPI_DPHY is disabled.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig | 1 +
> drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> index b1712f5873fd9..eb982466abd30 100644
> --- a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> +++ b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig
> @@ -8,6 +8,7 @@ config VIDEO_SUN6I_MIPI_CSI2
> select VIDEO_V4L2_SUBDEV_API
> select V4L2_FWNODE
> select PHY_SUN6I_MIPI_DPHY
> + select GENERIC_PHY_MIPI_DPHY
> select REGMAP_MMIO
> help
> Support for the Allwinner A31 MIPI CSI-2 controller, also found on
> diff --git a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
> index 5854f8388c92a..789d58ee12ea9 100644
> --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
> +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
> @@ -8,5 +8,6 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2
> select VIDEO_V4L2_SUBDEV_API
> select V4L2_FWNODE
> select REGMAP_MMIO
> + select GENERIC_PHY_MIPI_DPHY
> help
> Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-07-13 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 19:25 [PATCH 1/1] media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY Sakari Ailus
2022-07-13 19:32 ` Laurent Pinchart [this message]
2022-07-19 8:55 ` Paul Kocialkowski
2022-07-19 11:27 ` Sakari Ailus
2022-07-19 12:08 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys8dwhnoH3EjArwM@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=sakari.ailus@linux.intel.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox