public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] v4l: Kconfig: Drop subdev API option help text
Date: Wed, 13 Jul 2022 22:55:37 +0300	[thread overview]
Message-ID: <Ys8jOdPmRPCUP7u8@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <Ys8hNg87Ar9MTryZ@pendragon.ideasonboard.com>

On Wed, Jul 13, 2022 at 10:47:02PM +0300, Laurent Pinchart wrote:
> On Wed, Jul 13, 2022 at 10:41:01PM +0300, Sakari Ailus wrote:
> > On Wed, Jul 13, 2022 at 10:32:55PM +0300, Laurent Pinchart wrote:
> > > On Wed, Jul 13, 2022 at 08:54:12PM +0300, Laurent Pinchart wrote:
> > > > Hi Sakari,
> > > > 
> > > > Thank you for the patch.
> > > > 
> > > > On Wed, Jul 13, 2022 at 08:39:20PM +0300, Sakari Ailus wrote:
> > > > > The config option text was recently removed, also remove the help text.
> > > > > 
> > > > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > > > 
> > > > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > 
> > > Actually, on second thought, isn't it useful to keep the help text as
> > > documentation ?
> > 
> > We haven't generally done that for other such options either. This was
> > intended for end users IMO.
> 
> I don't have a strong opinion, but this came to my attention when
> reviewing your patch that adds selection of GENERIC_PHY_MIPI_DPHY for
> sun6i. The GENERIC_PHY_MIPI_DPHY symbol isn't user-selectable but has a
> help text. A short documentation is useful in my opinion.

I'll leave it ouf of the next pull request then. We can later on decide to
merge it if we like.

-- 
Sakari Ailus

      reply	other threads:[~2022-07-13 19:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13 17:39 [PATCH 1/1] v4l: Kconfig: Drop subdev API option help text Sakari Ailus
2022-07-13 17:54 ` Laurent Pinchart
2022-07-13 19:32   ` Laurent Pinchart
2022-07-13 19:41     ` Sakari Ailus
2022-07-13 19:47       ` Laurent Pinchart
2022-07-13 19:55         ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ys8jOdPmRPCUP7u8@valkosipuli.retiisi.eu \
    --to=sakari.ailus@iki.fi \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox