From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F063AC43334 for ; Fri, 8 Jul 2022 07:42:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237453AbiGHHmc (ORCPT ); Fri, 8 Jul 2022 03:42:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237436AbiGHHmb (ORCPT ); Fri, 8 Jul 2022 03:42:31 -0400 Received: from gofer.mess.org (gofer.mess.org [88.97.38.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA7457D1CE for ; Fri, 8 Jul 2022 00:42:30 -0700 (PDT) Received: by gofer.mess.org (Postfix, from userid 1000) id E83EB10008B; Fri, 8 Jul 2022 08:42:28 +0100 (BST) Date: Fri, 8 Jul 2022 08:42:28 +0100 From: Sean Young To: Marko =?iso-8859-1?B?TeRrZWzk?= Cc: linux-media@vger.kernel.org Subject: Re: [PATCH] media: rc: Always report LIRC repeat flag Message-ID: References: <20220705085358.44418-1-marko.makela@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Marko, On Thu, Jul 07, 2022 at 02:09:49PM +0300, Marko Mäkelä wrote: > Thu, Jul 07, 2022 at 09:57:10AM +0100, Sean Young wrote: > > On Wed, Jul 06, 2022 at 07:39:17PM +0300, Marko Mäkelä wrote: > > > Tue, Jul 05, 2022 at 06:43:55PM +0100, Sean Young wrote: > > > > On Tue, Jul 05, 2022 at 11:53:58AM +0300, Marko Mäkelä wrote: > > > > > The flag LIRC_SCANCODE_FLAG_REPEAT was never set by rc_keydown(). > > > > > Previously it was only set by rc_repeat(), but not all protocol > > > > > decoders invoke that function. > > > > > > > > This should say _why_ you are making this change, not _what_ the change > > > > is. > > > > > > How would you find the following? > > > > > > --- > > > media: lirc: ensure lirc device receives repeats > > > > > > Commit de142c32410649e64d44928505ffad2176a96a9e ("media: lirc: implement > > > reading scancode") would never set the LIRC_SCANCODE_FLAG_REPEAT flag in the > > > LIRC messages. > > > > > > Commit b66218fddfd29f315a103db811152ab0c95fb054 > > > ("media: lirc: ensure lirc device receives nec repeats") fixed it up for > > > those protocol drivers that may call rc_repeat(). > > > --- > > > > That's no good. See: > > > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes > > > > The heading is called "Describe your changes". > > I see. A quick read of "git log --oneline drivers/media/rc" suggests that > the first line of the commit message is expected to be a summary _what_ the > change is, not _why_ it was made. Would the commit message be acceptable > after adding a "why" part right after the heading line, like this? If not, I > would appreciate specific suggestions. This is much better, thank you. > --- > media: lirc: ensure lirc device receives repeats > > For remote controls using RC5 and similar protocols that include a > "toggle" flag, the LIRC device never set the "repeat" flag to distinguish > repeated messages that were sent several times per second due to a > long keypress, and messages sent due to repeated short keypresses. > > While a user-space program may implement logic around the "toggle" flag > to distinguish long keypresses, it would be simpler to be able to rely on > the "repeat" flag for any type of protocol. I'm not sure how relevant the toggle is. This change is relevant for all protocols that do not use rc_repeat() and simply repeat the original message when a key is being held down. This includes the sony protocol, imon, and the nec protocol (in case the remote does *not* use the repeat message). > Commit de142c32410649e64d44928505ffad2176a96a9e ("media: lirc: implement > reading scancode") would never set the LIRC_SCANCODE_FLAG_REPEAT flag in > the LIRC messages. > > Commit b66218fddfd29f315a103db811152ab0c95fb054 > ("media: lirc: ensure lirc device receives nec repeats") fixed it up for > those protocol drivers that may call rc_repeat(). > --- Thanks Sean