From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Petko Manolov <petko.manolov@konsulko.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH v1 1/1] staging: media: imx: imx7-media-csi: Increase video mem limit
Date: Tue, 12 Jul 2022 01:43:40 +0300 [thread overview]
Message-ID: <YsynnMUcdhDBIIIz@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220709073100.158374-2-petko.manolov@konsulko.com>
Hi Petko,
Thank you for the patch.
On Sat, Jul 09, 2022 at 10:31:00AM +0300, Petko Manolov wrote:
> Some high resolution (like Sony IMX492 47Mpix) sensors requre large amount space
> for buffering. 64MB is far from sufficient so this patch increases the limit to
> 512MB.
>
> Signed-off-by: Petko Manolov <petko.manolov@konsulko.com>
> ---
> drivers/staging/media/imx/imx7-media-csi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
> index 0066af8d111f..c62f893cd769 100644
> --- a/drivers/staging/media/imx/imx7-media-csi.c
> +++ b/drivers/staging/media/imx/imx7-media-csi.c
> @@ -160,7 +160,7 @@
>
> #define IMX7_CSI_VIDEO_NAME "imx-capture"
> /* In bytes, per queue */
> -#define IMX7_CSI_VIDEO_MEM_LIMIT SZ_64M
> +#define IMX7_CSI_VIDEO_MEM_LIMIT SZ_512M
The limit is really something that the V4L2 core should handle (or
assist with). In the meantime,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> #define IMX7_CSI_VIDEO_EOF_TIMEOUT 2000
>
> #define IMX7_CSI_DEF_MBUS_CODE MEDIA_BUS_FMT_UYVY8_2X8
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-07-11 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 7:30 [PATCH v1 0/1] staging: media: imx: imx7-media-csi: Increase video mem limit Petko Manolov
2022-07-09 7:31 ` [PATCH v1 1/1] " Petko Manolov
2022-07-11 22:43 ` Laurent Pinchart [this message]
2022-07-12 4:10 ` Petko Manolov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsynnMUcdhDBIIIz@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=petko.manolov@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox