* [PATCH v1 0/1] staging: media: imx: imx7-media-csi: Increase video mem limit
@ 2022-07-09 7:30 Petko Manolov
2022-07-09 7:31 ` [PATCH v1 1/1] " Petko Manolov
0 siblings, 1 reply; 4+ messages in thread
From: Petko Manolov @ 2022-07-09 7:30 UTC (permalink / raw)
To: linux-media; +Cc: laurent.pinchart, Petko Manolov
Some high resolution sensors require larger amounts of RAM than the default
IMX7_CSI_VIDEO_MEM_LIMIT value. Increasing it to 512MB so IMX492 and such can
run in 8192x5556 mode.
Based on git://linuxtv.org/pinchartl/media.git tags/imx7-next-20220707
Petko Manolov (1):
staging: media: imx: imx7-media-csi: Increase video mem limit
drivers/staging/media/imx/imx7-media-csi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 1/1] staging: media: imx: imx7-media-csi: Increase video mem limit
2022-07-09 7:30 [PATCH v1 0/1] staging: media: imx: imx7-media-csi: Increase video mem limit Petko Manolov
@ 2022-07-09 7:31 ` Petko Manolov
2022-07-11 22:43 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Petko Manolov @ 2022-07-09 7:31 UTC (permalink / raw)
To: linux-media; +Cc: laurent.pinchart, Petko Manolov
Some high resolution (like Sony IMX492 47Mpix) sensors requre large amount space
for buffering. 64MB is far from sufficient so this patch increases the limit to
512MB.
Signed-off-by: Petko Manolov <petko.manolov@konsulko.com>
---
drivers/staging/media/imx/imx7-media-csi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
index 0066af8d111f..c62f893cd769 100644
--- a/drivers/staging/media/imx/imx7-media-csi.c
+++ b/drivers/staging/media/imx/imx7-media-csi.c
@@ -160,7 +160,7 @@
#define IMX7_CSI_VIDEO_NAME "imx-capture"
/* In bytes, per queue */
-#define IMX7_CSI_VIDEO_MEM_LIMIT SZ_64M
+#define IMX7_CSI_VIDEO_MEM_LIMIT SZ_512M
#define IMX7_CSI_VIDEO_EOF_TIMEOUT 2000
#define IMX7_CSI_DEF_MBUS_CODE MEDIA_BUS_FMT_UYVY8_2X8
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] staging: media: imx: imx7-media-csi: Increase video mem limit
2022-07-09 7:31 ` [PATCH v1 1/1] " Petko Manolov
@ 2022-07-11 22:43 ` Laurent Pinchart
2022-07-12 4:10 ` Petko Manolov
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2022-07-11 22:43 UTC (permalink / raw)
To: Petko Manolov; +Cc: linux-media
Hi Petko,
Thank you for the patch.
On Sat, Jul 09, 2022 at 10:31:00AM +0300, Petko Manolov wrote:
> Some high resolution (like Sony IMX492 47Mpix) sensors requre large amount space
> for buffering. 64MB is far from sufficient so this patch increases the limit to
> 512MB.
>
> Signed-off-by: Petko Manolov <petko.manolov@konsulko.com>
> ---
> drivers/staging/media/imx/imx7-media-csi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
> index 0066af8d111f..c62f893cd769 100644
> --- a/drivers/staging/media/imx/imx7-media-csi.c
> +++ b/drivers/staging/media/imx/imx7-media-csi.c
> @@ -160,7 +160,7 @@
>
> #define IMX7_CSI_VIDEO_NAME "imx-capture"
> /* In bytes, per queue */
> -#define IMX7_CSI_VIDEO_MEM_LIMIT SZ_64M
> +#define IMX7_CSI_VIDEO_MEM_LIMIT SZ_512M
The limit is really something that the V4L2 core should handle (or
assist with). In the meantime,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> #define IMX7_CSI_VIDEO_EOF_TIMEOUT 2000
>
> #define IMX7_CSI_DEF_MBUS_CODE MEDIA_BUS_FMT_UYVY8_2X8
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] staging: media: imx: imx7-media-csi: Increase video mem limit
2022-07-11 22:43 ` Laurent Pinchart
@ 2022-07-12 4:10 ` Petko Manolov
0 siblings, 0 replies; 4+ messages in thread
From: Petko Manolov @ 2022-07-12 4:10 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-media
On 22-07-12 01:43:40, Laurent Pinchart wrote:
> Hi Petko,
>
> Thank you for the patch.
>
> On Sat, Jul 09, 2022 at 10:31:00AM +0300, Petko Manolov wrote:
> > Some high resolution (like Sony IMX492 47Mpix) sensors requre large amount space
> > for buffering. 64MB is far from sufficient so this patch increases the limit to
> > 512MB.
> >
> > Signed-off-by: Petko Manolov <petko.manolov@konsulko.com>
> > ---
> > drivers/staging/media/imx/imx7-media-csi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
> > index 0066af8d111f..c62f893cd769 100644
> > --- a/drivers/staging/media/imx/imx7-media-csi.c
> > +++ b/drivers/staging/media/imx/imx7-media-csi.c
> > @@ -160,7 +160,7 @@
> >
> > #define IMX7_CSI_VIDEO_NAME "imx-capture"
> > /* In bytes, per queue */
> > -#define IMX7_CSI_VIDEO_MEM_LIMIT SZ_64M
> > +#define IMX7_CSI_VIDEO_MEM_LIMIT SZ_512M
>
> The limit is really something that the V4L2 core should handle (or assist
> with). In the meantime,
Thanks for the review.
This "limit" isn't actually a limit, but a constant used in very few
calculations. Perhaps this is a number that will be better handled by more
knowledgeable part of the system.
Petko
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > #define IMX7_CSI_VIDEO_EOF_TIMEOUT 2000
> >
> > #define IMX7_CSI_DEF_MBUS_CODE MEDIA_BUS_FMT_UYVY8_2X8
>
> --
> Regards,
>
> Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-12 4:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-09 7:30 [PATCH v1 0/1] staging: media: imx: imx7-media-csi: Increase video mem limit Petko Manolov
2022-07-09 7:31 ` [PATCH v1 1/1] " Petko Manolov
2022-07-11 22:43 ` Laurent Pinchart
2022-07-12 4:10 ` Petko Manolov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox