* [PATCH] media: vimc: fix an error code in vimc_create_links()
@ 2022-07-19 13:47 Dan Carpenter
2022-07-19 13:58 ` Kieran Bingham
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-07-19 13:47 UTC (permalink / raw)
To: Shuah Khan, Yunke Cao
Cc: Kieran Bingham, Mauro Carvalho Chehab, linux-media,
kernel-janitors
Use the correct "ret_link" variable instead of "link".
Fixes: d534b9520a12 ("media: vimc: add ancillary lens")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/media/test-drivers/vimc/vimc-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/test-drivers/vimc/vimc-core.c b/drivers/media/test-drivers/vimc/vimc-core.c
index c73f91947f44..2ae7a0f11ebf 100644
--- a/drivers/media/test-drivers/vimc/vimc-core.c
+++ b/drivers/media/test-drivers/vimc/vimc-core.c
@@ -211,7 +211,7 @@ static int vimc_create_links(struct vimc_device *vimc)
media_create_ancillary_link(ved_primary->ent, ved_ancillary->ent);
if (IS_ERR(ret_link)) {
- ret = PTR_ERR(link);
+ ret = PTR_ERR(ret_link);
goto err_rm_links;
}
}
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media: vimc: fix an error code in vimc_create_links()
2022-07-19 13:47 [PATCH] media: vimc: fix an error code in vimc_create_links() Dan Carpenter
@ 2022-07-19 13:58 ` Kieran Bingham
0 siblings, 0 replies; 2+ messages in thread
From: Kieran Bingham @ 2022-07-19 13:58 UTC (permalink / raw)
To: Dan Carpenter, Shuah Khan, Yunke Cao
Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
Hi Dan,
Quoting Dan Carpenter (2022-07-19 14:47:16)
> Use the correct "ret_link" variable instead of "link".
>
> Fixes: d534b9520a12 ("media: vimc: add ancillary lens")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for the patch, but it's been preceeded twice now.
[0] https://lore.kernel.org/linux-media/4fd23b1c-8a0a-1691-a4f9-526ec99bd193@xs4all.nl/
[1] https://lore.kernel.org/linux-media/20220719071721.703986-1-yangyingliang@huawei.com/
--
Kieran
> ---
> drivers/media/test-drivers/vimc/vimc-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/test-drivers/vimc/vimc-core.c b/drivers/media/test-drivers/vimc/vimc-core.c
> index c73f91947f44..2ae7a0f11ebf 100644
> --- a/drivers/media/test-drivers/vimc/vimc-core.c
> +++ b/drivers/media/test-drivers/vimc/vimc-core.c
> @@ -211,7 +211,7 @@ static int vimc_create_links(struct vimc_device *vimc)
> media_create_ancillary_link(ved_primary->ent, ved_ancillary->ent);
>
> if (IS_ERR(ret_link)) {
> - ret = PTR_ERR(link);
> + ret = PTR_ERR(ret_link);
> goto err_rm_links;
> }
> }
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-19 14:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-19 13:47 [PATCH] media: vimc: fix an error code in vimc_create_links() Dan Carpenter
2022-07-19 13:58 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox