Re: [PATCH] media: vimc: fix an error code in vimc_create_links()

Kieran Bingham
2022-07-19T14:20:27Z

Hi Dan,

Quoting Dan Carpenter (2022-07-19 14:47:16)
> Use the correct "ret_link" variable instead of "link".
>
> Fixes: d534b9520a12 ("media: vimc: add ancillary lens")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks for the patch, but it's been preceeded twice now.

[0] https://lore.kernel.org/linux-media/4fd23b1c-8a0a-1691-a4f9-526ec99bd193@xs4all.nl/
[1] https://lore.kernel.org/linux-media/20220719071721.703986-1-yangyingliang@huawei.com/

--
Kieran

> ---
> drivers/media/test-drivers/vimc/vimc-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/test-drivers/vimc/vimc-core.c b/drivers/media/test-drivers/vimc/vimc-core.c
> index c73f91947f44..2ae7a0f11ebf 100644
> --- a/drivers/media/test-drivers/vimc/vimc-core.c
> +++ b/drivers/media/test-drivers/vimc/vimc-core.c
> @@ -211,7 +211,7 @@ static int vimc_create_links(struct vimc_device *vimc)
> media_create_ancillary_link(ved_primary->ent, ved_ancillary->ent);
>
> if (IS_ERR(ret_link)) {
> - ret = PTR_ERR(link);
> + ret = PTR_ERR(ret_link);
> goto err_rm_links;
> }
> }
> --
> 2.35.1
>