From: Greg KH <gregkh@linuxfoundation.org>
To: Chen Shi <shichen01@baidu.com>
Cc: slongerbeam@gmail.com, p.zabel@pengutronix.de,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] media: staging: media: imx: imx7-media-utils: Fix a coding style problem
Date: Thu, 4 Aug 2022 10:23:42 +0200 [thread overview]
Message-ID: <YuuCDsMej1FYrSF7@kroah.com> (raw)
In-Reply-To: <20220804071046.31520-1-shichen01@baidu.com>
On Thu, Aug 04, 2022 at 03:10:46PM +0800, Chen Shi wrote:
> Add parentheses to enclose macros with complex values.
Why?
>
> Signed-off-by: Chen Shi <shichen01@baidu.com>
> ---
> drivers/staging/media/imx/imx-media-utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c
> index 294c808b2ebe..c94013175181 100644
> --- a/drivers/staging/media/imx/imx-media-utils.c
> +++ b/drivers/staging/media/imx/imx-media-utils.c
> @@ -7,7 +7,7 @@
> #include <linux/module.h>
> #include "imx-media.h"
>
> -#define IMX_BUS_FMTS(fmt...) (const u32[]) {fmt, 0}
> +#define IMX_BUS_FMTS(fmt...) {(const u32[]) {fmt, 0}}
What does this change? Why make this change at all?
confused,
greg k-h
next prev parent reply other threads:[~2022-08-04 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 7:10 [PATCH] media: staging: media: imx: imx7-media-utils: Fix a coding style problem Chen Shi
2022-08-04 8:23 ` Greg KH [this message]
2022-08-04 8:46 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuuCDsMej1FYrSF7@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=shichen01@baidu.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox