From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BB34C32772 for ; Tue, 23 Aug 2022 17:02:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343593AbiHWRB4 (ORCPT ); Tue, 23 Aug 2022 13:01:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344337AbiHWRBM (ORCPT ); Tue, 23 Aug 2022 13:01:12 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94BD48B9A8; Tue, 23 Aug 2022 07:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661263840; x=1692799840; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ygPyyv+pU7SFDB61ANVVMzLHJfkZTW1nqc/MGK8nQSs=; b=fHoWHDkqGG/DkLu9Sxx5O4huPaIoiZNt8MndxlG7aZg5GjCLMEwPPHjD xJTDqAr3aZwJwQ3RkxfXHquqshAmbg2eHxEQyBUgMqlKpozrwIOrHJdMB djC8SbxCtstI9m29IzIq1y71n8Bn/6AtTcV7jIfn8TJQoTLIE/UTMsV/6 xrZiJYsRJGA7v1OVwmFSwkU85GEq8ixSHgv0iTwGj9lrvp+eaPjiBmmfL ZEqDwzbRShEioyU5MZILpf9kAxUztind/lUDCp/CN74VyMZB5bzPcX3Rp fEM9HRrSK80XPF/SiaKvNTo8iIkAqmPVJmD/Y+YuhKy8y6MJrbudiDm36 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10448"; a="294978544" X-IronPort-AV: E=Sophos;i="5.93,257,1654585200"; d="scan'208";a="294978544" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2022 07:10:40 -0700 X-IronPort-AV: E=Sophos;i="5.93,257,1654585200"; d="scan'208";a="642453030" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2022 07:10:38 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oQUbz-002T6k-2M; Tue, 23 Aug 2022 17:10:35 +0300 Date: Tue, 23 Aug 2022 17:10:35 +0300 From: Andy Shevchenko To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tianshu Qiu , Shawn Tu , Bingbu Cao , Mauro Carvalho Chehab Subject: Re: [PATCH v1 1/8] media: ov2740: Remove duplicative pointer in struct nvm_data Message-ID: References: <20220726120556.2881-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220726120556.2881-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Jul 26, 2022 at 03:05:49PM +0300, Andy Shevchenko wrote: > The struct i2c_client pointer is used only to get driver data, > associated with a struct device or print messages on behalf. > Moreover, the very same pointer to a struct device is already > assigned by a regmap and can be retrieved from there. > No need to keep a duplicative pointer. Thanks, Bungbu, for the review. Can it be now applied? -- With Best Regards, Andy Shevchenko