* [PATCH] media: platform: mtk-mdp3: fix error code in mdp_vpu_dev_init()
@ 2022-09-01 14:47 Dan Carpenter
2022-09-02 9:11 ` AngeloGioacchino Del Regno
2022-09-05 11:43 ` Matthias Brugger
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-09-01 14:47 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Moudy Ho
Cc: Matthias Brugger, Hans Verkuil, daoyuan huang, Ping-Hsun Wu,
linux-media, linux-mediatek, kernel-janitors
Return a negative error code if mdp_vpu_shared_mem_alloc() fails.
Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c
index 9f5844385c8f..a72bed927bb6 100644
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c
@@ -173,7 +173,8 @@ int mdp_vpu_dev_init(struct mdp_vpu_dev *vpu, struct mtk_scp *scp,
/* vpu work_size was set in mdp_vpu_ipi_handle_init_ack */
mem_size = vpu_alloc_size;
- if (mdp_vpu_shared_mem_alloc(vpu)) {
+ err = mdp_vpu_shared_mem_alloc(vpu);
+ if (err) {
dev_err(&mdp->pdev->dev, "VPU memory alloc fail!");
goto err_mem_alloc;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] media: platform: mtk-mdp3: fix error code in mdp_vpu_dev_init()
2022-09-01 14:47 [PATCH] media: platform: mtk-mdp3: fix error code in mdp_vpu_dev_init() Dan Carpenter
@ 2022-09-02 9:11 ` AngeloGioacchino Del Regno
2022-09-05 11:43 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-09-02 9:11 UTC (permalink / raw)
To: Dan Carpenter, Mauro Carvalho Chehab, Moudy Ho
Cc: Matthias Brugger, Hans Verkuil, daoyuan huang, Ping-Hsun Wu,
linux-media, linux-mediatek, kernel-janitors
Il 01/09/22 16:47, Dan Carpenter ha scritto:
> Return a negative error code if mdp_vpu_shared_mem_alloc() fails.
>
> Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: platform: mtk-mdp3: fix error code in mdp_vpu_dev_init()
2022-09-01 14:47 [PATCH] media: platform: mtk-mdp3: fix error code in mdp_vpu_dev_init() Dan Carpenter
2022-09-02 9:11 ` AngeloGioacchino Del Regno
@ 2022-09-05 11:43 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2022-09-05 11:43 UTC (permalink / raw)
To: Dan Carpenter, Mauro Carvalho Chehab, Moudy Ho
Cc: Hans Verkuil, daoyuan huang, Ping-Hsun Wu, linux-media,
linux-mediatek, kernel-janitors
On 01/09/2022 16:47, Dan Carpenter wrote:
> Return a negative error code if mdp_vpu_shared_mem_alloc() fails.
>
> Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c
> index 9f5844385c8f..a72bed927bb6 100644
> --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c
> +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c
> @@ -173,7 +173,8 @@ int mdp_vpu_dev_init(struct mdp_vpu_dev *vpu, struct mtk_scp *scp,
> /* vpu work_size was set in mdp_vpu_ipi_handle_init_ack */
>
> mem_size = vpu_alloc_size;
> - if (mdp_vpu_shared_mem_alloc(vpu)) {
> + err = mdp_vpu_shared_mem_alloc(vpu);
> + if (err) {
> dev_err(&mdp->pdev->dev, "VPU memory alloc fail!");
> goto err_mem_alloc;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-05 11:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-01 14:47 [PATCH] media: platform: mtk-mdp3: fix error code in mdp_vpu_dev_init() Dan Carpenter
2022-09-02 9:11 ` AngeloGioacchino Del Regno
2022-09-05 11:43 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox