Re: [PATCH 1/1] sun6i-mipi-csi2: Depend on PHY_SUN6I_MIPI_DPHY

[Paul Kocialkowski <paul.kocialkowski@bootlin.com>]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

Hi Sakari,

On Fri 09 Sep 22, 14:36, Sakari Ailus wrote:
> Hi Paul,
> 
> On Fri, Sep 09, 2022 at 04:00:37PM +0200, Paul Kocialkowski wrote:
> > Hi Sakari,
> > 
> > On Mon 05 Sep 22, 13:00, Sakari Ailus wrote:
> > > PHY_SUN6I_MIPI_DPHY is not a freely selectable option and so may not
> > > always be available. Depend on it instead.
> > 
> > I don't get what you mean by "not a freely selectable option".
> > It's definitely a tristate. Also no build issue will occur if it's
> > unselected (but I guess that's not the point here).
> 
> It depends on a number of other configuration options. You can force the
> value of the option itself but not its dependencies. This can lead to build
> errors dependin on the values of the options PHY_SUN6I_MIPI_DPHY needs.

Ah yes I see, it's the usual issue with select selecting the option regardless
of its dependencies. My bad.

Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Thanks,

Paul

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]