Re: [PATCH v7 0/5] Switch build system to meson

Laurent Pinchart
2023-02-12T00:10:43Z

Hi Hans,

On Tue, Sep 13, 2022 at 11:51:01AM +0300, Laurent Pinchart wrote:
> On Tue, Sep 13, 2022 at 08:15:43AM +0100, Hans Verkuil wrote:
> > On 9/12/22 23:29, Laurent Pinchart wrote:
> > > On Mon, Sep 12, 2022 at 04:41:33PM +0200, Gregor Jasny wrote:
> > >> Hello Laurent and all the other helping hands,
> > >>
> > >> On 9/9/22 3:44 PM, Laurent Pinchart wrote:
> > >>> This series is the latest (and greatest) attempt to switch v4l-utils
> > >>> from autotools to meson.
> > >>>
> > >>> Compared to v6, the first noticeable change is that fixups have been
> > >>> squashed into their corresponding commit. Detailed changelogs are now
> > >>> included in individual patches.
> > >>
> > >> Tested-by: Gregor Jasny <gjasny@googlemail.com>
> > >>
> > >> v7 is still working as expected with my Debian and Ubuntu packaging scripts.
> > >
> > > Thanks for testing. I'll post a v8 with the improvements suggested in
> > > the review comments. I will also include updates to the
> > > v4l-utils.spec.in file, and would appreciate help testing it.
> > >
> > >> What would you think would be a good time to release these changes?
> > >> Should I do a release shortly after the this change has landed?
> > >
> > > I think that would be a good idea. Once v8 is out, if there are no more
> > > issues, I think it could be merged.
> >
> > Two questions: for meson, what is the equivalent to 'make distclean'?
> > Just rm -rf build?
>
> That's correct. Meson doesn't make *any* change to the source directory.
>
> > And another: if I enable building for v4l2-ctl-32 and
> > v4l2-compliance-32, then those targets aren't build AFAICS.
>
> I'll check that (a bit busy this week with ELC and LPC).

They get built for me. I've rebased meson support on top of the latest
master branch and fixed lots of small issues, so I may have fixed this
at the same time. I'll post v8 soon, if you still experience the
problem, I'll debug it with you.

> > It's needed for testing 32-bit compat code.