From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C737C54EE9 for ; Mon, 19 Sep 2022 12:56:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230243AbiISM4G (ORCPT ); Mon, 19 Sep 2022 08:56:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229968AbiISM4F (ORCPT ); Mon, 19 Sep 2022 08:56:05 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2F6A6340; Mon, 19 Sep 2022 05:56:04 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 63EA59BA; Mon, 19 Sep 2022 14:56:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1663592163; bh=9Mr46YmjsLRLVKJjiWth2KE6xqw9og/WajL2NO3Thzk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T6P0cs8/Wc3eM6BOHjJ92Dhs2KBhqeCDREldv0Ey5zThraVeQXt+ujxhsDBJxVwZd Ast/CRgcxmpg/A3JVsTgScgHp6wOx2EQ5KVwJyrxwndlbqDP4AUQ1sG8TsNvqK4HXe zltmcmR6NjoGIT0pHEMytrLt4b7l6MPrhmXN0Nj4= Date: Mon, 19 Sep 2022 15:55:50 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: Marco Felsch , mchehab@kernel.org, akinobu.mita@gmail.com, jacopo+renesas@jmondi.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] media: mt9m111: fix device power usage Message-ID: References: <20220916135713.143890-1-m.felsch@pengutronix.de> <20220916135713.143890-2-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Sep 19, 2022 at 12:45:42PM +0000, Sakari Ailus wrote: > Hi Marco, > > On Fri, Sep 16, 2022 at 03:57:12PM +0200, Marco Felsch wrote: > > @@ -758,10 +751,14 @@ static int mt9m111_g_register(struct v4l2_subdev *sd, > > if (reg->reg > 0x2ff) > > return -EINVAL; > > > > + mt9m111_s_power(sd, 1); > > It would be nice to have this driver converted to runtime PM. Up to you. I second that :-) -- Regards, Laurent Pinchart