From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0996C6FA8B for ; Wed, 21 Sep 2022 17:30:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230478AbiIUR36 (ORCPT ); Wed, 21 Sep 2022 13:29:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229691AbiIUR34 (ORCPT ); Wed, 21 Sep 2022 13:29:56 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE1567EFEE; Wed, 21 Sep 2022 10:29:51 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3BF562B3; Wed, 21 Sep 2022 19:29:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1663781389; bh=xPqHUNUFG+tIvsP/BcL8a2dVocDkJmX1/1xwEyvJHwU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U8y/mjr2jud/ZjWrTt73gyYEqC8uMIQDNaWQFlbo/D/XfFcTfhzFwbzaHzWc+m7lG mEXQqzHxzLc/HR00fLFyeJHlcLEE4i1sBQOya2wc9fK5uIqB9sLYyZ4j1ZmV1L2rpA SrLQopUnBYvQDo91oTG8k1g7w4nPtSDMApvmv9D0= Date: Wed, 21 Sep 2022 20:29:34 +0300 From: Laurent Pinchart To: Krzysztof Kozlowski Cc: Lad Prabhakar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Philipp Zabel , Jacopo Mondi , Niklas =?utf-8?Q?S=C3=B6derlund?= , Sakari Ailus , Hans Verkuil , Geert Uytterhoeven , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das Subject: Re: [PATCH v2 2/4] media: dt-bindings: Document Renesas RZ/G2L CRU block Message-ID: References: <20220905230406.30801-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220905230406.30801-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <29d456ed-620c-8dc9-01f0-54f96b670b94@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, Sep 21, 2022 at 05:51:29PM +0200, Krzysztof Kozlowski wrote: > On 21/09/2022 14:43, Laurent Pinchart wrote: > > On Thu, Sep 08, 2022 at 01:40:39PM +0200, Krzysztof Kozlowski wrote: > >> On 06/09/2022 01:04, Lad Prabhakar wrote: > >>> Document the CRU block found on Renesas RZ/G2L (and alike) SoCs. > >>> > >>> Signed-off-by: Lad Prabhakar > >>> Reviewed-by: Laurent Pinchart > >> > >> Thank you for your patch. There is something to discuss/improve. > >> > >>> +properties: > >>> + compatible: > >>> + items: > >>> + - enum: > >>> + - renesas,r9a07g044-cru # RZ/G2{L,LC} > >>> + - renesas,r9a07g054-cru # RZ/V2L > >>> + - const: renesas,rzg2l-cru > >>> + > >>> + reg: > >>> + maxItems: 1 > >>> + > >>> + interrupts: > >>> + maxItems: 3 > >>> + > >>> + interrupt-names: > >>> + items: > >>> + - const: image_conv > >>> + - const: image_conv_err > >>> + - const: axi_mst_err > >>> + > >>> + clocks: > >>> + items: > >>> + - description: CRU Main clock > >>> + - description: CPU Register access clock > >>> + - description: CRU image transfer clock > >>> + > >>> + clock-names: > >>> + items: > >>> + - const: vclk > >>> + - const: pclk > >>> + - const: aclk > >> > >> Drop the "clk" suffixes. Remaining names could be made a bit more readable. > > > > These names come from the documentation, isn't it better to match the > > datasheet ? > > If datasheet calls it "vclk_really_clk_it_is_clk_clk", it's not the > reason to use it. :) > > The "clk" is redundant even if the hardware engineer thought different. > > The same for IRQs ("tx" not "txirq"), for dmas ("tx" not "txdma"). I'd argue that naming clocks "v", "p" and "a" would be less readable and more confusing. Is this a new rule ? -- Regards, Laurent Pinchart