From: Greg KH <gregkh@linuxfoundation.org>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>
Cc: linux-usb@vger.kernel.org, linux-media@vger.kernel.org,
balbi@kernel.org, laurent.pinchart@ideasonboard.com,
kernel@pengutronix.de
Subject: Re: [PATCH] usb: gadget: uvc: don't put item still in use
Date: Fri, 30 Sep 2022 13:58:35 +0200 [thread overview]
Message-ID: <YzbZ62gq3i4n7Vhx@kroah.com> (raw)
In-Reply-To: <20220929144124.1365686-1-m.grzeschik@pengutronix.de>
On Thu, Sep 29, 2022 at 04:41:24PM +0200, Michael Grzeschik wrote:
> With the patch "15a286a0bb08 (usb: gadget: uvc: add v4l2 enumeration api
> calls)" the driver is keeping a list of configfs entries currently
> configured. The list is used in uvc_v4l2 on runtime.
>
> The driver now is giving back the list item just after it was referenced
> with config_item_put. It also calls config_item_put on uvc_free, which
> is the only and right place to give back the reference. This patch fixes
> the issue by removing the extra config_item_put in uvc_alloc.
>
> Fixes: 15a286a0bb08 (usb: gadget: uvc: add v4l2 enumeration api calls)
This is not a commit in any of my trees. Are you sure it's a valid one?
thanks,
greg k-h
next prev parent reply other threads:[~2022-09-30 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 14:41 [PATCH] usb: gadget: uvc: don't put item still in use Michael Grzeschik
2022-09-30 11:58 ` Greg KH [this message]
2022-09-30 12:28 ` [PATCH v2] " Michael Grzeschik
2022-09-30 16:17 ` Laurent Pinchart
2022-09-30 20:44 ` Michael Grzeschik
2022-10-02 22:49 ` Michael Grzeschik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzbZ62gq3i4n7Vhx@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox