public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy@kernel.org>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/2] media: atomisp: Fix Wformat-truncation warning
Date: Wed, 2 Apr 2025 13:42:34 +0300	[thread overview]
Message-ID: <Z-0UmpbjvrKASXIu@smile.fi.intel.com> (raw)
In-Reply-To: <20250401-v614-v2-1-53024c4fcdc7@chromium.org>

On Tue, Apr 01, 2025 at 02:17:54PM +0000, Ricardo Ribalda wrote:
> Gcc8 is convinced that we do not have enough space in dot_id_input_bin.
> Extend the variable 17 bytes which is just used for debugging.
> 
> drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c:1336:9: warning: '(pipe' directive output may be truncated writing 5 bytes into a region of size between 1 and 74 [-Wformat-truncation=]

Note, you may drop the drivers/staging/media/ as the driver is unique enough.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

...

You also want to send this patch separately since the AtomISP has its own
MAINTAINERS record (and there are patches in the queue there, IIRC).

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-04-02 10:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01 14:17 [PATCH v2 0/2] media: Fix gcc8 warnings Ricardo Ribalda
2025-04-01 14:17 ` [PATCH v2 1/2] media: atomisp: Fix Wformat-truncation warning Ricardo Ribalda
2025-04-02 10:42   ` Andy Shevchenko [this message]
2025-04-01 14:17 ` [PATCH v2 2/2] media: cec: extron-da-hd-4k-plus: Fix Wformat-truncation Ricardo Ribalda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-0UmpbjvrKASXIu@smile.fi.intel.com \
    --to=andy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=ribalda@chromium.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox