From: Dan Carpenter <dan.carpenter@linaro.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Gabriel Shahrouzi <gshahrouzi@gmail.com>,
linux-media@vger.kernel.org, andy@kernel.org,
hdegoede@redhat.com, mchehab@kernel.org,
sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2] staging: media: Fix indentation to use tabs instead of spaces
Date: Thu, 3 Apr 2025 15:36:27 +0300 [thread overview]
Message-ID: <Z-6Ay7T3n1vXfAO9@stanley.mountain> (raw)
In-Reply-To: <CAHp75Vc1nB8cDN=OcCJgeti3YNr0Dd4yeKgeSBvR95piLao1rg@mail.gmail.com>
On Wed, Apr 02, 2025 at 05:36:31PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 2, 2025 at 4:50 PM Gabriel Shahrouzi <gshahrouzi@gmail.com> wrote:
> >
> > Replace spaces with tab to comply with kernel coding style.
>
> Still 'tab'. please, capitalize it to be 'TAB'.
>
> But wait a bit, the driver maintainer might do that for you whilst applying.
It's not an acronym so it shouldn't be capitalized. It should be either
"a tab" or "tabs".
regards,
dan carpenter
next prev parent reply other threads:[~2025-04-03 12:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 13:50 [PATCH v2] staging: media: Fix indentation to use tabs instead of spaces Gabriel Shahrouzi
2025-04-02 14:36 ` Andy Shevchenko
2025-04-03 0:20 ` Gabriel
2025-04-03 12:36 ` Dan Carpenter [this message]
2025-04-03 13:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-6Ay7T3n1vXfAO9@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gshahrouzi@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox