From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Dan Scally" <djrscally@gmail.com>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Hao Yao" <hao.yao@intel.com>,
"Bingbu Cao" <bingbu.cao@intel.com>,
platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 5/8] platform/x86: int3472: Make regulator supply name configurable
Date: Tue, 25 Mar 2025 18:53:55 +0200 [thread overview]
Message-ID: <Z-LfoxE3VU3Z0v6P@smile.fi.intel.com> (raw)
In-Reply-To: <20250325161340.342192-6-hdegoede@redhat.com>
On Tue, Mar 25, 2025 at 05:13:37PM +0100, Hans de Goede wrote:
> This is a preparation patch for registering multiple regulators, which
> requires a different supply-name for each regulator. Make supply-name
> a parameter to skl_int3472_register_regulator() and use con-id to set it
> so that the existing int3472_gpio_map remapping can be used with it.
>
> Since supply-name now is a parameter, drop the fixed
> skl_int3472_regulator_map_supplies[] array and instead add lower- +
> upper-case mappings of the passed in supply-name to the regulator.
...
> + if (strlen(supply_name) >= GPIO_SUPPPLY_NAME_LENGTH) {
Hmm... This can potentially go up to the page fault.
If we are _not_ okay with that, strnlen() should be used.
> + dev_err(int3472->dev, "supply-name '%s' length too long\n", supply_name);
> + return -EOVERFLOW;
This error code is for integers, we use E2BIG for the string lengths.
> + }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-25 16:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 16:13 [PATCH 0/8] platform/x86: int3472: Add handshake pin support Hans de Goede
2025-03-25 16:13 ` [PATCH 1/8] platform/x86: int3472: Add skl_int3472_register_clock() helper Hans de Goede
2025-03-25 16:43 ` Andy Shevchenko
2025-03-25 16:13 ` [PATCH 2/8] platform/x86: int3472: Stop setting a supply-name for GPIO regulators Hans de Goede
2025-03-25 16:44 ` Andy Shevchenko
2025-03-25 16:13 ` [PATCH 3/8] platform/x86: int3472: Drop unused gpio field from struct int3472_gpio_regulator Hans de Goede
2025-03-25 16:47 ` Andy Shevchenko
2025-03-25 16:13 ` [PATCH 4/8] platform/x86: int3472: Rework AVDD second sensor quirk handling Hans de Goede
2025-03-25 16:13 ` [PATCH 5/8] platform/x86: int3472: Make regulator supply name configurable Hans de Goede
2025-03-25 16:53 ` Andy Shevchenko [this message]
2025-03-25 18:08 ` Hans de Goede
2025-03-25 16:13 ` [PATCH 6/8] platform/x86: int3472: Prepare for registering more then 1 GPIO regulator Hans de Goede
2025-03-25 16:13 ` [PATCH 7/8] platform/x86: int3472: Add handshake pin support Hans de Goede
2025-03-25 16:13 ` [PATCH 8/8] platform/x86: int3472: Debug log when remapping pins Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-LfoxE3VU3Z0v6P@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=bingbu.cao@intel.com \
--cc=djrscally@gmail.com \
--cc=hao.yao@intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox