[PATCH] media: allegro-dvt: Moving the current driver to subdirectory

public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] media: allegro-dvt: Moving the current driver to subdirectory
@ 2024-12-02 10:26 Yassine Ouaissa
  2024-12-02 10:55 ` Michael Tretter
  2025-02-06 20:00 ` Nicolas Dufresne
  0 siblings, 2 replies; 8+ messages in thread
From: Yassine Ouaissa @ 2024-12-02 10:26 UTC (permalink / raw)
  Cc: yassine.ouaissa, Mauro Carvalho Chehab, Michael Tretter,
	Pengutronix Kernel Team, Michal Simek, Hans Verkuil,
	Andrzej Pietrasiewicz, Wolfram Sang, Christophe JAILLET,
	Gaosheng Cui, Uwe Kleine-König, Ricardo Ribalda, open list,
	open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
	moderated list:ARM/ZYNQ ARCHITECTURE

In preparation for the upcoming driver update, we need to realocate the
current driver that is not maintained by us ( allegro-dvt ).
This will help ensure a clean transition and avoid any potential
conflicts with the new driver.

This patch is crucial for keeping our directory organized and
facilitating a smooth integration of the new driver

Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com>
---
 MAINTAINERS                                               | 2 +-
 drivers/media/platform/allegro-dvt/Kconfig                | 4 ++--
 drivers/media/platform/allegro-dvt/Makefile               | 8 ++------
 drivers/media/platform/allegro-dvt/zynqmp/Makefile        | 6 ++++++
 .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c    | 0
 .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h    | 0
 .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c    | 0
 .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h    | 0
 .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c    | 0
 .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h    | 0
 .../{allegro-core.c => zynqmp/zynqmp-allegro-core.c}      | 2 +-
 .../{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c}      | 2 +-
 .../{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h}      | 0
 13 files changed, 13 insertions(+), 11 deletions(-)
 create mode 100644 drivers/media/platform/allegro-dvt/zynqmp/Makefile
 rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c (100%)
 rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h (100%)
 rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c (100%)
 rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h (100%)
 rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c (100%)
 rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h (100%)
 rename drivers/media/platform/allegro-dvt/{allegro-core.c => zynqmp/zynqmp-allegro-core.c} (99%)
 rename drivers/media/platform/allegro-dvt/{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c} (99%)
 rename drivers/media/platform/allegro-dvt/{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h} (100%)

diff --git a/MAINTAINERS b/MAINTAINERS
index 7292e4a1ddb8..d79efe6f8992 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -795,7 +795,7 @@ R:	Pengutronix Kernel Team <kernel@pengutronix.de>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 F:	Documentation/devicetree/bindings/media/allegro,al5e.yaml
-F:	drivers/media/platform/allegro-dvt/
+F:	drivers/media/platform/allegro-dvt/zynqmp
 
 ALLIED VISION ALVIUM CAMERA DRIVER
 M:	Tommaso Merciai <tomm.merciai@gmail.com>
diff --git a/drivers/media/platform/allegro-dvt/Kconfig b/drivers/media/platform/allegro-dvt/Kconfig
index 2182e1277568..9bc7e99788b8 100644
--- a/drivers/media/platform/allegro-dvt/Kconfig
+++ b/drivers/media/platform/allegro-dvt/Kconfig
@@ -2,8 +2,8 @@
 
 comment "Allegro DVT media platform drivers"
 
-config VIDEO_ALLEGRO_DVT
-	tristate "Allegro DVT Video IP Core"
+config VIDEO_ZYNQMP_ALLEGRO_DVT
+	tristate "Allegro DVT Video IP Core for ZynqMP"
 	depends on V4L_MEM2MEM_DRIVERS
 	depends on VIDEO_DEV
 	depends on ARCH_ZYNQMP || COMPILE_TEST
diff --git a/drivers/media/platform/allegro-dvt/Makefile b/drivers/media/platform/allegro-dvt/Makefile
index 66108a303774..04727c5f7ef4 100644
--- a/drivers/media/platform/allegro-dvt/Makefile
+++ b/drivers/media/platform/allegro-dvt/Makefile
@@ -1,6 +1,2 @@
-# SPDX-License-Identifier: GPL-2.0
-
-allegro-objs := allegro-core.o allegro-mail.o
-allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
-
-obj-$(CONFIG_VIDEO_ALLEGRO_DVT) += allegro.o
+# SPDX-License-Identifier: GPL-2.0-only
+obj-y += zynqmp/
diff --git a/drivers/media/platform/allegro-dvt/zynqmp/Makefile b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
new file mode 100644
index 000000000000..a8ddb9cf93a8
--- /dev/null
+++ b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: GPL-2.0
+
+zynqmp-allegro-objs := zynqmp-allegro-core.o zynqmp-allegro-mail.o
+zynqmp-allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
+
+obj-$(CONFIG_VIDEO_ZYNQMP_ALLEGRO_DVT) += zynqmp-allegro.o
diff --git a/drivers/media/platform/allegro-dvt/nal-h264.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
similarity index 100%
rename from drivers/media/platform/allegro-dvt/nal-h264.c
rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
diff --git a/drivers/media/platform/allegro-dvt/nal-h264.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
similarity index 100%
rename from drivers/media/platform/allegro-dvt/nal-h264.h
rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
similarity index 100%
rename from drivers/media/platform/allegro-dvt/nal-hevc.c
rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
similarity index 100%
rename from drivers/media/platform/allegro-dvt/nal-hevc.h
rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
similarity index 100%
rename from drivers/media/platform/allegro-dvt/nal-rbsp.c
rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
similarity index 100%
rename from drivers/media/platform/allegro-dvt/nal-rbsp.h
rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
diff --git a/drivers/media/platform/allegro-dvt/allegro-core.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
similarity index 99%
rename from drivers/media/platform/allegro-dvt/allegro-core.c
rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
index e491399afcc9..8895d7755987 100644
--- a/drivers/media/platform/allegro-dvt/allegro-core.c
+++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
@@ -31,7 +31,7 @@
 #include <media/videobuf2-dma-contig.h>
 #include <media/videobuf2-v4l2.h>
 
-#include "allegro-mail.h"
+#include "zynqmp-allegro-mail.h"
 #include "nal-h264.h"
 #include "nal-hevc.h"
 
diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
similarity index 99%
rename from drivers/media/platform/allegro-dvt/allegro-mail.c
rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
index aadc947a77ae..88a98f9e5d00 100644
--- a/drivers/media/platform/allegro-dvt/allegro-mail.c
+++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
@@ -12,7 +12,7 @@
 #include <linux/string.h>
 #include <linux/videodev2.h>
 
-#include "allegro-mail.h"
+#include "zynqmp-allegro-mail.h"
 
 const char *msg_type_name(enum mcu_msg_type type)
 {
diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.h b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h
similarity index 100%
rename from drivers/media/platform/allegro-dvt/allegro-mail.h
rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] media: allegro-dvt: Moving the current driver to subdirectory
  2024-12-02 10:26 [PATCH] media: allegro-dvt: Moving the current driver to subdirectory Yassine Ouaissa
@ 2024-12-02 10:55 ` Michael Tretter
  2024-12-04 14:44   ` Yassine Ouaissa
  2025-02-06 20:00 ` Nicolas Dufresne
  1 sibling, 1 reply; 8+ messages in thread
From: Michael Tretter @ 2024-12-02 10:55 UTC (permalink / raw)
  To: Yassine Ouaissa
  Cc: Mauro Carvalho Chehab, Pengutronix Kernel Team, Michal Simek,
	Hans Verkuil, Andrzej Pietrasiewicz, Wolfram Sang,
	Christophe JAILLET, Gaosheng Cui, Uwe Kleine-König,
	Ricardo Ribalda, open list,
	open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
	moderated list:ARM/ZYNQ ARCHITECTURE

Hi Yassine,

On Mon, 02 Dec 2024 11:26:38 +0100, Yassine Ouaissa wrote:
> In preparation for the upcoming driver update, we need to realocate the
> current driver that is not maintained by us ( allegro-dvt ).
> This will help ensure a clean transition and avoid any potential
> conflicts with the new driver.

What kind of conflicts do you encounter or expect? It's kind of
surprising that your driver would conflict with anything in the existing
driver.

> 
> This patch is crucial for keeping our directory organized and
> facilitating a smooth integration of the new driver

I'd like to see how you plan to integrate your driver, what it looks
like and what conflicts with the existing driver actually occur. Without
that information I don't see the point in moving the driver to a
sub-directory.

Michael

> 
> Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com>
> ---
>  MAINTAINERS                                               | 2 +-
>  drivers/media/platform/allegro-dvt/Kconfig                | 4 ++--
>  drivers/media/platform/allegro-dvt/Makefile               | 8 ++------
>  drivers/media/platform/allegro-dvt/zynqmp/Makefile        | 6 ++++++
>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c    | 0
>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h    | 0
>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c    | 0
>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h    | 0
>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c    | 0
>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h    | 0
>  .../{allegro-core.c => zynqmp/zynqmp-allegro-core.c}      | 2 +-
>  .../{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c}      | 2 +-
>  .../{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h}      | 0
>  13 files changed, 13 insertions(+), 11 deletions(-)
>  create mode 100644 drivers/media/platform/allegro-dvt/zynqmp/Makefile
>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c (100%)
>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h (100%)
>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c (100%)
>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h (100%)
>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c (100%)
>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h (100%)
>  rename drivers/media/platform/allegro-dvt/{allegro-core.c => zynqmp/zynqmp-allegro-core.c} (99%)
>  rename drivers/media/platform/allegro-dvt/{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c} (99%)
>  rename drivers/media/platform/allegro-dvt/{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h} (100%)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7292e4a1ddb8..d79efe6f8992 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -795,7 +795,7 @@ R:	Pengutronix Kernel Team <kernel@pengutronix.de>
>  L:	linux-media@vger.kernel.org
>  S:	Maintained
>  F:	Documentation/devicetree/bindings/media/allegro,al5e.yaml
> -F:	drivers/media/platform/allegro-dvt/
> +F:	drivers/media/platform/allegro-dvt/zynqmp
>  
>  ALLIED VISION ALVIUM CAMERA DRIVER
>  M:	Tommaso Merciai <tomm.merciai@gmail.com>
> diff --git a/drivers/media/platform/allegro-dvt/Kconfig b/drivers/media/platform/allegro-dvt/Kconfig
> index 2182e1277568..9bc7e99788b8 100644
> --- a/drivers/media/platform/allegro-dvt/Kconfig
> +++ b/drivers/media/platform/allegro-dvt/Kconfig
> @@ -2,8 +2,8 @@
>  
>  comment "Allegro DVT media platform drivers"
>  
> -config VIDEO_ALLEGRO_DVT
> -	tristate "Allegro DVT Video IP Core"
> +config VIDEO_ZYNQMP_ALLEGRO_DVT
> +	tristate "Allegro DVT Video IP Core for ZynqMP"
>  	depends on V4L_MEM2MEM_DRIVERS
>  	depends on VIDEO_DEV
>  	depends on ARCH_ZYNQMP || COMPILE_TEST
> diff --git a/drivers/media/platform/allegro-dvt/Makefile b/drivers/media/platform/allegro-dvt/Makefile
> index 66108a303774..04727c5f7ef4 100644
> --- a/drivers/media/platform/allegro-dvt/Makefile
> +++ b/drivers/media/platform/allegro-dvt/Makefile
> @@ -1,6 +1,2 @@
> -# SPDX-License-Identifier: GPL-2.0
> -
> -allegro-objs := allegro-core.o allegro-mail.o
> -allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
> -
> -obj-$(CONFIG_VIDEO_ALLEGRO_DVT) += allegro.o
> +# SPDX-License-Identifier: GPL-2.0-only
> +obj-y += zynqmp/
> diff --git a/drivers/media/platform/allegro-dvt/zynqmp/Makefile b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
> new file mode 100644
> index 000000000000..a8ddb9cf93a8
> --- /dev/null
> +++ b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
> @@ -0,0 +1,6 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +zynqmp-allegro-objs := zynqmp-allegro-core.o zynqmp-allegro-mail.o
> +zynqmp-allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
> +
> +obj-$(CONFIG_VIDEO_ZYNQMP_ALLEGRO_DVT) += zynqmp-allegro.o
> diff --git a/drivers/media/platform/allegro-dvt/nal-h264.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
> similarity index 100%
> rename from drivers/media/platform/allegro-dvt/nal-h264.c
> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
> diff --git a/drivers/media/platform/allegro-dvt/nal-h264.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
> similarity index 100%
> rename from drivers/media/platform/allegro-dvt/nal-h264.h
> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
> diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
> similarity index 100%
> rename from drivers/media/platform/allegro-dvt/nal-hevc.c
> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
> diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
> similarity index 100%
> rename from drivers/media/platform/allegro-dvt/nal-hevc.h
> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
> diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
> similarity index 100%
> rename from drivers/media/platform/allegro-dvt/nal-rbsp.c
> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
> diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
> similarity index 100%
> rename from drivers/media/platform/allegro-dvt/nal-rbsp.h
> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
> diff --git a/drivers/media/platform/allegro-dvt/allegro-core.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
> similarity index 99%
> rename from drivers/media/platform/allegro-dvt/allegro-core.c
> rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
> index e491399afcc9..8895d7755987 100644
> --- a/drivers/media/platform/allegro-dvt/allegro-core.c
> +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
> @@ -31,7 +31,7 @@
>  #include <media/videobuf2-dma-contig.h>
>  #include <media/videobuf2-v4l2.h>
>  
> -#include "allegro-mail.h"
> +#include "zynqmp-allegro-mail.h"
>  #include "nal-h264.h"
>  #include "nal-hevc.h"
>  
> diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
> similarity index 99%
> rename from drivers/media/platform/allegro-dvt/allegro-mail.c
> rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
> index aadc947a77ae..88a98f9e5d00 100644
> --- a/drivers/media/platform/allegro-dvt/allegro-mail.c
> +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
> @@ -12,7 +12,7 @@
>  #include <linux/string.h>
>  #include <linux/videodev2.h>
>  
> -#include "allegro-mail.h"
> +#include "zynqmp-allegro-mail.h"
>  
>  const char *msg_type_name(enum mcu_msg_type type)
>  {
> diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.h b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h
> similarity index 100%
> rename from drivers/media/platform/allegro-dvt/allegro-mail.h
> rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h
> -- 
> 2.30.2
> 
> 

-- 
Pengutronix e.K.                           | Michael Tretter             |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] media: allegro-dvt: Moving the current driver to subdirectory
  2024-12-02 10:55 ` Michael Tretter
@ 2024-12-04 14:44   ` Yassine Ouaissa
  2024-12-04 16:27     ` Michael Tretter
  0 siblings, 1 reply; 8+ messages in thread
From: Yassine Ouaissa @ 2024-12-04 14:44 UTC (permalink / raw)
  To: Michael Tretter
  Cc: Mauro Carvalho Chehab, Pengutronix Kernel Team, Michal Simek,
	Hans Verkuil, Andrzej Pietrasiewicz, Wolfram Sang,
	Christophe JAILLET, Gaosheng Cui, Uwe Kleine-K??nig,
	Ricardo Ribalda, open list,
	open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
	moderated list:ARM/ZYNQ ARCHITECTURE

Hi Michael,

Thank you for the feedback.

On 02.12.2024 11:55, Michael Tretter wrote:
>Hi Yassine,
>
>On Mon, 02 Dec 2024 11:26:38 +0100, Yassine Ouaissa wrote:
>What kind of conflicts do you encounter or expect? It's kind of
>surprising that your driver would conflict with anything in the existing
>driver.

The current "NOT allegro" driver support only the ZynqMP (ex : ZCU106/ZCU104 ).
And the upcoming driver, has support for many platforms.

>I'd like to see how you plan to integrate your driver, what it looks
>like and what conflicts with the existing driver actually occur. Without
>that information I don't see the point in moving the driver to a
>sub-directory.

The upcoming driver is not using the parsing, conversion inside of the
driver. Actually the new Gen of ALLEGRO IP does that.
>
>Michael
>
>>
>> Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com>
>> ---
>>  MAINTAINERS                                               | 2 +-
>>  drivers/media/platform/allegro-dvt/Kconfig                | 4 ++--
>>  drivers/media/platform/allegro-dvt/Makefile               | 8 ++------
>>  drivers/media/platform/allegro-dvt/zynqmp/Makefile        | 6 ++++++
>>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c    | 0
>>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h    | 0
>>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c    | 0
>>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h    | 0
>>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c    | 0
>>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h    | 0
>>  .../{allegro-core.c => zynqmp/zynqmp-allegro-core.c}      | 2 +-
>>  .../{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c}      | 2 +-
>>  .../{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h}      | 0
>>  13 files changed, 13 insertions(+), 11 deletions(-)
>>  create mode 100644 drivers/media/platform/allegro-dvt/zynqmp/Makefile
>>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c (100%)
>>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h (100%)
>>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c (100%)
>>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h (100%)
>>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c (100%)
>>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h (100%)
>>  rename drivers/media/platform/allegro-dvt/{allegro-core.c => zynqmp/zynqmp-allegro-core.c} (99%)
>>  rename drivers/media/platform/allegro-dvt/{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c} (99%)
>>  rename drivers/media/platform/allegro-dvt/{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h} (100%)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 7292e4a1ddb8..d79efe6f8992 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -795,7 +795,7 @@ R:	Pengutronix Kernel Team <kernel@pengutronix.de>
>>  L:	linux-media@vger.kernel.org
>>  S:	Maintained
>>  F:	Documentation/devicetree/bindings/media/allegro,al5e.yaml
>> -F:	drivers/media/platform/allegro-dvt/
>> +F:	drivers/media/platform/allegro-dvt/zynqmp
>>
>>  ALLIED VISION ALVIUM CAMERA DRIVER
>>  M:	Tommaso Merciai <tomm.merciai@gmail.com>
>> diff --git a/drivers/media/platform/allegro-dvt/Kconfig b/drivers/media/platform/allegro-dvt/Kconfig
>> index 2182e1277568..9bc7e99788b8 100644
>> --- a/drivers/media/platform/allegro-dvt/Kconfig
>> +++ b/drivers/media/platform/allegro-dvt/Kconfig
>> @@ -2,8 +2,8 @@
>>
>>  comment "Allegro DVT media platform drivers"
>>
>> -config VIDEO_ALLEGRO_DVT
>> -	tristate "Allegro DVT Video IP Core"
>> +config VIDEO_ZYNQMP_ALLEGRO_DVT
>> +	tristate "Allegro DVT Video IP Core for ZynqMP"
>>  	depends on V4L_MEM2MEM_DRIVERS
>>  	depends on VIDEO_DEV
>>  	depends on ARCH_ZYNQMP || COMPILE_TEST
>> diff --git a/drivers/media/platform/allegro-dvt/Makefile b/drivers/media/platform/allegro-dvt/Makefile
>> index 66108a303774..04727c5f7ef4 100644
>> --- a/drivers/media/platform/allegro-dvt/Makefile
>> +++ b/drivers/media/platform/allegro-dvt/Makefile
>> @@ -1,6 +1,2 @@
>> -# SPDX-License-Identifier: GPL-2.0
>> -
>> -allegro-objs := allegro-core.o allegro-mail.o
>> -allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
>> -
>> -obj-$(CONFIG_VIDEO_ALLEGRO_DVT) += allegro.o
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +obj-y += zynqmp/
>> diff --git a/drivers/media/platform/allegro-dvt/zynqmp/Makefile b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
>> new file mode 100644
>> index 000000000000..a8ddb9cf93a8
>> --- /dev/null
>> +++ b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
>> @@ -0,0 +1,6 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +
>> +zynqmp-allegro-objs := zynqmp-allegro-core.o zynqmp-allegro-mail.o
>> +zynqmp-allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
>> +
>> +obj-$(CONFIG_VIDEO_ZYNQMP_ALLEGRO_DVT) += zynqmp-allegro.o
>> diff --git a/drivers/media/platform/allegro-dvt/nal-h264.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
>> similarity index 100%
>> rename from drivers/media/platform/allegro-dvt/nal-h264.c
>> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
>> diff --git a/drivers/media/platform/allegro-dvt/nal-h264.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
>> similarity index 100%
>> rename from drivers/media/platform/allegro-dvt/nal-h264.h
>> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
>> diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
>> similarity index 100%
>> rename from drivers/media/platform/allegro-dvt/nal-hevc.c
>> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
>> diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
>> similarity index 100%
>> rename from drivers/media/platform/allegro-dvt/nal-hevc.h
>> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
>> diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
>> similarity index 100%
>> rename from drivers/media/platform/allegro-dvt/nal-rbsp.c
>> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
>> diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
>> similarity index 100%
>> rename from drivers/media/platform/allegro-dvt/nal-rbsp.h
>> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
>> diff --git a/drivers/media/platform/allegro-dvt/allegro-core.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
>> similarity index 99%
>> rename from drivers/media/platform/allegro-dvt/allegro-core.c
>> rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
>> index e491399afcc9..8895d7755987 100644
>> --- a/drivers/media/platform/allegro-dvt/allegro-core.c
>> +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
>> @@ -31,7 +31,7 @@
>>  #include <media/videobuf2-dma-contig.h>
>>  #include <media/videobuf2-v4l2.h>
>>
>> -#include "allegro-mail.h"
>> +#include "zynqmp-allegro-mail.h"
>>  #include "nal-h264.h"
>>  #include "nal-hevc.h"
>>
>> diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
>> similarity index 99%
>> rename from drivers/media/platform/allegro-dvt/allegro-mail.c
>> rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
>> index aadc947a77ae..88a98f9e5d00 100644
>> --- a/drivers/media/platform/allegro-dvt/allegro-mail.c
>> +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
>> @@ -12,7 +12,7 @@
>>  #include <linux/string.h>
>>  #include <linux/videodev2.h>
>>
>> -#include "allegro-mail.h"
>> +#include "zynqmp-allegro-mail.h"
>>
>>  const char *msg_type_name(enum mcu_msg_type type)
>>  {
>> diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.h b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h
>> similarity index 100%
>> rename from drivers/media/platform/allegro-dvt/allegro-mail.h
>> rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h
>> --
>> 2.30.2
>>
>>
>
>-- 
>Pengutronix e.K.                           | Michael Tretter             |
>Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
>31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
>Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] media: allegro-dvt: Moving the current driver to subdirectory
  2024-12-04 14:44   ` Yassine Ouaissa
@ 2024-12-04 16:27     ` Michael Tretter
  2024-12-05  8:11       ` Yassine Ouaissa
  0 siblings, 1 reply; 8+ messages in thread
From: Michael Tretter @ 2024-12-04 16:27 UTC (permalink / raw)
  To: Yassine Ouaissa
  Cc: Mauro Carvalho Chehab, Pengutronix Kernel Team, Michal Simek,
	Hans Verkuil, Andrzej Pietrasiewicz, Wolfram Sang,
	Christophe JAILLET, Gaosheng Cui, Uwe Kleine-K??nig,
	Ricardo Ribalda, open list,
	open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
	moderated list:ARM/ZYNQ ARCHITECTURE

Hi Yassine,

On Wed, 04 Dec 2024 14:44:31 +0000, Yassine Ouaissa wrote:
> On 02.12.2024 11:55, Michael Tretter wrote:
> > On Mon, 02 Dec 2024 11:26:38 +0100, Yassine Ouaissa wrote:
> > What kind of conflicts do you encounter or expect? It's kind of
> > surprising that your driver would conflict with anything in the existing
> > driver.
> 
> The current "NOT allegro" driver support only the ZynqMP (ex : ZCU106/ZCU104 ).
> And the upcoming driver, has support for many platforms.

What are the supported platforms of the new driver? Does your driver
support ZynqMP, too?

If there are enough similarities between the encoders, I'd happily
replace parts of the current driver with functionality of the upcoming
driver or reuse the infrastructure of the new driver.

> 
> > I'd like to see how you plan to integrate your driver, what it looks
> > like and what conflicts with the existing driver actually occur. Without
> > that information I don't see the point in moving the driver to a
> > sub-directory.
> 
> The upcoming driver is not using the parsing, conversion inside of the
> driver. Actually the new Gen of ALLEGRO IP does that.

Sorry, I don't understand what you mean by parsing and conversion. Do
you mean the mailbox messages or the NAL units?

Can you point me to some repository with your upcoming driver? I'd
really like to know what's coming up to have an informed discussion how
to structure the directory.

Michael

> > > 
> > > Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com>
> > > ---
> > >  MAINTAINERS                                               | 2 +-
> > >  drivers/media/platform/allegro-dvt/Kconfig                | 4 ++--
> > >  drivers/media/platform/allegro-dvt/Makefile               | 8 ++------
> > >  drivers/media/platform/allegro-dvt/zynqmp/Makefile        | 6 ++++++
> > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c    | 0
> > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h    | 0
> > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c    | 0
> > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h    | 0
> > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c    | 0
> > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h    | 0
> > >  .../{allegro-core.c => zynqmp/zynqmp-allegro-core.c}      | 2 +-
> > >  .../{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c}      | 2 +-
> > >  .../{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h}      | 0
> > >  13 files changed, 13 insertions(+), 11 deletions(-)
> > >  create mode 100644 drivers/media/platform/allegro-dvt/zynqmp/Makefile
> > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c (100%)
> > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h (100%)
> > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c (100%)
> > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h (100%)
> > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c (100%)
> > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h (100%)
> > >  rename drivers/media/platform/allegro-dvt/{allegro-core.c => zynqmp/zynqmp-allegro-core.c} (99%)
> > >  rename drivers/media/platform/allegro-dvt/{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c} (99%)
> > >  rename drivers/media/platform/allegro-dvt/{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h} (100%)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 7292e4a1ddb8..d79efe6f8992 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -795,7 +795,7 @@ R:	Pengutronix Kernel Team <kernel@pengutronix.de>
> > >  L:	linux-media@vger.kernel.org
> > >  S:	Maintained
> > >  F:	Documentation/devicetree/bindings/media/allegro,al5e.yaml
> > > -F:	drivers/media/platform/allegro-dvt/
> > > +F:	drivers/media/platform/allegro-dvt/zynqmp
> > > 
> > >  ALLIED VISION ALVIUM CAMERA DRIVER
> > >  M:	Tommaso Merciai <tomm.merciai@gmail.com>
> > > diff --git a/drivers/media/platform/allegro-dvt/Kconfig b/drivers/media/platform/allegro-dvt/Kconfig
> > > index 2182e1277568..9bc7e99788b8 100644
> > > --- a/drivers/media/platform/allegro-dvt/Kconfig
> > > +++ b/drivers/media/platform/allegro-dvt/Kconfig
> > > @@ -2,8 +2,8 @@
> > > 
> > >  comment "Allegro DVT media platform drivers"
> > > 
> > > -config VIDEO_ALLEGRO_DVT
> > > -	tristate "Allegro DVT Video IP Core"
> > > +config VIDEO_ZYNQMP_ALLEGRO_DVT
> > > +	tristate "Allegro DVT Video IP Core for ZynqMP"
> > >  	depends on V4L_MEM2MEM_DRIVERS
> > >  	depends on VIDEO_DEV
> > >  	depends on ARCH_ZYNQMP || COMPILE_TEST
> > > diff --git a/drivers/media/platform/allegro-dvt/Makefile b/drivers/media/platform/allegro-dvt/Makefile
> > > index 66108a303774..04727c5f7ef4 100644
> > > --- a/drivers/media/platform/allegro-dvt/Makefile
> > > +++ b/drivers/media/platform/allegro-dvt/Makefile
> > > @@ -1,6 +1,2 @@
> > > -# SPDX-License-Identifier: GPL-2.0
> > > -
> > > -allegro-objs := allegro-core.o allegro-mail.o
> > > -allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
> > > -
> > > -obj-$(CONFIG_VIDEO_ALLEGRO_DVT) += allegro.o
> > > +# SPDX-License-Identifier: GPL-2.0-only
> > > +obj-y += zynqmp/
> > > diff --git a/drivers/media/platform/allegro-dvt/zynqmp/Makefile b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
> > > new file mode 100644
> > > index 000000000000..a8ddb9cf93a8
> > > --- /dev/null
> > > +++ b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
> > > @@ -0,0 +1,6 @@
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +
> > > +zynqmp-allegro-objs := zynqmp-allegro-core.o zynqmp-allegro-mail.o
> > > +zynqmp-allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
> > > +
> > > +obj-$(CONFIG_VIDEO_ZYNQMP_ALLEGRO_DVT) += zynqmp-allegro.o
> > > diff --git a/drivers/media/platform/allegro-dvt/nal-h264.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
> > > similarity index 100%
> > > rename from drivers/media/platform/allegro-dvt/nal-h264.c
> > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
> > > diff --git a/drivers/media/platform/allegro-dvt/nal-h264.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
> > > similarity index 100%
> > > rename from drivers/media/platform/allegro-dvt/nal-h264.h
> > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
> > > diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
> > > similarity index 100%
> > > rename from drivers/media/platform/allegro-dvt/nal-hevc.c
> > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
> > > diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
> > > similarity index 100%
> > > rename from drivers/media/platform/allegro-dvt/nal-hevc.h
> > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
> > > diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
> > > similarity index 100%
> > > rename from drivers/media/platform/allegro-dvt/nal-rbsp.c
> > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
> > > diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
> > > similarity index 100%
> > > rename from drivers/media/platform/allegro-dvt/nal-rbsp.h
> > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
> > > diff --git a/drivers/media/platform/allegro-dvt/allegro-core.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
> > > similarity index 99%
> > > rename from drivers/media/platform/allegro-dvt/allegro-core.c
> > > rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
> > > index e491399afcc9..8895d7755987 100644
> > > --- a/drivers/media/platform/allegro-dvt/allegro-core.c
> > > +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
> > > @@ -31,7 +31,7 @@
> > >  #include <media/videobuf2-dma-contig.h>
> > >  #include <media/videobuf2-v4l2.h>
> > > 
> > > -#include "allegro-mail.h"
> > > +#include "zynqmp-allegro-mail.h"
> > >  #include "nal-h264.h"
> > >  #include "nal-hevc.h"
> > > 
> > > diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
> > > similarity index 99%
> > > rename from drivers/media/platform/allegro-dvt/allegro-mail.c
> > > rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
> > > index aadc947a77ae..88a98f9e5d00 100644
> > > --- a/drivers/media/platform/allegro-dvt/allegro-mail.c
> > > +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
> > > @@ -12,7 +12,7 @@
> > >  #include <linux/string.h>
> > >  #include <linux/videodev2.h>
> > > 
> > > -#include "allegro-mail.h"
> > > +#include "zynqmp-allegro-mail.h"
> > > 
> > >  const char *msg_type_name(enum mcu_msg_type type)
> > >  {
> > > diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.h b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h
> > > similarity index 100%
> > > rename from drivers/media/platform/allegro-dvt/allegro-mail.h
> > > rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h
> > > --
> > > 2.30.2
> > > 
> > > 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] media: allegro-dvt: Moving the current driver to subdirectory
  2024-12-04 16:27     ` Michael Tretter
@ 2024-12-05  8:11       ` Yassine Ouaissa
  2024-12-05  8:58         ` Michael Tretter
  0 siblings, 1 reply; 8+ messages in thread
From: Yassine Ouaissa @ 2024-12-05  8:11 UTC (permalink / raw)
  To: Michael Tretter
  Cc: Mauro Carvalho Chehab, Pengutronix Kernel Team, Michal Simek,
	Hans Verkuil, Andrzej Pietrasiewicz, Wolfram Sang,
	Christophe JAILLET, Gaosheng Cui, Uwe Kleine-K??nig,
	Ricardo Ribalda, open list,
	open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
	moderated list:ARM/ZYNQ ARCHITECTURE

Hi Michael, 

On 04.12.2024 17:27, Michael Tretter wrote:
>Hi Yassine,
>
>On Wed, 04 Dec 2024 14:44:31 +0000, Yassine Ouaissa wrote:
>> On 02.12.2024 11:55, Michael Tretter wrote:
>> > On Mon, 02 Dec 2024 11:26:38 +0100, Yassine Ouaissa wrote:
>> > What kind of conflicts do you encounter or expect? It's kind of
>> > surprising that your driver would conflict with anything in the existing
>> > driver.
>>
>> The current "NOT allegro" driver support only the ZynqMP (ex : ZCU106/ZCU104 ).
>> And the upcoming driver, has support for many platforms.
>
>What are the supported platforms of the new driver? Does your driver
>support ZynqMP, too?
>
The upcoming driver is not using the ZynqMP, it can be used by other
clients including Xilinx. 
>If there are enough similarities between the encoders, I'd happily
>replace parts of the current driver with functionality of the upcoming
>driver or reuse the infrastructure of the new driver.
>

For now, we do have only the decoder (stateful). the encoder is "in
progress". 
We prefer to have a separate driver core for each platform. 
>>
>> > I'd like to see how you plan to integrate your driver, what it looks
>> > like and what conflicts with the existing driver actually occur. Without
>> > that information I don't see the point in moving the driver to a
>> > sub-directory.
>>
>> The upcoming driver is not using the parsing, conversion inside of the
>> driver. Actually the new Gen of ALLEGRO IP does that.
>
>Sorry, I don't understand what you mean by parsing and conversion. Do
>you mean the mailbox messages or the NAL units?
>
>Can you point me to some repository with your upcoming driver? I'd
>really like to know what's coming up to have an informed discussion how
>to structure the directory.
>
>Michael
>

Yassine
>> > >
>> > > Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com>
>> > > ---
>> > >  MAINTAINERS                                               | 2 +-
>> > >  drivers/media/platform/allegro-dvt/Kconfig                | 4 ++--
>> > >  drivers/media/platform/allegro-dvt/Makefile               | 8 ++------
>> > >  drivers/media/platform/allegro-dvt/zynqmp/Makefile        | 6 ++++++
>> > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c    | 0
>> > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h    | 0
>> > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c    | 0
>> > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h    | 0
>> > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c    | 0
>> > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h    | 0
>> > >  .../{allegro-core.c => zynqmp/zynqmp-allegro-core.c}      | 2 +-
>> > >  .../{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c}      | 2 +-
>> > >  .../{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h}      | 0
>> > >  13 files changed, 13 insertions(+), 11 deletions(-)
>> > >  create mode 100644 drivers/media/platform/allegro-dvt/zynqmp/Makefile
>> > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c (100%)
>> > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h (100%)
>> > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c (100%)
>> > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h (100%)
>> > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c (100%)
>> > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h (100%)
>> > >  rename drivers/media/platform/allegro-dvt/{allegro-core.c => zynqmp/zynqmp-allegro-core.c} (99%)
>> > >  rename drivers/media/platform/allegro-dvt/{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c} (99%)
>> > >  rename drivers/media/platform/allegro-dvt/{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h} (100%)
>> > >
>> > > diff --git a/MAINTAINERS b/MAINTAINERS
>> > > index 7292e4a1ddb8..d79efe6f8992 100644
>> > > --- a/MAINTAINERS
>> > > +++ b/MAINTAINERS
>> > > @@ -795,7 +795,7 @@ R:	Pengutronix Kernel Team <kernel@pengutronix.de>
>> > >  L:	linux-media@vger.kernel.org
>> > >  S:	Maintained
>> > >  F:	Documentation/devicetree/bindings/media/allegro,al5e.yaml
>> > > -F:	drivers/media/platform/allegro-dvt/
>> > > +F:	drivers/media/platform/allegro-dvt/zynqmp
>> > >
>> > >  ALLIED VISION ALVIUM CAMERA DRIVER
>> > >  M:	Tommaso Merciai <tomm.merciai@gmail.com>
>> > > diff --git a/drivers/media/platform/allegro-dvt/Kconfig b/drivers/media/platform/allegro-dvt/Kconfig
>> > > index 2182e1277568..9bc7e99788b8 100644
>> > > --- a/drivers/media/platform/allegro-dvt/Kconfig
>> > > +++ b/drivers/media/platform/allegro-dvt/Kconfig
>> > > @@ -2,8 +2,8 @@
>> > >
>> > >  comment "Allegro DVT media platform drivers"
>> > >
>> > > -config VIDEO_ALLEGRO_DVT
>> > > -	tristate "Allegro DVT Video IP Core"
>> > > +config VIDEO_ZYNQMP_ALLEGRO_DVT
>> > > +	tristate "Allegro DVT Video IP Core for ZynqMP"
>> > >  	depends on V4L_MEM2MEM_DRIVERS
>> > >  	depends on VIDEO_DEV
>> > >  	depends on ARCH_ZYNQMP || COMPILE_TEST
>> > > diff --git a/drivers/media/platform/allegro-dvt/Makefile b/drivers/media/platform/allegro-dvt/Makefile
>> > > index 66108a303774..04727c5f7ef4 100644
>> > > --- a/drivers/media/platform/allegro-dvt/Makefile
>> > > +++ b/drivers/media/platform/allegro-dvt/Makefile
>> > > @@ -1,6 +1,2 @@
>> > > -# SPDX-License-Identifier: GPL-2.0
>> > > -
>> > > -allegro-objs := allegro-core.o allegro-mail.o
>> > > -allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
>> > > -
>> > > -obj-$(CONFIG_VIDEO_ALLEGRO_DVT) += allegro.o
>> > > +# SPDX-License-Identifier: GPL-2.0-only
>> > > +obj-y += zynqmp/
>> > > diff --git a/drivers/media/platform/allegro-dvt/zynqmp/Makefile b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
>> > > new file mode 100644
>> > > index 000000000000..a8ddb9cf93a8
>> > > --- /dev/null
>> > > +++ b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
>> > > @@ -0,0 +1,6 @@
>> > > +# SPDX-License-Identifier: GPL-2.0
>> > > +
>> > > +zynqmp-allegro-objs := zynqmp-allegro-core.o zynqmp-allegro-mail.o
>> > > +zynqmp-allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
>> > > +
>> > > +obj-$(CONFIG_VIDEO_ZYNQMP_ALLEGRO_DVT) += zynqmp-allegro.o
>> > > diff --git a/drivers/media/platform/allegro-dvt/nal-h264.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
>> > > similarity index 100%
>> > > rename from drivers/media/platform/allegro-dvt/nal-h264.c
>> > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
>> > > diff --git a/drivers/media/platform/allegro-dvt/nal-h264.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
>> > > similarity index 100%
>> > > rename from drivers/media/platform/allegro-dvt/nal-h264.h
>> > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
>> > > diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
>> > > similarity index 100%
>> > > rename from drivers/media/platform/allegro-dvt/nal-hevc.c
>> > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
>> > > diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
>> > > similarity index 100%
>> > > rename from drivers/media/platform/allegro-dvt/nal-hevc.h
>> > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
>> > > diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
>> > > similarity index 100%
>> > > rename from drivers/media/platform/allegro-dvt/nal-rbsp.c
>> > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
>> > > diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
>> > > similarity index 100%
>> > > rename from drivers/media/platform/allegro-dvt/nal-rbsp.h
>> > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
>> > > diff --git a/drivers/media/platform/allegro-dvt/allegro-core.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
>> > > similarity index 99%
>> > > rename from drivers/media/platform/allegro-dvt/allegro-core.c
>> > > rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
>> > > index e491399afcc9..8895d7755987 100644
>> > > --- a/drivers/media/platform/allegro-dvt/allegro-core.c
>> > > +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
>> > > @@ -31,7 +31,7 @@
>> > >  #include <media/videobuf2-dma-contig.h>
>> > >  #include <media/videobuf2-v4l2.h>
>> > >
>> > > -#include "allegro-mail.h"
>> > > +#include "zynqmp-allegro-mail.h"
>> > >  #include "nal-h264.h"
>> > >  #include "nal-hevc.h"
>> > >
>> > > diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
>> > > similarity index 99%
>> > > rename from drivers/media/platform/allegro-dvt/allegro-mail.c
>> > > rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
>> > > index aadc947a77ae..88a98f9e5d00 100644
>> > > --- a/drivers/media/platform/allegro-dvt/allegro-mail.c
>> > > +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
>> > > @@ -12,7 +12,7 @@
>> > >  #include <linux/string.h>
>> > >  #include <linux/videodev2.h>
>> > >
>> > > -#include "allegro-mail.h"
>> > > +#include "zynqmp-allegro-mail.h"
>> > >
>> > >  const char *msg_type_name(enum mcu_msg_type type)
>> > >  {
>> > > diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.h b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h
>> > > similarity index 100%
>> > > rename from drivers/media/platform/allegro-dvt/allegro-mail.h
>> > > rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h
>> > > --
>> > > 2.30.2
>> > >
>> > >

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] media: allegro-dvt: Moving the current driver to subdirectory
  2024-12-05  8:11       ` Yassine Ouaissa
@ 2024-12-05  8:58         ` Michael Tretter
  2024-12-05 18:26           ` Nicolas Dufresne
  0 siblings, 1 reply; 8+ messages in thread
From: Michael Tretter @ 2024-12-05  8:58 UTC (permalink / raw)
  To: Yassine Ouaissa
  Cc: Mauro Carvalho Chehab, Pengutronix Kernel Team, Michal Simek,
	Hans Verkuil, Andrzej Pietrasiewicz, Wolfram Sang,
	Christophe JAILLET, Gaosheng Cui, Uwe Kleine-K??nig,
	Ricardo Ribalda, open list,
	open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
	moderated list:ARM/ZYNQ ARCHITECTURE

Hi Yassine,

On Thu, 05 Dec 2024 08:11:48 +0000, Yassine Ouaissa wrote:
> On 04.12.2024 17:27, Michael Tretter wrote:
> > On Wed, 04 Dec 2024 14:44:31 +0000, Yassine Ouaissa wrote:
> > > On 02.12.2024 11:55, Michael Tretter wrote:
> > > > On Mon, 02 Dec 2024 11:26:38 +0100, Yassine Ouaissa wrote:
> > > > What kind of conflicts do you encounter or expect? It's kind of
> > > > surprising that your driver would conflict with anything in the existing
> > > > driver.
> > > 
> > > The current "NOT allegro" driver support only the ZynqMP (ex : ZCU106/ZCU104 ).
> > > And the upcoming driver, has support for many platforms.
> > 
> > What are the supported platforms of the new driver? Does your driver
> > support ZynqMP, too?
> > 
> The upcoming driver is not using the ZynqMP, it can be used by other
> clients including Xilinx.
> > If there are enough similarities between the encoders, I'd happily
> > replace parts of the current driver with functionality of the upcoming
> > driver or reuse the infrastructure of the new driver.
> > 
> 
> For now, we do have only the decoder (stateful). the encoder is "in
> progress". We prefer to have a separate driver core for each platform.

Thanks! I'd like to wait until I've seen your patches before agreeing to
move the driver to a subdirectory. Maybe even include this patch as the
first patch in your series to give a full picture of the new structure.

Michael

> > > 
> > > > I'd like to see how you plan to integrate your driver, what it looks
> > > > like and what conflicts with the existing driver actually occur. Without
> > > > that information I don't see the point in moving the driver to a
> > > > sub-directory.
> > > 
> > > The upcoming driver is not using the parsing, conversion inside of the
> > > driver. Actually the new Gen of ALLEGRO IP does that.
> > 
> > Sorry, I don't understand what you mean by parsing and conversion. Do
> > you mean the mailbox messages or the NAL units?
> > 
> > Can you point me to some repository with your upcoming driver? I'd
> > really like to know what's coming up to have an informed discussion how
> > to structure the directory.
> > 
> > Michael
> > 
> 
> Yassine
> > > > >
> > > > > Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com>
> > > > > ---
> > > > >  MAINTAINERS                                               | 2 +-
> > > > >  drivers/media/platform/allegro-dvt/Kconfig                | 4 ++--
> > > > >  drivers/media/platform/allegro-dvt/Makefile               | 8 ++------
> > > > >  drivers/media/platform/allegro-dvt/zynqmp/Makefile        | 6 ++++++
> > > > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c    | 0
> > > > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h    | 0
> > > > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c    | 0
> > > > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h    | 0
> > > > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c    | 0
> > > > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h    | 0
> > > > >  .../{allegro-core.c => zynqmp/zynqmp-allegro-core.c}      | 2 +-
> > > > >  .../{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c}      | 2 +-
> > > > >  .../{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h}      | 0
> > > > >  13 files changed, 13 insertions(+), 11 deletions(-)
> > > > >  create mode 100644 drivers/media/platform/allegro-dvt/zynqmp/Makefile
> > > > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c (100%)
> > > > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h (100%)
> > > > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c (100%)
> > > > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h (100%)
> > > > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c (100%)
> > > > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h (100%)
> > > > >  rename drivers/media/platform/allegro-dvt/{allegro-core.c => zynqmp/zynqmp-allegro-core.c} (99%)
> > > > >  rename drivers/media/platform/allegro-dvt/{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c} (99%)
> > > > >  rename drivers/media/platform/allegro-dvt/{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h} (100%)
> > > > >
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > index 7292e4a1ddb8..d79efe6f8992 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -795,7 +795,7 @@ R:	Pengutronix Kernel Team <kernel@pengutronix.de>
> > > > >  L:	linux-media@vger.kernel.org
> > > > >  S:	Maintained
> > > > >  F:	Documentation/devicetree/bindings/media/allegro,al5e.yaml
> > > > > -F:	drivers/media/platform/allegro-dvt/
> > > > > +F:	drivers/media/platform/allegro-dvt/zynqmp
> > > > >
> > > > >  ALLIED VISION ALVIUM CAMERA DRIVER
> > > > >  M:	Tommaso Merciai <tomm.merciai@gmail.com>
> > > > > diff --git a/drivers/media/platform/allegro-dvt/Kconfig b/drivers/media/platform/allegro-dvt/Kconfig
> > > > > index 2182e1277568..9bc7e99788b8 100644
> > > > > --- a/drivers/media/platform/allegro-dvt/Kconfig
> > > > > +++ b/drivers/media/platform/allegro-dvt/Kconfig
> > > > > @@ -2,8 +2,8 @@
> > > > >
> > > > >  comment "Allegro DVT media platform drivers"
> > > > >
> > > > > -config VIDEO_ALLEGRO_DVT
> > > > > -	tristate "Allegro DVT Video IP Core"
> > > > > +config VIDEO_ZYNQMP_ALLEGRO_DVT
> > > > > +	tristate "Allegro DVT Video IP Core for ZynqMP"
> > > > >  	depends on V4L_MEM2MEM_DRIVERS
> > > > >  	depends on VIDEO_DEV
> > > > >  	depends on ARCH_ZYNQMP || COMPILE_TEST
> > > > > diff --git a/drivers/media/platform/allegro-dvt/Makefile b/drivers/media/platform/allegro-dvt/Makefile
> > > > > index 66108a303774..04727c5f7ef4 100644
> > > > > --- a/drivers/media/platform/allegro-dvt/Makefile
> > > > > +++ b/drivers/media/platform/allegro-dvt/Makefile
> > > > > @@ -1,6 +1,2 @@
> > > > > -# SPDX-License-Identifier: GPL-2.0
> > > > > -
> > > > > -allegro-objs := allegro-core.o allegro-mail.o
> > > > > -allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
> > > > > -
> > > > > -obj-$(CONFIG_VIDEO_ALLEGRO_DVT) += allegro.o
> > > > > +# SPDX-License-Identifier: GPL-2.0-only
> > > > > +obj-y += zynqmp/
> > > > > diff --git a/drivers/media/platform/allegro-dvt/zynqmp/Makefile b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
> > > > > new file mode 100644
> > > > > index 000000000000..a8ddb9cf93a8
> > > > > --- /dev/null
> > > > > +++ b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
> > > > > @@ -0,0 +1,6 @@
> > > > > +# SPDX-License-Identifier: GPL-2.0
> > > > > +
> > > > > +zynqmp-allegro-objs := zynqmp-allegro-core.o zynqmp-allegro-mail.o
> > > > > +zynqmp-allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
> > > > > +
> > > > > +obj-$(CONFIG_VIDEO_ZYNQMP_ALLEGRO_DVT) += zynqmp-allegro.o
> > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-h264.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
> > > > > similarity index 100%
> > > > > rename from drivers/media/platform/allegro-dvt/nal-h264.c
> > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
> > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-h264.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
> > > > > similarity index 100%
> > > > > rename from drivers/media/platform/allegro-dvt/nal-h264.h
> > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
> > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
> > > > > similarity index 100%
> > > > > rename from drivers/media/platform/allegro-dvt/nal-hevc.c
> > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
> > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
> > > > > similarity index 100%
> > > > > rename from drivers/media/platform/allegro-dvt/nal-hevc.h
> > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
> > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
> > > > > similarity index 100%
> > > > > rename from drivers/media/platform/allegro-dvt/nal-rbsp.c
> > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
> > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
> > > > > similarity index 100%
> > > > > rename from drivers/media/platform/allegro-dvt/nal-rbsp.h
> > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
> > > > > diff --git a/drivers/media/platform/allegro-dvt/allegro-core.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
> > > > > similarity index 99%
> > > > > rename from drivers/media/platform/allegro-dvt/allegro-core.c
> > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
> > > > > index e491399afcc9..8895d7755987 100644
> > > > > --- a/drivers/media/platform/allegro-dvt/allegro-core.c
> > > > > +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
> > > > > @@ -31,7 +31,7 @@
> > > > >  #include <media/videobuf2-dma-contig.h>
> > > > >  #include <media/videobuf2-v4l2.h>
> > > > >
> > > > > -#include "allegro-mail.h"
> > > > > +#include "zynqmp-allegro-mail.h"
> > > > >  #include "nal-h264.h"
> > > > >  #include "nal-hevc.h"
> > > > >
> > > > > diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
> > > > > similarity index 99%
> > > > > rename from drivers/media/platform/allegro-dvt/allegro-mail.c
> > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
> > > > > index aadc947a77ae..88a98f9e5d00 100644
> > > > > --- a/drivers/media/platform/allegro-dvt/allegro-mail.c
> > > > > +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
> > > > > @@ -12,7 +12,7 @@
> > > > >  #include <linux/string.h>
> > > > >  #include <linux/videodev2.h>
> > > > >
> > > > > -#include "allegro-mail.h"
> > > > > +#include "zynqmp-allegro-mail.h"
> > > > >
> > > > >  const char *msg_type_name(enum mcu_msg_type type)
> > > > >  {
> > > > > diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.h b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h
> > > > > similarity index 100%
> > > > > rename from drivers/media/platform/allegro-dvt/allegro-mail.h
> > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h
> > > > > --
> > > > > 2.30.2
> > > > >
> > > > >

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] media: allegro-dvt: Moving the current driver to subdirectory
  2024-12-05  8:58         ` Michael Tretter
@ 2024-12-05 18:26           ` Nicolas Dufresne
  0 siblings, 0 replies; 8+ messages in thread
From: Nicolas Dufresne @ 2024-12-05 18:26 UTC (permalink / raw)
  To: Michael Tretter, Yassine Ouaissa, Mauro Carvalho Chehab,
	Pengutronix Kernel Team, Michal Simek, Hans Verkuil,
	Andrzej Pietrasiewicz, Wolfram Sang, Christophe JAILLET,
	Gaosheng Cui, Uwe Kleine-K??nig, Ricardo Ribalda, open list,
	open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
	moderated list:ARM/ZYNQ ARCHITECTURE

Hi Yassine,

Le jeudi 05 décembre 2024 à 09:58 +0100, Michael Tretter a écrit :
> Hi Yassine,
> 
> On Thu, 05 Dec 2024 08:11:48 +0000, Yassine Ouaissa wrote:
> > On 04.12.2024 17:27, Michael Tretter wrote:
> > > On Wed, 04 Dec 2024 14:44:31 +0000, Yassine Ouaissa wrote:
> > > > On 02.12.2024 11:55, Michael Tretter wrote:
> > > > > On Mon, 02 Dec 2024 11:26:38 +0100, Yassine Ouaissa wrote:
> > > > > What kind of conflicts do you encounter or expect? It's kind of
> > > > > surprising that your driver would conflict with anything in the existing
> > > > > driver.
> > > > 
> > > > The current "NOT allegro" driver support only the ZynqMP (ex : ZCU106/ZCU104 ).
> > > > And the upcoming driver, has support for many platforms.
> > > 
> > > What are the supported platforms of the new driver? Does your driver
> > > support ZynqMP, too?
> > > 
> > The upcoming driver is not using the ZynqMP, it can be used by other
> > clients including Xilinx.
> > > If there are enough similarities between the encoders, I'd happily
> > > replace parts of the current driver with functionality of the upcoming
> > > driver or reuse the infrastructure of the new driver.
> > > 
> > 
> > For now, we do have only the decoder (stateful). the encoder is "in
> > progress". We prefer to have a separate driver core for each platform.
> 
> Thanks! I'd like to wait until I've seen your patches before agreeing to
> move the driver to a subdirectory. Maybe even include this patch as the
> first patch in your series to give a full picture of the new structure.

I wonder if both you have the same definition of "platform". For me it sounded
like "a driver per SoC" and that is a big no no.

For stateful codec, what differentiate them is the interface with the firmware
and state machine used to driver them. If these are incompatible with the
generation of design on ZynqMP 104/106, then splitting the driver is the way to
go, even if the new interface could endup on older SoC through a firmware
update.

This is pretty much the direction taken by Qualcomm while moving from Venus
interface to Iris interface, and on some SoC (platform), this is just a firmware
swap and different compatible in the DT.

Nicolas

p.s. Yassine, its fine to state that your driver will be "pre-sillicon" tested,
that helps remove the confusion. Looking forward seeing some code of course,
that will also help, from there, Michael will better judge if there is an
overlap or not. Mid-ground solution exist, like creating allegro-common.ko.

> 
> Michael
> 
> > > > 
> > > > > I'd like to see how you plan to integrate your driver, what it looks
> > > > > like and what conflicts with the existing driver actually occur. Without
> > > > > that information I don't see the point in moving the driver to a
> > > > > sub-directory.
> > > > 
> > > > The upcoming driver is not using the parsing, conversion inside of the
> > > > driver. Actually the new Gen of ALLEGRO IP does that.
> > > 
> > > Sorry, I don't understand what you mean by parsing and conversion. Do
> > > you mean the mailbox messages or the NAL units?
> > > 
> > > Can you point me to some repository with your upcoming driver? I'd
> > > really like to know what's coming up to have an informed discussion how
> > > to structure the directory.
> > > 
> > > Michael
> > > 
> > 
> > Yassine
> > > > > > 
> > > > > > Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com>
> > > > > > ---
> > > > > >  MAINTAINERS                                               | 2 +-
> > > > > >  drivers/media/platform/allegro-dvt/Kconfig                | 4 ++--
> > > > > >  drivers/media/platform/allegro-dvt/Makefile               | 8 ++------
> > > > > >  drivers/media/platform/allegro-dvt/zynqmp/Makefile        | 6 ++++++
> > > > > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c    | 0
> > > > > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h    | 0
> > > > > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c    | 0
> > > > > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h    | 0
> > > > > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c    | 0
> > > > > >  .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h    | 0
> > > > > >  .../{allegro-core.c => zynqmp/zynqmp-allegro-core.c}      | 2 +-
> > > > > >  .../{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c}      | 2 +-
> > > > > >  .../{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h}      | 0
> > > > > >  13 files changed, 13 insertions(+), 11 deletions(-)
> > > > > >  create mode 100644 drivers/media/platform/allegro-dvt/zynqmp/Makefile
> > > > > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c (100%)
> > > > > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h (100%)
> > > > > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c (100%)
> > > > > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h (100%)
> > > > > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c (100%)
> > > > > >  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h (100%)
> > > > > >  rename drivers/media/platform/allegro-dvt/{allegro-core.c => zynqmp/zynqmp-allegro-core.c} (99%)
> > > > > >  rename drivers/media/platform/allegro-dvt/{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c} (99%)
> > > > > >  rename drivers/media/platform/allegro-dvt/{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h} (100%)
> > > > > > 
> > > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > > index 7292e4a1ddb8..d79efe6f8992 100644
> > > > > > --- a/MAINTAINERS
> > > > > > +++ b/MAINTAINERS
> > > > > > @@ -795,7 +795,7 @@ R:	Pengutronix Kernel Team <kernel@pengutronix.de>
> > > > > >  L:	linux-media@vger.kernel.org
> > > > > >  S:	Maintained
> > > > > >  F:	Documentation/devicetree/bindings/media/allegro,al5e.yaml
> > > > > > -F:	drivers/media/platform/allegro-dvt/
> > > > > > +F:	drivers/media/platform/allegro-dvt/zynqmp
> > > > > > 
> > > > > >  ALLIED VISION ALVIUM CAMERA DRIVER
> > > > > >  M:	Tommaso Merciai <tomm.merciai@gmail.com>
> > > > > > diff --git a/drivers/media/platform/allegro-dvt/Kconfig b/drivers/media/platform/allegro-dvt/Kconfig
> > > > > > index 2182e1277568..9bc7e99788b8 100644
> > > > > > --- a/drivers/media/platform/allegro-dvt/Kconfig
> > > > > > +++ b/drivers/media/platform/allegro-dvt/Kconfig
> > > > > > @@ -2,8 +2,8 @@
> > > > > > 
> > > > > >  comment "Allegro DVT media platform drivers"
> > > > > > 
> > > > > > -config VIDEO_ALLEGRO_DVT
> > > > > > -	tristate "Allegro DVT Video IP Core"
> > > > > > +config VIDEO_ZYNQMP_ALLEGRO_DVT
> > > > > > +	tristate "Allegro DVT Video IP Core for ZynqMP"
> > > > > >  	depends on V4L_MEM2MEM_DRIVERS
> > > > > >  	depends on VIDEO_DEV
> > > > > >  	depends on ARCH_ZYNQMP || COMPILE_TEST
> > > > > > diff --git a/drivers/media/platform/allegro-dvt/Makefile b/drivers/media/platform/allegro-dvt/Makefile
> > > > > > index 66108a303774..04727c5f7ef4 100644
> > > > > > --- a/drivers/media/platform/allegro-dvt/Makefile
> > > > > > +++ b/drivers/media/platform/allegro-dvt/Makefile
> > > > > > @@ -1,6 +1,2 @@
> > > > > > -# SPDX-License-Identifier: GPL-2.0
> > > > > > -
> > > > > > -allegro-objs := allegro-core.o allegro-mail.o
> > > > > > -allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
> > > > > > -
> > > > > > -obj-$(CONFIG_VIDEO_ALLEGRO_DVT) += allegro.o
> > > > > > +# SPDX-License-Identifier: GPL-2.0-only
> > > > > > +obj-y += zynqmp/
> > > > > > diff --git a/drivers/media/platform/allegro-dvt/zynqmp/Makefile b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
> > > > > > new file mode 100644
> > > > > > index 000000000000..a8ddb9cf93a8
> > > > > > --- /dev/null
> > > > > > +++ b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
> > > > > > @@ -0,0 +1,6 @@
> > > > > > +# SPDX-License-Identifier: GPL-2.0
> > > > > > +
> > > > > > +zynqmp-allegro-objs := zynqmp-allegro-core.o zynqmp-allegro-mail.o
> > > > > > +zynqmp-allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
> > > > > > +
> > > > > > +obj-$(CONFIG_VIDEO_ZYNQMP_ALLEGRO_DVT) += zynqmp-allegro.o
> > > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-h264.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
> > > > > > similarity index 100%
> > > > > > rename from drivers/media/platform/allegro-dvt/nal-h264.c
> > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
> > > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-h264.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
> > > > > > similarity index 100%
> > > > > > rename from drivers/media/platform/allegro-dvt/nal-h264.h
> > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
> > > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
> > > > > > similarity index 100%
> > > > > > rename from drivers/media/platform/allegro-dvt/nal-hevc.c
> > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
> > > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
> > > > > > similarity index 100%
> > > > > > rename from drivers/media/platform/allegro-dvt/nal-hevc.h
> > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
> > > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
> > > > > > similarity index 100%
> > > > > > rename from drivers/media/platform/allegro-dvt/nal-rbsp.c
> > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
> > > > > > diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
> > > > > > similarity index 100%
> > > > > > rename from drivers/media/platform/allegro-dvt/nal-rbsp.h
> > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
> > > > > > diff --git a/drivers/media/platform/allegro-dvt/allegro-core.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
> > > > > > similarity index 99%
> > > > > > rename from drivers/media/platform/allegro-dvt/allegro-core.c
> > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
> > > > > > index e491399afcc9..8895d7755987 100644
> > > > > > --- a/drivers/media/platform/allegro-dvt/allegro-core.c
> > > > > > +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
> > > > > > @@ -31,7 +31,7 @@
> > > > > >  #include <media/videobuf2-dma-contig.h>
> > > > > >  #include <media/videobuf2-v4l2.h>
> > > > > > 
> > > > > > -#include "allegro-mail.h"
> > > > > > +#include "zynqmp-allegro-mail.h"
> > > > > >  #include "nal-h264.h"
> > > > > >  #include "nal-hevc.h"
> > > > > > 
> > > > > > diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
> > > > > > similarity index 99%
> > > > > > rename from drivers/media/platform/allegro-dvt/allegro-mail.c
> > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
> > > > > > index aadc947a77ae..88a98f9e5d00 100644
> > > > > > --- a/drivers/media/platform/allegro-dvt/allegro-mail.c
> > > > > > +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
> > > > > > @@ -12,7 +12,7 @@
> > > > > >  #include <linux/string.h>
> > > > > >  #include <linux/videodev2.h>
> > > > > > 
> > > > > > -#include "allegro-mail.h"
> > > > > > +#include "zynqmp-allegro-mail.h"
> > > > > > 
> > > > > >  const char *msg_type_name(enum mcu_msg_type type)
> > > > > >  {
> > > > > > diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.h b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h
> > > > > > similarity index 100%
> > > > > > rename from drivers/media/platform/allegro-dvt/allegro-mail.h
> > > > > > rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h
> > > > > > --
> > > > > > 2.30.2
> > > > > > 
> > > > > > 
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] media: allegro-dvt: Moving the current driver to subdirectory
  2024-12-02 10:26 [PATCH] media: allegro-dvt: Moving the current driver to subdirectory Yassine Ouaissa
  2024-12-02 10:55 ` Michael Tretter
@ 2025-02-06 20:00 ` Nicolas Dufresne
  1 sibling, 0 replies; 8+ messages in thread
From: Nicolas Dufresne @ 2025-02-06 20:00 UTC (permalink / raw)
  To: Yassine Ouaissa
  Cc: Mauro Carvalho Chehab, Michael Tretter, Pengutronix Kernel Team,
	Michal Simek, Hans Verkuil, Andrzej Pietrasiewicz, Wolfram Sang,
	Christophe JAILLET, Gaosheng Cui, Uwe Kleine-König,
	Ricardo Ribalda, open list,
	open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
	moderated list:ARM/ZYNQ ARCHITECTURE

Hi Yassine,

sorry for the long delay, note that this set could not have been accepted, the
move should be submitted with the new driver.


Le lundi 02 décembre 2024 à 11:26 +0100, Yassine Ouaissa a écrit :
> In preparation for the upcoming driver update, we need to realocate the
> current driver that is not maintained by us ( allegro-dvt ).
> This will help ensure a clean transition and avoid any potential
> conflicts with the new driver.
> 
> This patch is crucial for keeping our directory organized and
> facilitating a smooth integration of the new driver
> 
> Signed-off-by: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com>
> ---
>  MAINTAINERS                                               | 2 +-
>  drivers/media/platform/allegro-dvt/Kconfig                | 4 ++--
>  drivers/media/platform/allegro-dvt/Makefile               | 8 ++------
>  drivers/media/platform/allegro-dvt/zynqmp/Makefile        | 6 ++++++
>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c    | 0
>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h    | 0
>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c    | 0
>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h    | 0
>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c    | 0
>  .../media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h    | 0
>  .../{allegro-core.c => zynqmp/zynqmp-allegro-core.c}      | 2 +-
>  .../{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c}      | 2 +-
>  .../{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h}      | 0
>  13 files changed, 13 insertions(+), 11 deletions(-)
>  create mode 100644 drivers/media/platform/allegro-dvt/zynqmp/Makefile
>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.c (100%)
>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-h264.h (100%)
>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.c (100%)
>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-hevc.h (100%)
>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.c (100%)
>  rename drivers/media/platform/allegro-dvt/{ => zynqmp}/nal-rbsp.h (100%)
>  rename drivers/media/platform/allegro-dvt/{allegro-core.c => zynqmp/zynqmp-allegro-core.c} (99%)
>  rename drivers/media/platform/allegro-dvt/{allegro-mail.c => zynqmp/zynqmp-allegro-mail.c} (99%)
>  rename drivers/media/platform/allegro-dvt/{allegro-mail.h => zynqmp/zynqmp-allegro-mail.h} (100%)

There is no reason to rename these 3 files, moving them in a subdirectory should
be enough. As I understood, there is no plan to share anything between the new
and the old driver.

regards,
Nicolas

> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7292e4a1ddb8..d79efe6f8992 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -795,7 +795,7 @@ R:	Pengutronix Kernel Team <kernel@pengutronix.de>
>  L:	linux-media@vger.kernel.org
>  S:	Maintained
>  F:	Documentation/devicetree/bindings/media/allegro,al5e.yaml
> -F:	drivers/media/platform/allegro-dvt/
> +F:	drivers/media/platform/allegro-dvt/zynqmp
>  
>  ALLIED VISION ALVIUM CAMERA DRIVER
>  M:	Tommaso Merciai <tomm.merciai@gmail.com>
> diff --git a/drivers/media/platform/allegro-dvt/Kconfig b/drivers/media/platform/allegro-dvt/Kconfig
> index 2182e1277568..9bc7e99788b8 100644
> --- a/drivers/media/platform/allegro-dvt/Kconfig
> +++ b/drivers/media/platform/allegro-dvt/Kconfig
> @@ -2,8 +2,8 @@
>  
>  comment "Allegro DVT media platform drivers"
>  
> -config VIDEO_ALLEGRO_DVT
> -	tristate "Allegro DVT Video IP Core"
> +config VIDEO_ZYNQMP_ALLEGRO_DVT
> +	tristate "Allegro DVT Video IP Core for ZynqMP"
>  	depends on V4L_MEM2MEM_DRIVERS
>  	depends on VIDEO_DEV
>  	depends on ARCH_ZYNQMP || COMPILE_TEST
> diff --git a/drivers/media/platform/allegro-dvt/Makefile b/drivers/media/platform/allegro-dvt/Makefile
> index 66108a303774..04727c5f7ef4 100644
> --- a/drivers/media/platform/allegro-dvt/Makefile
> +++ b/drivers/media/platform/allegro-dvt/Makefile
> @@ -1,6 +1,2 @@
> -# SPDX-License-Identifier: GPL-2.0
> -
> -allegro-objs := allegro-core.o allegro-mail.o
> -allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
> -
> -obj-$(CONFIG_VIDEO_ALLEGRO_DVT) += allegro.o
> +# SPDX-License-Identifier: GPL-2.0-only
> +obj-y += zynqmp/
> diff --git a/drivers/media/platform/allegro-dvt/zynqmp/Makefile b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
> new file mode 100644
> index 000000000000..a8ddb9cf93a8
> --- /dev/null
> +++ b/drivers/media/platform/allegro-dvt/zynqmp/Makefile
> @@ -0,0 +1,6 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +zynqmp-allegro-objs := zynqmp-allegro-core.o zynqmp-allegro-mail.o
> +zynqmp-allegro-objs += nal-rbsp.o nal-h264.o nal-hevc.o
> +
> +obj-$(CONFIG_VIDEO_ZYNQMP_ALLEGRO_DVT) += zynqmp-allegro.o
> diff --git a/drivers/media/platform/allegro-dvt/nal-h264.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
> similarity index 100%
> rename from drivers/media/platform/allegro-dvt/nal-h264.c
> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.c
> diff --git a/drivers/media/platform/allegro-dvt/nal-h264.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
> similarity index 100%
> rename from drivers/media/platform/allegro-dvt/nal-h264.h
> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-h264.h
> diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
> similarity index 100%
> rename from drivers/media/platform/allegro-dvt/nal-hevc.c
> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.c
> diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
> similarity index 100%
> rename from drivers/media/platform/allegro-dvt/nal-hevc.h
> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-hevc.h
> diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.c b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
> similarity index 100%
> rename from drivers/media/platform/allegro-dvt/nal-rbsp.c
> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.c
> diff --git a/drivers/media/platform/allegro-dvt/nal-rbsp.h b/drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
> similarity index 100%
> rename from drivers/media/platform/allegro-dvt/nal-rbsp.h
> rename to drivers/media/platform/allegro-dvt/zynqmp/nal-rbsp.h
> diff --git a/drivers/media/platform/allegro-dvt/allegro-core.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
> similarity index 99%
> rename from drivers/media/platform/allegro-dvt/allegro-core.c
> rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
> index e491399afcc9..8895d7755987 100644
> --- a/drivers/media/platform/allegro-dvt/allegro-core.c
> +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-core.c
> @@ -31,7 +31,7 @@
>  #include <media/videobuf2-dma-contig.h>
>  #include <media/videobuf2-v4l2.h>
>  
> -#include "allegro-mail.h"
> +#include "zynqmp-allegro-mail.h"
>  #include "nal-h264.h"
>  #include "nal-hevc.h"
>  
> diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.c b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
> similarity index 99%
> rename from drivers/media/platform/allegro-dvt/allegro-mail.c
> rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
> index aadc947a77ae..88a98f9e5d00 100644
> --- a/drivers/media/platform/allegro-dvt/allegro-mail.c
> +++ b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.c
> @@ -12,7 +12,7 @@
>  #include <linux/string.h>
>  #include <linux/videodev2.h>
>  
> -#include "allegro-mail.h"
> +#include "zynqmp-allegro-mail.h"
>  
>  const char *msg_type_name(enum mcu_msg_type type)
>  {
> diff --git a/drivers/media/platform/allegro-dvt/allegro-mail.h b/drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h
> similarity index 100%
> rename from drivers/media/platform/allegro-dvt/allegro-mail.h
> rename to drivers/media/platform/allegro-dvt/zynqmp/zynqmp-allegro-mail.h


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2025-02-06 20:00 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-02 10:26 [PATCH] media: allegro-dvt: Moving the current driver to subdirectory Yassine Ouaissa
2024-12-02 10:55 ` Michael Tretter
2024-12-04 14:44   ` Yassine Ouaissa
2024-12-04 16:27     ` Michael Tretter
2024-12-05  8:11       ` Yassine Ouaissa
2024-12-05  8:58         ` Michael Tretter
2024-12-05 18:26           ` Nicolas Dufresne
2025-02-06 20:00 ` Nicolas Dufresne

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox