Re: [PATCH v9 00/28] Qualcomm iris video decoder driver

[Johan Hovold <johan@kernel.org>]

[ +CC: Bjorn ]

On Thu, Dec 12, 2024 at 05:21:22PM +0530, Dikshita Agarwal wrote:
> Introduce support for Qualcomm new video acceleration hardware i.e. 
> iris, used for video stream decoding.

> Note: A harmless onetime error log "Lucid PLL latch failed. Output may
> be unstable!" is seen during bootup.  It doesn't impact any video 
> usecase and is currently under discussion.

This could be an indication that some resources are not described
correctly and could potentially require both binding and driver changes
to address.

This is also something which could cause trouble later (e.g. during
suspend) even if you manage to get the clock running after boot.

Generally, you should not be introducing any new warnings; they are
there to let you know that something is wrong.

Where is this issue being discussed?

I think we at least need a public analysis and understanding of the
problem before merging this.

> Dikshita Agarwal (18):
>       dt-bindings: media: Add video support for QCOM SM8550 SoC

Could you please post the DT changes required for sm8550 so that people
can test this series more easily? You can do it in a separate series if
you prefer (with a link to this series in the cover letter) or as part
of this one (at the end, with a note saying that those changes should go
through the qcom SoC tree).

>       media: iris: add platform driver for iris video device
>       media: iris: implement iris v4l2 file ops
>       media: iris: introduce iris core state management with shared queues
>       media: iris: implement video firmware load/unload
>       media: iris: implement boot sequence of the firmware
>       media: iris: introduce host firmware interface with necessary hooks
>       media: iris: implement power management
>       media: iris: implement reqbuf ioctl with vb2_queue_setup
>       media: iris: implement iris v4l2_ctrl_ops
>       media: iris: implement vb2 streaming ops
>       media: iris: allocate, initialize and queue internal buffers
>       media: iris: implement vb2 ops for buf_queue and firmware response
>       media: iris: add support for dynamic resolution change
>       media: iris: handle streamoff/on from client in dynamic resolution change
>       media: iris: add support for drain sequence
>       media: iris: enable video driver probe of SM8250 SoC

You should also say something in the cover letter about sm8250 now being
supported by two mainline drivers and how you propose to handle that
conflict.

>       media: MAINTAINERS: add Qualcomm iris video accelerator driver

Johan