From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A2FB217667; Fri, 21 Feb 2025 15:30:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740151809; cv=none; b=gX80kJHjCLVo0Z+e5FMUnKCiaJGXLOAxZAynCNQo2e5oGjKuCmIKgt2Nb/RhuOGVHiZgYvbtjjzFPH5DRwEDT9dS/0dZFZMFpbEYu/6jNmkICZD81aw1rdsU+5C0qiVMBTzPbjG6fiPB/6RHxVVRIMecWuX11Dz/bBk/ECEsANc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740151809; c=relaxed/simple; bh=a10TKzqmJet8/9ZU7PDZxSgGj+2k0QTwtubJJ85A/CY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k0R/fVyc4AgYv6nEeYNgJDCJTczFP41WHmBMdV4C3jCDdNdXFJ5tcbrkUCfx9uvwAML5hAY6Ol+kwK21sum9uscnieYHb5A+vxr/u0jOYCtO+AbcDV0Iw19nQ+wmDCizRgqsYNAgQutIWI1czhIAbLwSYXpxFkr+hjHsBG4duIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=UdBktBO5; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="UdBktBO5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740151808; x=1771687808; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=a10TKzqmJet8/9ZU7PDZxSgGj+2k0QTwtubJJ85A/CY=; b=UdBktBO5yJi6ljpGkS5pY77H2GhpKi97q1xEHtb3aQPBLr6qJ3oPbx3W syWCXT/SP/n2KVFqD/Sfof+b2yvXqAeDpMUVJwyczpMy4/7cgsAjnVGDJ y/Ae1sDKQ6RqwPgHXQqG1bk9NDA5bk4OB45TioHSj/zGYQR/1ziES4/WG LveSqKbHHb7UDnt2JELcJIBBf7ztnJBBXbhtesC0c5Ez3Stlt4wEz8i7O 8pbXPEXnpFV9p+R6w/mY4hZbbEnUcrB1t+Q5C1OGo9dMYa9prz30PucXY ziQHtx99gjDXyiys3OgyklWGoOqz5ttTQufTyLji0I/vrxfMvX0SzP+qv A==; X-CSE-ConnectionGUID: kUNtaVS/R4Sqepi+TNrHmw== X-CSE-MsgGUID: a31BbuczQgWe/T69y/nIdA== X-IronPort-AV: E=McAfee;i="6700,10204,11352"; a="66338340" X-IronPort-AV: E=Sophos;i="6.13,305,1732608000"; d="scan'208";a="66338340" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 07:30:06 -0800 X-CSE-ConnectionGUID: XlkuLuvzTu+o3LyVDuRCSg== X-CSE-MsgGUID: 9RnfdGy6ToKU8ejkF6/uoA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,305,1732608000"; d="scan'208";a="120018199" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 07:29:59 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tlUyQ-0000000Dg5t-29xn; Fri, 21 Feb 2025 17:29:54 +0200 Date: Fri, 21 Feb 2025 17:29:54 +0200 From: "andriy.shevchenko@linux.intel.com" To: Aditya Garg Cc: "pmladek@suse.com" , Steven Rostedt , "linux@rasmusvillemoes.dk" , "senozhatsky@chromium.org" , Jonathan Corbet , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "tzimmermann@suse.de" , "airlied@gmail.com" , "simona@ffwll.ch" , Andrew Morton , "apw@canonical.com" , "joe@perches.com" , "dwaipayanray1@gmail.com" , "lukas.bulwahn@gmail.com" , "sumit.semwal@linaro.org" , "christian.koenig@amd.com" , Kerem Karabay , Aun-Ali Zaidi , Orlando Chamberlain , Atharva Tiwari , "linux-doc@vger.kernel.org" , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , "linux-media@vger.kernel.org" , "linaro-mm-sig@lists.linaro.org" , Hector Martin , "linux@armlinux.org.uk" , Asahi Linux Mailing List , Sven Peter , Janne Grunau Subject: Re: [PATCH v3 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc Message-ID: References: <98289BC4-D5E1-41B8-AC89-632DBD2C2789@live.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98289BC4-D5E1-41B8-AC89-632DBD2C2789@live.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Feb 21, 2025 at 11:37:13AM +0000, Aditya Garg wrote: > From: Hector Martin First of all, I do not see the cover letter. Is it only an issue on my side? > %p4cc is designed for DRM/V4L2 FOURCCs with their specific quirks, but > it's useful to be able to print generic 4-character codes formatted as > an integer. Extend it to add format specifiers for printing generic > 32-bit FOURCCs with various endian semantics: > > %p4ch Host-endian > %p4cl Little-endian > %p4cb Big-endian > %p4cr Reverse-endian > > The endianness determines how bytes are interpreted as a u32, and the > FOURCC is then always printed MSByte-first (this is the opposite of > V4L/DRM FOURCCs). This covers most practical cases, e.g. %p4cr would > allow printing LSByte-first FOURCCs stored in host endian order > (other than the hex form being in character order, not the integer > value). Second, don't issue versions too fast, give at least a few days for the reviewers to have a chance on looking into it. Due to above this inherits the same issues as v2, please refer to my comments there. -- With Best Regards, Andy Shevchenko