From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9278F253339; Fri, 21 Feb 2025 20:23:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740169413; cv=none; b=BWiOOD44jyGcOIrFZH56E7FuwZo6ZJL0VKLH/4aMG+qB2XaaNsGvvrZK7Ik/cmE6kjrMyVuS2dIV3TNXA3wpLNs6Sk2cKtbSbwC+YQWVlrlrpEFqYjshMnhY0+M2qQhFczOxYKHwAO0VrFTtP0kZ3PaYuDn0GEudWQ+R/MEgCRM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740169413; c=relaxed/simple; bh=CKyMGvQhaCbbM4dHKRxSbETXs/jXlj2mdEkycK6ltnc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oxn/v0wPn/gAthI82IJ4/2l7NXWK/y0Wu/xN5yxDjWJaLNisM2EtIsyxSBg6Ho+vDAlHEOJKVJyT19EkLZOzRTlYXeZE75FEQtK/4fYn57Cvn7MKLLApvSMRs1/bo0CxXES7eZSEudTJnvMnW/b4roATcCkbscdCVlK9sYWTIgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=V3KGzY/5; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="V3KGzY/5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740169411; x=1771705411; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=CKyMGvQhaCbbM4dHKRxSbETXs/jXlj2mdEkycK6ltnc=; b=V3KGzY/59b6oyMtnpqcfhwBuZ/ZhjZtxoG+Q1rBFdr+NmVl2pmLQ4IGD x5nV0IXiEt7sAyKNVzQjZjJvQ9G/T2qRJkY2rVYbZU00qSiOZHbg7dVk6 Bx4nlQcGzmKFChlbgNrdh0lFJxXYvkqKxRv5iohaJAR7biWHYln4PPlKK aQt4lenQjawHMRmxz6C3uQsKJ8aFJw8RtRbN6b32s+DUqF1ETq+behvBb KqIQQn/Q2yrr1/1x5YEfOt9wY4tBJvLBnL+pzK4afvnUOB4hBag2XcVk4 nFuJxcSew7VurJM9RyIGZ8c/EDbiqodEm8pSEXsFxoBxQ5N5XS1JbyW9n w==; X-CSE-ConnectionGUID: moEGMDCyR+enJ8q8K2lRUQ== X-CSE-MsgGUID: 8WrqxZepQNW3Eo9usLrs0g== X-IronPort-AV: E=McAfee;i="6700,10204,11352"; a="51626707" X-IronPort-AV: E=Sophos;i="6.13,305,1732608000"; d="scan'208";a="51626707" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 12:23:30 -0800 X-CSE-ConnectionGUID: PzHLL2JBRAenORdpJeglfQ== X-CSE-MsgGUID: Z8nvZSezQB2xxyUO5TUppA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,305,1732608000"; d="scan'208";a="115993652" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa010.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2025 12:23:24 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tlZYN-0000000DjxE-45Ss; Fri, 21 Feb 2025 22:23:19 +0200 Date: Fri, 21 Feb 2025 22:23:19 +0200 From: "andriy.shevchenko@linux.intel.com" To: Aditya Garg Cc: "pmladek@suse.com" , "rostedt@goodmis.org" , "linux@rasmusvillemoes.dk" , "senozhatsky@chromium.org" , "corbet@lwn.net" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "tzimmermann@suse.de" , "airlied@gmail.com" , "simona@ffwll.ch" , "akpm@linux-foundation.org" , "apw@canonical.com" , "joe@perches.com" , "dwaipayanray1@gmail.com" , "lukas.bulwahn@gmail.com" , "sumit.semwal@linaro.org" , "christian.koenig@amd.com" , "kekrby@gmail.com" , "admin@kodeit.net" , Orlando Chamberlain , "evepolonium@gmail.com" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-media@vger.kernel.org" , "linaro-mm-sig@lists.linaro.org" , Hector Martin , "linux@armlinux.org.uk" , "asahi@lists.linux.dev" , Sven Peter , Janne Grunau Subject: Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc Message-ID: References: <716BCB0A-785B-463A-86C2-94BD66D5D22E@live.com> <9C31901A-2C5C-478B-BB1C-D4705939EE4D@live.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Feb 21, 2025 at 08:06:51PM +0000, Aditya Garg wrote: > > > Does this look good now? Made orig a union. > > Wait, it's messier. Maybe declare data type of val separately in each case? Yes, this sounds better. -- With Best Regards, Andy Shevchenko