From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1210B219304; Mon, 24 Feb 2025 11:42:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740397379; cv=none; b=Bhj2f+m2i4ovHzqbr58AISYcKoV6zNye8DoT9lKp3af/T2dTiHe0I/5n3Gr0yb1N5cc26k9EKanJFagT+J6GrM3L3GrpoP6f1URifuIQ295kR/piyoIphxY8QPilwC2PQpXvzpSwVQBdwvK3JUlv5qmnipUDYgiyYr6R4yndo0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740397379; c=relaxed/simple; bh=6OCRV0xcE71pdQo/ooLcXkgJAkHfA35prjUwXgmdZrU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lcLr0/WQETCCbW7R7yX3xrArOuUe2iyOGtDHXZ/qejwi1N3rT+IPyUhBCsenQ3zqngCDTvvUoaefeYaYsQPlX12jWY4uAUa96PX8H9y6x6lRzhAq3dcA4A3mp6YVDjzTn+2TgBGJvTULNtnl4rYkIAWSnFkjPlX6oblc5i0c3qc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=CxUDyeUH; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="CxUDyeUH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740397378; x=1771933378; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6OCRV0xcE71pdQo/ooLcXkgJAkHfA35prjUwXgmdZrU=; b=CxUDyeUHphnXEcGy2wGVNhvt3G4ohRAzRJnOOlgVTf1bTG7gDNPnxHwE GdE6xSHY7SAW/GABNCeYfpJ/usSvVhHeUp/0RneYevINV1xnFdfnAa7Xr BOG6e1/+rIt4fWpzhOeMKlek2uESeM0FfQhCcmYiq3T4aH3yVj/Uis5uC b25JFLUZwlQOEddDONU5BViSva7p8bXBuAGoiiUxYJAf44UNvQyZwkY4+ WXXw1i5CcoxUTmBvOYP4wnfKj8Iikqy76rmHhuCsyG65TBoLengn5pDDA Moh3fXuG05zJ/r/sWFotA6M9+AeneWFNXU1RxDN/R2GvqLa907qTl5daH A==; X-CSE-ConnectionGUID: NiswjYqIRJSdTSIZsp7iEA== X-CSE-MsgGUID: YqHlfXcRS3uiAi6uo+bbnA== X-IronPort-AV: E=McAfee;i="6700,10204,11354"; a="43976441" X-IronPort-AV: E=Sophos;i="6.13,309,1732608000"; d="scan'208";a="43976441" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2025 03:42:57 -0800 X-CSE-ConnectionGUID: 1R08KThaTxeJOXqJwi8GWA== X-CSE-MsgGUID: vjuad0/bQPmWqD5uSM5QeA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="121306390" Received: from smile.fi.intel.com ([10.237.72.58]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2025 03:42:48 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tmWrE-0000000EgNc-188V; Mon, 24 Feb 2025 13:42:44 +0200 Date: Mon, 24 Feb 2025 13:42:43 +0200 From: "andriy.shevchenko@linux.intel.com" To: Aditya Garg Cc: Thomas Zimmermann , "pmladek@suse.com" , Steven Rostedt , "linux@rasmusvillemoes.dk" , "senozhatsky@chromium.org" , Jonathan Corbet , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "airlied@gmail.com" , "simona@ffwll.ch" , Andrew Morton , "apw@canonical.com" , "joe@perches.com" , "dwaipayanray1@gmail.com" , "lukas.bulwahn@gmail.com" , "sumit.semwal@linaro.org" , "christian.koenig@amd.com" , Kerem Karabay , Aun-Ali Zaidi , Orlando Chamberlain , Atharva Tiwari , "linux-doc@vger.kernel.org" , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , "linux-media@vger.kernel.org" , "linaro-mm-sig@lists.linaro.org" , Hector Martin , "linux@armlinux.org.uk" , Asahi Linux Mailing List , Sven Peter , Janne Grunau Subject: Re: [PATCH v3 3/3] drm/tiny: add driver for Apple Touch Bars in x86 Macs Message-ID: References: <8F522D41-5417-467E-B9D3-7D9FC24AE536@live.com> <6f7b0886-5f31-4ba9-b82e-e9d3614b504f@suse.de> <3AC583EA-AA74-4F75-ADB9-3270519E8448@live.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3AC583EA-AA74-4F75-ADB9-3270519E8448@live.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Feb 24, 2025 at 11:20:12AM +0000, Aditya Garg wrote: > > > > > It would be nice to see the difference in the code generation for the all > > __packed vs. only those that require it. > > > >> At least it's clear then > >> what happens. And if your hardware requires this, you can't do much anyway. > > > > One aspect (member level alignment) is clear but the other is not > > (object level alignment). I dunno if it makes sense to be pedantic about this, > > but would like to see the binary outcome asked for. > > Hex dump of the compiled binary: Oh, sorry I wasn't clear. We have a script called bloat-o-meter for these purposes. Please, run it with old and new binaries as parameters and share the output. -- With Best Regards, Andy Shevchenko