From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6CAA219300; Mon, 24 Feb 2025 12:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740400073; cv=none; b=QnAqrdIoRxrSTJPeAv3zvgHxJepWu/sYpQBdDj6bRs4Hhb27qfwGoxw6p88gilesQ8HqF7/b0i7TAE9JtharTq5VqBYvefOjgbN9yIJiwsVxMDsIYUI/6h9mY8LUnyTr6DeBzb8WjAGmsGD2juq5fYQ+g0fULtc1zFQ+SgR8Q9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740400073; c=relaxed/simple; bh=ehOS2DLAOvq4B8Dskw4jr188VJvBUk4de8iEqUYAzYs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mYQua5icsuukMmiMAx5t799krjNiDJ1onua+6kFJusgK9LK3KZOFaYINLA4sKWvVpbmlvOfXWp5z+3IhQDI3q0SuAMl1IRDJG0iB4UKxY3Xl/B+adzkBQ+7oXc7OcTXQGH15ctVRLYRH2Z8w+jasK5eYWTZTAO83T1fe96P8wLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=EVQ7aBPC; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EVQ7aBPC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740400072; x=1771936072; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=ehOS2DLAOvq4B8Dskw4jr188VJvBUk4de8iEqUYAzYs=; b=EVQ7aBPCBfZ7QPbCBuVtlhqaEVaJC7DQ6dwOc1237VvCCsSLDSXbJXDe AWfWw7A0eoLYWbkypGVLmXVWyZf0bOq5GSMHlGEdN+/xG0D5Ed3FumtFV n6TfQn9uItZEK+8ZG7WhNii6streQC/1ybWUDLBhsCcdTVrWm17WXyL0B fXN3hVW+9+6OCQDEVwtN7FduVkuTKZeR4ANcUMLHM4WkuZ9/PIRu08SuU 18SavoJ2hD5MvrYyqoYRzVF1uEekRFabV1rYRlTPZVCYuvLMAQDgtANYu bzs4AQudQJ7B5XN9ljoXUsjPpQ0IxGd25/0o7ksVsTUokApfkSYHVNJS/ A==; X-CSE-ConnectionGUID: iJtQoMHTTem0q9b3jRKACQ== X-CSE-MsgGUID: 6BhNp7QYSgmv6ReJ35qmUg== X-IronPort-AV: E=McAfee;i="6700,10204,11355"; a="41167287" X-IronPort-AV: E=Sophos;i="6.13,309,1732608000"; d="scan'208";a="41167287" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2025 04:27:51 -0800 X-CSE-ConnectionGUID: +wIC8x9qQB+3KPPmx2a0kQ== X-CSE-MsgGUID: P3FUKr/gTjOYv49VEZlpSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,309,1732608000"; d="scan'208";a="116553489" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa010.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2025 04:27:43 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tmXYg-0000000EgzJ-2Ka1; Mon, 24 Feb 2025 14:27:38 +0200 Date: Mon, 24 Feb 2025 14:27:38 +0200 From: "andriy.shevchenko@linux.intel.com" To: Aditya Garg Cc: Thomas Zimmermann , "pmladek@suse.com" , Steven Rostedt , "linux@rasmusvillemoes.dk" , "senozhatsky@chromium.org" , Jonathan Corbet , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "airlied@gmail.com" , "simona@ffwll.ch" , Andrew Morton , "apw@canonical.com" , "joe@perches.com" , "dwaipayanray1@gmail.com" , "lukas.bulwahn@gmail.com" , "sumit.semwal@linaro.org" , "christian.koenig@amd.com" , Kerem Karabay , Aun-Ali Zaidi , Orlando Chamberlain , Atharva Tiwari , "linux-doc@vger.kernel.org" , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , "linux-media@vger.kernel.org" , "linaro-mm-sig@lists.linaro.org" , Hector Martin , "linux@armlinux.org.uk" , "asahi@lists.linux.dev" , Sven Peter , Janne Grunau Subject: Re: [PATCH v3 3/3] drm/tiny: add driver for Apple Touch Bars in x86 Macs Message-ID: References: <8F522D41-5417-467E-B9D3-7D9FC24AE536@live.com> <6f7b0886-5f31-4ba9-b82e-e9d3614b504f@suse.de> <3AC583EA-AA74-4F75-ADB9-3270519E8448@live.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Feb 24, 2025 at 11:57:47AM +0000, Aditya Garg wrote: > > On 24 Feb 2025, at 5:13 PM, andriy.shevchenko@linux.intel.com wrote: > > On Mon, Feb 24, 2025 at 11:20:12AM +0000, Aditya Garg wrote: > >> > >>> It would be nice to see the difference in the code generation for the all > >>> __packed vs. only those that require it. > >>> > >>>> At least it's clear then > >>>> what happens. And if your hardware requires this, you can't do much anyway. > >>> > >>> One aspect (member level alignment) is clear but the other is not > >>> (object level alignment). I dunno if it makes sense to be pedantic about this, > >>> but would like to see the binary outcome asked for. > >> > >> Hex dump of the compiled binary: > > > > Oh, sorry I wasn't clear. We have a script called bloat-o-meter for these > > purposes. Please, run it with old and new binaries as parameters and share the > > output. > aditya@MacBook:~/linux$ ./scripts/bloat-o-meter $PACKED $UNPACKED > add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0 (0) > Function old new delta > Total: Before=13286, After=13286, chg +0.00% Thanks! That shows that __packed can be used for all protocol related data types. Just mention in the commit message that the __packed, even if not needed, is: a) for the consistency, b) not affecting code generation in accordance with bloat-o-meter. -- With Best Regards, Andy Shevchenko