[PATCH] media: ipu6: Remove workaround for Meteor Lake ES2

[PATCH] media: ipu6: Remove workaround for Meteor Lake ES2

[Hao Yao]

There was a hardware bug which need IPU6 driver to disable the ATS.
This workaround is not needed anymore as the bug was fixed in
hardware level.

Signed-off-by: Hao Yao <hao.yao@intel.com>
---
 drivers/media/pci/intel/ipu6/ipu6.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c
index 277af7cda8ee..b00d0705fefa 100644
--- a/drivers/media/pci/intel/ipu6/ipu6.c
+++ b/drivers/media/pci/intel/ipu6/ipu6.c
@@ -464,11 +464,6 @@ static int ipu6_pci_config_setup(struct pci_dev *dev, u8 hw_ver)
 {
 	int ret;
 
-	/* disable IPU6 PCI ATS on mtl ES2 */
-	if (is_ipu6ep_mtl(hw_ver) && boot_cpu_data.x86_stepping == 0x2 &&
-	    pci_ats_supported(dev))
-		pci_disable_ats(dev);
-
 	/* No PCI msi capability for IPU6EP */
 	if (is_ipu6ep(hw_ver) || is_ipu6ep_mtl(hw_ver)) {
 		/* likely do nothing as msi not enabled by default */
-- 
2.43.0

Re: [PATCH] media: ipu6: Remove workaround for Meteor Lake ES2

[Stanislaw Gruszka]

On Tue, Mar 11, 2025 at 04:41:55PM +0800, Hao Yao wrote:
> There was a hardware bug which need IPU6 driver to disable the ATS.
> This workaround is not needed anymore as the bug was fixed in
> hardware level.
> 
> Signed-off-by: Hao Yao <hao.yao@intel.com>
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>

Regards
Stanislaw

> ---
>  drivers/media/pci/intel/ipu6/ipu6.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c
> index 277af7cda8ee..b00d0705fefa 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6.c
> @@ -464,11 +464,6 @@ static int ipu6_pci_config_setup(struct pci_dev *dev, u8 hw_ver)
>  {
>  	int ret;
>  
> -	/* disable IPU6 PCI ATS on mtl ES2 */
> -	if (is_ipu6ep_mtl(hw_ver) && boot_cpu_data.x86_stepping == 0x2 &&
> -	    pci_ats_supported(dev))
> -		pci_disable_ats(dev);
> -
>  	/* No PCI msi capability for IPU6EP */
>  	if (is_ipu6ep(hw_ver) || is_ipu6ep_mtl(hw_ver)) {
>  		/* likely do nothing as msi not enabled by default */
> -- 
> 2.43.0
> 
> 

Re: [PATCH] media: ipu6: Remove workaround for Meteor Lake ES2

[Bingbu Cao]

Hao,

On 3/11/25 4:41 PM, Hao Yao wrote:
> There was a hardware bug which need IPU6 driver to disable the ATS.
> This workaround is not needed anymore as the bug was fixed in
> hardware level.
>

It is better to send v2 with fixes tag here:

Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")

> Signed-off-by: Hao Yao <hao.yao@intel.com>
> ---
>  drivers/media/pci/intel/ipu6/ipu6.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c
> index 277af7cda8ee..b00d0705fefa 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6.c
> @@ -464,11 +464,6 @@ static int ipu6_pci_config_setup(struct pci_dev *dev, u8 hw_ver)
>  {
>  	int ret;
>  
> -	/* disable IPU6 PCI ATS on mtl ES2 */
> -	if (is_ipu6ep_mtl(hw_ver) && boot_cpu_data.x86_stepping == 0x2 &&
> -	    pci_ats_supported(dev))
> -		pci_disable_ats(dev);
> -
>  	/* No PCI msi capability for IPU6EP */
>  	if (is_ipu6ep(hw_ver) || is_ipu6ep_mtl(hw_ver)) {
>  		/* likely do nothing as msi not enabled by default */
>

-- 
Best regards,
Bingbu Cao

Re: [PATCH] media: ipu6: Remove workaround for Meteor Lake ES2

[Sakari Ailus]

Hi Bingbu,

On Thu, Apr 24, 2025 at 12:18:06PM +0800, Bingbu Cao wrote:
> Hao,
> 
> On 3/11/25 4:41 PM, Hao Yao wrote:
> > There was a hardware bug which need IPU6 driver to disable the ATS.
> > This workaround is not needed anymore as the bug was fixed in
> > hardware level.
> >
> 
> It is better to send v2 with fixes tag here:
> 
> Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")

Is this worth backporting? Nothing is broken because of this, is it?

> 
> > Signed-off-by: Hao Yao <hao.yao@intel.com>
> > ---
> >  drivers/media/pci/intel/ipu6/ipu6.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c
> > index 277af7cda8ee..b00d0705fefa 100644
> > --- a/drivers/media/pci/intel/ipu6/ipu6.c
> > +++ b/drivers/media/pci/intel/ipu6/ipu6.c
> > @@ -464,11 +464,6 @@ static int ipu6_pci_config_setup(struct pci_dev *dev, u8 hw_ver)
> >  {
> >  	int ret;
> >  
> > -	/* disable IPU6 PCI ATS on mtl ES2 */
> > -	if (is_ipu6ep_mtl(hw_ver) && boot_cpu_data.x86_stepping == 0x2 &&
> > -	    pci_ats_supported(dev))
> > -		pci_disable_ats(dev);
> > -
> >  	/* No PCI msi capability for IPU6EP */
> >  	if (is_ipu6ep(hw_ver) || is_ipu6ep_mtl(hw_ver)) {
> >  		/* likely do nothing as msi not enabled by default */
> >
> 

-- 
Regards,

Sakari Ailus

Re: [PATCH] media: ipu6: Remove workaround for Meteor Lake ES2

[Bingbu Cao]

Sakari,

On 4/24/25 7:55 PM, Sakari Ailus wrote:
> Hi Bingbu,
> 
> On Thu, Apr 24, 2025 at 12:18:06PM +0800, Bingbu Cao wrote:
>> Hao,
>>
>> On 3/11/25 4:41 PM, Hao Yao wrote:
>>> There was a hardware bug which need IPU6 driver to disable the ATS.
>>> This workaround is not needed anymore as the bug was fixed in
>>> hardware level.
>>>
>>
>> It is better to send v2 with fixes tag here:
>>
>> Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")
> 
> Is this worth backporting? Nothing is broken because of this, is it?

It is necessary. IPU6 on Raptor Lake share same device ID with
Meteor Lake, this workaround will break camera on Raptor Lake.

And Meteor Lake ES2 is not used in product.

> 
>>
>>> Signed-off-by: Hao Yao <hao.yao@intel.com>
>>> ---
>>>  drivers/media/pci/intel/ipu6/ipu6.c | 5 -----
>>>  1 file changed, 5 deletions(-)
>>>
>>> diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c
>>> index 277af7cda8ee..b00d0705fefa 100644
>>> --- a/drivers/media/pci/intel/ipu6/ipu6.c
>>> +++ b/drivers/media/pci/intel/ipu6/ipu6.c
>>> @@ -464,11 +464,6 @@ static int ipu6_pci_config_setup(struct pci_dev *dev, u8 hw_ver)
>>>  {
>>>  	int ret;
>>>  
>>> -	/* disable IPU6 PCI ATS on mtl ES2 */
>>> -	if (is_ipu6ep_mtl(hw_ver) && boot_cpu_data.x86_stepping == 0x2 &&
>>> -	    pci_ats_supported(dev))
>>> -		pci_disable_ats(dev);
>>> -
>>>  	/* No PCI msi capability for IPU6EP */
>>>  	if (is_ipu6ep(hw_ver) || is_ipu6ep_mtl(hw_ver)) {
>>>  		/* likely do nothing as msi not enabled by default */
>>>
>>
> 

-- 
Best regards,
Bingbu Cao

Re: [PATCH] media: ipu6: Remove workaround for Meteor Lake ES2

[Sakari Ailus]

Hi Bingbu,

On Fri, Apr 25, 2025 at 11:05:54AM +0800, Bingbu Cao wrote:
> Sakari,
> 
> On 4/24/25 7:55 PM, Sakari Ailus wrote:
> > Hi Bingbu,
> > 
> > On Thu, Apr 24, 2025 at 12:18:06PM +0800, Bingbu Cao wrote:
> >> Hao,
> >>
> >> On 3/11/25 4:41 PM, Hao Yao wrote:
> >>> There was a hardware bug which need IPU6 driver to disable the ATS.
> >>> This workaround is not needed anymore as the bug was fixed in
> >>> hardware level.
> >>>
> >>
> >> It is better to send v2 with fixes tag here:
> >>
> >> Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")
> > 
> > Is this worth backporting? Nothing is broken because of this, is it?
> 
> It is necessary. IPU6 on Raptor Lake share same device ID with
> Meteor Lake, this workaround will break camera on Raptor Lake.
> 
> And Meteor Lake ES2 is not used in product.

Ok, this should be visible in the commit message.

How about adding:

Additionally, Raptor Lake has the same IPU6 PCI ID and x86 stepping and but
does have the bug. Removing the Meteor Lake workaround is also required for
the driver to function on Raptor Lake.

-- 
Regards,

Sakari Ailus

Re: [PATCH] media: ipu6: Remove workaround for Meteor Lake ES2

[Hao Yao]

Hi Sakari, Bingbu,

On 2025/4/25 13:40, Sakari Ailus wrote:
> Hi Bingbu,
> 
> On Fri, Apr 25, 2025 at 11:05:54AM +0800, Bingbu Cao wrote:
>> Sakari,
>>
>> On 4/24/25 7:55 PM, Sakari Ailus wrote:
>>> Hi Bingbu,
>>>
>>> On Thu, Apr 24, 2025 at 12:18:06PM +0800, Bingbu Cao wrote:
>>>> Hao,
>>>>
>>>> On 3/11/25 4:41 PM, Hao Yao wrote:
>>>>> There was a hardware bug which need IPU6 driver to disable the ATS.
>>>>> This workaround is not needed anymore as the bug was fixed in
>>>>> hardware level.
>>>>>
>>>>
>>>> It is better to send v2 with fixes tag here:
>>>>
>>>> Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")
>>>
>>> Is this worth backporting? Nothing is broken because of this, is it?
>>
>> It is necessary. IPU6 on Raptor Lake share same device ID with
>> Meteor Lake, this workaround will break camera on Raptor Lake.
>>
>> And Meteor Lake ES2 is not used in product.
> 
> Ok, this should be visible in the commit message.
> 
> How about adding:
> 
> Additionally, Raptor Lake has the same IPU6 PCI ID and x86 stepping and but
> does have the bug. Removing the Meteor Lake workaround is also required for
> the driver to function on Raptor Lake.
> 
In fact it should be Arrow Lake. I will add below to next version:
---
  Additionally, Arrow Lake has the same IPU6 PCI ID and x86 stepping 

  but does not have the bug. Removing the Meteor Lake workaround is 

  also required for the driver to function on Arrow Lake. 

  

  Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device 

  driver")
---

Re: [PATCH] media: ipu6: Remove workaround for Meteor Lake ES2

[Bingbu Cao]

On 4/25/25 2:30 PM, Sakari Ailus wrote:
> On Fri, Apr 25, 2025 at 02:28:12PM +0800, Hao Yao wrote:
>> Hi Sakari, Bingbu,
>>
>> On 2025/4/25 13:40, Sakari Ailus wrote:
>>> Hi Bingbu,
>>>
>>> On Fri, Apr 25, 2025 at 11:05:54AM +0800, Bingbu Cao wrote:
>>>> Sakari,
>>>>
>>>> On 4/24/25 7:55 PM, Sakari Ailus wrote:
>>>>> Hi Bingbu,
>>>>>
>>>>> On Thu, Apr 24, 2025 at 12:18:06PM +0800, Bingbu Cao wrote:
>>>>>> Hao,
>>>>>>
>>>>>> On 3/11/25 4:41 PM, Hao Yao wrote:
>>>>>>> There was a hardware bug which need IPU6 driver to disable the ATS.
>>>>>>> This workaround is not needed anymore as the bug was fixed in
>>>>>>> hardware level.
>>>>>>>
>>>>>>
>>>>>> It is better to send v2 with fixes tag here:
>>>>>>
>>>>>> Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")
>>>>>
>>>>> Is this worth backporting? Nothing is broken because of this, is it?
>>>>
>>>> It is necessary. IPU6 on Raptor Lake share same device ID with
>>>> Meteor Lake, this workaround will break camera on Raptor Lake.
>>>>
>>>> And Meteor Lake ES2 is not used in product.
>>>
>>> Ok, this should be visible in the commit message.
>>>
>>> How about adding:
>>>
>>> Additionally, Raptor Lake has the same IPU6 PCI ID and x86 stepping and but
>>> does have the bug. Removing the Meteor Lake workaround is also required for
>>> the driver to function on Raptor Lake.
>>>
>> In fact it should be Arrow Lake. I will add below to next version:
>> ---
>>  Additionally, Arrow Lake has the same IPU6 PCI ID and x86 stepping
>>
>>  but does not have the bug. Removing the Meteor Lake workaround is
>>
>>  also required for the driver to function on Arrow Lake.
>>
>>
>>  Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device
>>
>>  driver")
>> ---
> 
> I can just take it from here, no need to resed.

Thanks!

-- 
Best regards,
Bingbu Cao

Re: [PATCH] media: ipu6: Remove workaround for Meteor Lake ES2

[Sakari Ailus]

On Fri, Apr 25, 2025 at 02:28:12PM +0800, Hao Yao wrote:
> Hi Sakari, Bingbu,
> 
> On 2025/4/25 13:40, Sakari Ailus wrote:
> > Hi Bingbu,
> > 
> > On Fri, Apr 25, 2025 at 11:05:54AM +0800, Bingbu Cao wrote:
> > > Sakari,
> > > 
> > > On 4/24/25 7:55 PM, Sakari Ailus wrote:
> > > > Hi Bingbu,
> > > > 
> > > > On Thu, Apr 24, 2025 at 12:18:06PM +0800, Bingbu Cao wrote:
> > > > > Hao,
> > > > > 
> > > > > On 3/11/25 4:41 PM, Hao Yao wrote:
> > > > > > There was a hardware bug which need IPU6 driver to disable the ATS.
> > > > > > This workaround is not needed anymore as the bug was fixed in
> > > > > > hardware level.
> > > > > > 
> > > > > 
> > > > > It is better to send v2 with fixes tag here:
> > > > > 
> > > > > Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")
> > > > 
> > > > Is this worth backporting? Nothing is broken because of this, is it?
> > > 
> > > It is necessary. IPU6 on Raptor Lake share same device ID with
> > > Meteor Lake, this workaround will break camera on Raptor Lake.
> > > 
> > > And Meteor Lake ES2 is not used in product.
> > 
> > Ok, this should be visible in the commit message.
> > 
> > How about adding:
> > 
> > Additionally, Raptor Lake has the same IPU6 PCI ID and x86 stepping and but
> > does have the bug. Removing the Meteor Lake workaround is also required for
> > the driver to function on Raptor Lake.
> > 
> In fact it should be Arrow Lake. I will add below to next version:
> ---
>  Additionally, Arrow Lake has the same IPU6 PCI ID and x86 stepping
> 
>  but does not have the bug. Removing the Meteor Lake workaround is
> 
>  also required for the driver to function on Arrow Lake.
> 
> 
>  Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device
> 
>  driver")
> ---

I can just take it from here, no need to resed.

-- 
Sakari Ailus