Re: [PATCH v1 3/3] media: intel/ipu6: Constify ipu6_buttress_ctrl structure

[Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>]

Hi Sakari,

On Fri, Mar 07, 2025 at 07:45:03AM +0000, Sakari Ailus wrote:
> >  ipu6_bus_initialize_device(struct pci_dev *pdev, struct device *parent,
> > -			   void *pdata, struct ipu6_buttress_ctrl *ctrl,
> > +			   void *pdata, const struct ipu6_buttress_ctrl *ctrl,
> 
> pdata should be const, too, btw.
> 
> >  			   char *name);
> >  int ipu6_bus_add_device(struct ipu6_bus_device *adev);
> >  void ipu6_bus_del_devices(struct pci_dev *pdev);
> > diff --git a/drivers/media/pci/intel/ipu6/ipu6-buttress.c b/drivers/media/pci/intel/ipu6/ipu6-buttress.c
> > index 787fcbd1df09..f8fdc07a953c 100644
> > --- a/drivers/media/pci/intel/ipu6/ipu6-buttress.c
> > +++ b/drivers/media/pci/intel/ipu6/ipu6-buttress.c
> > @@ -443,7 +443,7 @@ irqreturn_t ipu6_buttress_isr_threaded(int irq, void *isp_ptr)
> >  	return ret;
> >  }
> >  
> > -int ipu6_buttress_power(struct device *dev, struct ipu6_buttress_ctrl *ctrl,
> > +int ipu6_buttress_power(struct device *dev, const struct ipu6_buttress_ctrl *ctrl,
> >  			bool on)
> 
> But this is over 80.

On official kernel doc the limit is 100 (with 80 being preferred).
I run chackpatch.pl on this patch and it was just fine.

However clang-format change this to:

int ipu6_buttress_power(struct device *dev,
			const struct ipu6_buttress_ctrl *ctrl, bool on)

which is less than 80 characters. So I guess I need to use auto formatter
for lines I change (for whole file clang-format change lot unrelated things).

Regards
Stanislaw