[PATCH v2 11/18] wifi: brcm80211: Replace open-coded parity calculation with parity32()

Kuan-Wei Chiu
2025-03-01T14:27:09Z

Refactor parity calculations to use the standard parity32() helper.
This change eliminates redundant implementations and improves code
efficiency.

Co-developed-by: Yu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
---
.../wireless/broadcom/brcm80211/brcmsmac/dma.c | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c
index 80c35027787a..d1a1ecd97d42 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c
@@ -17,6 +17,7 @@
#include <linux/slab.h>
#include <linux/delay.h>
#include <linux/pci.h>
+#include <linux/bitops.h>
#include <net/cfg80211.h>
#include <net/mac80211.h>

@@ -283,21 +284,6 @@ struct dma_info {
bool aligndesc_4k;
};

-/* Check for odd number of 1's */
-static u32 parity32(__le32 data)
-{
- /* no swap needed for counting 1's */
- u32 par_data = *(u32 *)&data;
-
- par_data ^= par_data >> 16;
- par_data ^= par_data >> 8;
- par_data ^= par_data >> 4;
- par_data ^= par_data >> 2;
- par_data ^= par_data >> 1;
-
- return par_data & 1;
-}
-
static bool dma64_dd_parity(struct dma64desc *dd)
{
return parity32(dd->addrlow ^ dd->addrhigh ^ dd->ctrl1 ^ dd->ctrl2);
--
2.34.1