* [PATCH v2 1/1] media: i2c: imx290: Make use of get_unaligned_le24(), put_unaligned_le24()
@ 2023-02-09 22:12 Andy Shevchenko
2023-02-09 22:35 ` Laurent Pinchart
0 siblings, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2023-02-09 22:12 UTC (permalink / raw)
To: Laurent Pinchart, Sakari Ailus, Alexander Stein, linux-media,
linux-kernel
Cc: Manivannan Sadhasivam, Mauro Carvalho Chehab, Andy Shevchenko
Since we have a proper endianness converters for LE 24-bit data use them.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: dropped unrelated noise from the commit message (Laurent)
drivers/media/i2c/imx290.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
index 49d6c8bdec41..330098a0772d 100644
--- a/drivers/media/i2c/imx290.c
+++ b/drivers/media/i2c/imx290.c
@@ -16,6 +16,9 @@
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
#include <linux/regulator/consumer.h>
+
+#include <asm/unaligned.h>
+
#include <media/media-entity.h>
#include <media/v4l2-ctrls.h>
#include <media/v4l2-device.h>
@@ -466,18 +469,20 @@ static int __always_unused imx290_read(struct imx290 *imx290, u32 addr, u32 *val
return ret;
}
- *value = (data[2] << 16) | (data[1] << 8) | data[0];
+ *value = get_unaligned_le24(data);
return 0;
}
static int imx290_write(struct imx290 *imx290, u32 addr, u32 value, int *err)
{
- u8 data[3] = { value & 0xff, (value >> 8) & 0xff, value >> 16 };
+ u8 data[3];
int ret;
if (err && *err)
return *err;
+ put_unaligned_le24(value, data);
+
ret = regmap_raw_write(imx290->regmap, addr & IMX290_REG_ADDR_MASK,
data, (addr >> IMX290_REG_SIZE_SHIFT) & 3);
if (ret < 0) {
--
2.39.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 1/1] media: i2c: imx290: Make use of get_unaligned_le24(), put_unaligned_le24()
2023-02-09 22:12 [PATCH v2 1/1] media: i2c: imx290: Make use of get_unaligned_le24(), put_unaligned_le24() Andy Shevchenko
@ 2023-02-09 22:35 ` Laurent Pinchart
2023-02-10 17:06 ` Andy Shevchenko
0 siblings, 1 reply; 8+ messages in thread
From: Laurent Pinchart @ 2023-02-09 22:35 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Sakari Ailus, Alexander Stein, linux-media, linux-kernel,
Manivannan Sadhasivam, Mauro Carvalho Chehab
Hi Andy,
Thank you for the patch.
On Fri, Feb 10, 2023 at 12:12:05AM +0200, Andy Shevchenko wrote:
> Since we have a proper endianness converters for LE 24-bit data use them.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I assume Sakari will pick both patches.
> ---
> v2: dropped unrelated noise from the commit message (Laurent)
> drivers/media/i2c/imx290.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index 49d6c8bdec41..330098a0772d 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -16,6 +16,9 @@
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> #include <linux/regulator/consumer.h>
> +
> +#include <asm/unaligned.h>
> +
> #include <media/media-entity.h>
> #include <media/v4l2-ctrls.h>
> #include <media/v4l2-device.h>
> @@ -466,18 +469,20 @@ static int __always_unused imx290_read(struct imx290 *imx290, u32 addr, u32 *val
> return ret;
> }
>
> - *value = (data[2] << 16) | (data[1] << 8) | data[0];
> + *value = get_unaligned_le24(data);
> return 0;
> }
>
> static int imx290_write(struct imx290 *imx290, u32 addr, u32 value, int *err)
> {
> - u8 data[3] = { value & 0xff, (value >> 8) & 0xff, value >> 16 };
> + u8 data[3];
> int ret;
>
> if (err && *err)
> return *err;
>
> + put_unaligned_le24(value, data);
> +
> ret = regmap_raw_write(imx290->regmap, addr & IMX290_REG_ADDR_MASK,
> data, (addr >> IMX290_REG_SIZE_SHIFT) & 3);
> if (ret < 0) {
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2 1/1] media: i2c: imx290: Make use of get_unaligned_le24(), put_unaligned_le24()
2023-02-09 22:35 ` Laurent Pinchart
@ 2023-02-10 17:06 ` Andy Shevchenko
2023-03-10 17:21 ` Andy Shevchenko
0 siblings, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2023-02-10 17:06 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Sakari Ailus, Alexander Stein, linux-media, linux-kernel,
Manivannan Sadhasivam, Mauro Carvalho Chehab
On Fri, Feb 10, 2023 at 12:35:09AM +0200, Laurent Pinchart wrote:
> On Fri, Feb 10, 2023 at 12:12:05AM +0200, Andy Shevchenko wrote:
> > Since we have a proper endianness converters for LE 24-bit data use them.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thank you for the reviews!
> I assume Sakari will pick both patches.
I also assume the same.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] media: i2c: imx290: Make use of get_unaligned_le24(), put_unaligned_le24()
2023-02-10 17:06 ` Andy Shevchenko
@ 2023-03-10 17:21 ` Andy Shevchenko
2023-03-13 11:32 ` Sakari Ailus
0 siblings, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2023-03-10 17:21 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Sakari Ailus, Alexander Stein, linux-media, linux-kernel,
Manivannan Sadhasivam, Mauro Carvalho Chehab
On Fri, Feb 10, 2023 at 07:06:32PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 10, 2023 at 12:35:09AM +0200, Laurent Pinchart wrote:
> > On Fri, Feb 10, 2023 at 12:12:05AM +0200, Andy Shevchenko wrote:
> > > Since we have a proper endianness converters for LE 24-bit data use them.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Thank you for the reviews!
>
> > I assume Sakari will pick both patches.
>
> I also assume the same.
Sakari, do you have any comments?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] media: i2c: imx290: Make use of get_unaligned_le24(), put_unaligned_le24()
2023-03-10 17:21 ` Andy Shevchenko
@ 2023-03-13 11:32 ` Sakari Ailus
2023-03-13 12:01 ` Andy Shevchenko
0 siblings, 1 reply; 8+ messages in thread
From: Sakari Ailus @ 2023-03-13 11:32 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Laurent Pinchart, Sakari Ailus, Alexander Stein, linux-media,
linux-kernel, Manivannan Sadhasivam, Mauro Carvalho Chehab
On Fri, Mar 10, 2023 at 07:21:44PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 10, 2023 at 07:06:32PM +0200, Andy Shevchenko wrote:
> > On Fri, Feb 10, 2023 at 12:35:09AM +0200, Laurent Pinchart wrote:
> > > On Fri, Feb 10, 2023 at 12:12:05AM +0200, Andy Shevchenko wrote:
> > > > Since we have a proper endianness converters for LE 24-bit data use them.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > >
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Thank you for the reviews!
> >
> > > I assume Sakari will pick both patches.
> >
> > I also assume the same.
>
> Sakari, do you have any comments?
Yes. These are in my tree now.
--
Sakari Ailus
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] media: i2c: imx290: Make use of get_unaligned_le24(), put_unaligned_le24()
2023-03-13 11:32 ` Sakari Ailus
@ 2023-03-13 12:01 ` Andy Shevchenko
2023-03-13 13:20 ` Sakari Ailus
0 siblings, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2023-03-13 12:01 UTC (permalink / raw)
To: Sakari Ailus
Cc: Laurent Pinchart, Sakari Ailus, Alexander Stein, linux-media,
linux-kernel, Manivannan Sadhasivam, Mauro Carvalho Chehab
On Mon, Mar 13, 2023 at 01:32:55PM +0200, Sakari Ailus wrote:
> On Fri, Mar 10, 2023 at 07:21:44PM +0200, Andy Shevchenko wrote:
> > On Fri, Feb 10, 2023 at 07:06:32PM +0200, Andy Shevchenko wrote:
> > > On Fri, Feb 10, 2023 at 12:35:09AM +0200, Laurent Pinchart wrote:
> > > > On Fri, Feb 10, 2023 at 12:12:05AM +0200, Andy Shevchenko wrote:
> > > > > Since we have a proper endianness converters for LE 24-bit data use them.
> > > > >
> > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > >
> > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > Thank you for the reviews!
> > >
> > > > I assume Sakari will pick both patches.
> > >
> > > I also assume the same.
> >
> > Sakari, do you have any comments?
>
> Yes. These are in my tree now.
Which is...?
I don't see anything on https://git.linuxtv.org/sailus/media_tree.git/.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] media: i2c: imx290: Make use of get_unaligned_le24(), put_unaligned_le24()
2023-03-13 12:01 ` Andy Shevchenko
@ 2023-03-13 13:20 ` Sakari Ailus
2023-03-13 15:57 ` Andy Shevchenko
0 siblings, 1 reply; 8+ messages in thread
From: Sakari Ailus @ 2023-03-13 13:20 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Sakari Ailus, Laurent Pinchart, Alexander Stein, linux-media,
linux-kernel, Manivannan Sadhasivam, Mauro Carvalho Chehab
On Mon, Mar 13, 2023 at 02:01:23PM +0200, Andy Shevchenko wrote:
> On Mon, Mar 13, 2023 at 01:32:55PM +0200, Sakari Ailus wrote:
> > On Fri, Mar 10, 2023 at 07:21:44PM +0200, Andy Shevchenko wrote:
> > > On Fri, Feb 10, 2023 at 07:06:32PM +0200, Andy Shevchenko wrote:
> > > > On Fri, Feb 10, 2023 at 12:35:09AM +0200, Laurent Pinchart wrote:
> > > > > On Fri, Feb 10, 2023 at 12:12:05AM +0200, Andy Shevchenko wrote:
> > > > > > Since we have a proper endianness converters for LE 24-bit data use them.
> > > > > >
> > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > >
> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > >
> > > > Thank you for the reviews!
> > > >
> > > > > I assume Sakari will pick both patches.
> > > >
> > > > I also assume the same.
> > >
> > > Sakari, do you have any comments?
> >
> > Yes. These are in my tree now.
>
> Which is...?
>
> I don't see anything on https://git.linuxtv.org/sailus/media_tree.git/.
This is a bit opportunistic since we don't have rc1 in the media tree yet.
I'll push it once we do.
--
Sakari Ailus
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] media: i2c: imx290: Make use of get_unaligned_le24(), put_unaligned_le24()
2023-03-13 13:20 ` Sakari Ailus
@ 2023-03-13 15:57 ` Andy Shevchenko
0 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2023-03-13 15:57 UTC (permalink / raw)
To: Sakari Ailus
Cc: Sakari Ailus, Laurent Pinchart, Alexander Stein, linux-media,
linux-kernel, Manivannan Sadhasivam, Mauro Carvalho Chehab
On Mon, Mar 13, 2023 at 03:20:42PM +0200, Sakari Ailus wrote:
> On Mon, Mar 13, 2023 at 02:01:23PM +0200, Andy Shevchenko wrote:
> > On Mon, Mar 13, 2023 at 01:32:55PM +0200, Sakari Ailus wrote:
> > > On Fri, Mar 10, 2023 at 07:21:44PM +0200, Andy Shevchenko wrote:
...
> > > Yes. These are in my tree now.
> >
> > Which is...?
> >
> > I don't see anything on https://git.linuxtv.org/sailus/media_tree.git/.
>
> This is a bit opportunistic since we don't have rc1 in the media tree yet.
>
> I'll push it once we do.
Ah, thank you!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-03-13 15:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-09 22:12 [PATCH v2 1/1] media: i2c: imx290: Make use of get_unaligned_le24(), put_unaligned_le24() Andy Shevchenko
2023-02-09 22:35 ` Laurent Pinchart
2023-02-10 17:06 ` Andy Shevchenko
2023-03-10 17:21 ` Andy Shevchenko
2023-03-13 11:32 ` Sakari Ailus
2023-03-13 12:01 ` Andy Shevchenko
2023-03-13 13:20 ` Sakari Ailus
2023-03-13 15:57 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox