Re: [PATCH 049/117] media: rcar-core: Convert to platform remove callback returning void

["Niklas Söderlund" <niklas.soderlund@ragnatech.se>]

On 2023-03-26 16:31:16 +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  drivers/media/platform/renesas/rcar-vin/rcar-core.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-core.c b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> index 5e53d6b7036c..1398f147e5c2 100644
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> @@ -1442,7 +1442,7 @@ static int rcar_vin_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static int rcar_vin_remove(struct platform_device *pdev)
> +static void rcar_vin_remove(struct platform_device *pdev)
>  {
>  	struct rvin_dev *vin = platform_get_drvdata(pdev);
>  
> @@ -1458,8 +1458,6 @@ static int rcar_vin_remove(struct platform_device *pdev)
>  		rvin_parallel_cleanup(vin);
>  
>  	rvin_dma_unregister(vin);
> -
> -	return 0;
>  }
>  
>  static SIMPLE_DEV_PM_OPS(rvin_pm_ops, rvin_suspend, rvin_resume);
> @@ -1472,7 +1470,7 @@ static struct platform_driver rcar_vin_driver = {
>  		.of_match_table = rvin_of_id_table,
>  	},
>  	.probe = rcar_vin_probe,
> -	.remove = rcar_vin_remove,
> +	.remove_new = rcar_vin_remove,
>  };
>  
>  module_platform_driver(rcar_vin_driver);
> -- 
> 2.39.2
> 

-- 
Kind Regards,
Niklas Söderlund