From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 556C5C7EE26 for ; Mon, 22 May 2023 12:51:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233371AbjEVMv3 (ORCPT ); Mon, 22 May 2023 08:51:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233257AbjEVMv1 (ORCPT ); Mon, 22 May 2023 08:51:27 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 756A092 for ; Mon, 22 May 2023 05:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684759883; x=1716295883; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pL1idd6XbB8DSJRKMloscbHAhbrOtykQpSVbdAGm2Gk=; b=ASVxjNYmFC6DUMJRj0wRVig4fGNFBu6utHyQ+1mfsREQIxz8ZsHgq5Wt sHDfTW/Ncj6wucoaVZjpL2JKYn/9EyRlIDIcg1n+sc0zCYcomeLGU3EEn u8WOJmBQwZf/zuO1e2dHmqOyVJljg6+BO/OMmAWqNrd0+mDUHucKY+Sle tM3Rw8DgEvy7eK9XFfa0xtRRRDzRD0ZlOgIgp0rxN/Vces8SP2Ur8d7yX n07khxbNq5L10rnDVpSWI2yi0UjeGfot0h6+7Lojo9XQtA74gVgo1Kmhq u61YZj62Lm7arM0y7ldZOJ/rU91MnU1p9FaisVCcrRecHNLYq0nqoRRue A==; X-IronPort-AV: E=McAfee;i="6600,9927,10717"; a="416370937" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="416370937" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 05:51:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10717"; a="768499280" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="768499280" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 05:51:20 -0700 Received: from kekkonen.localdomain (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 70047120BF9; Mon, 22 May 2023 15:51:18 +0300 (EEST) Date: Mon, 22 May 2023 12:51:18 +0000 From: Sakari Ailus To: Linux regressions mailing list Cc: Laurent Pinchart , Mauro Carvalho Chehab , Jacopo Mondi , Alexander Stein , linux-media@vger.kernel.org, niklas.soderlund@ragnatech.se Subject: Re: v4l2-async: regression due to endpoint matching Message-ID: References: <8360125.31r3eYUQgx@steina-w> <5676976.irdbgypaU6@steina-w> <6415252.e9J7NaK4W3@steina-w> <3u5xed27to5bnwo3dksviydw6z2lga3udjkgvvzor4tlobjlxv@hsnam3wurgxc> <618ab198-836e-16ba-4c02-476feac2ffaa@leemhuis.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <618ab198-836e-16ba-4c02-476feac2ffaa@leemhuis.info> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Thorsten, On Mon, May 22, 2023 at 02:11:29PM +0200, Linux regression tracking (Thorsten Leemhuis) wrote: > On 22.05.23 13:59, Sakari Ailus wrote: > > On Mon, May 22, 2023 at 12:53:52PM +0200, Linux regression tracking (Thorsten Leemhuis) wrote: > >> On 28.04.23 09:16, Sakari Ailus wrote: > >>> On Fri, Apr 28, 2023 at 08:43:21AM +0200, Jacopo Mondi wrote: > >>>> On Fri, Apr 28, 2023 at 08:33:30AM +0200, Alexander Stein wrote: > >>>>> Am Freitag, 28. April 2023, 08:31:54 CEST schrieb Jacopo Mondi: > >>>>>> On Fri, Apr 28, 2023 at 08:24:22AM +0200, Alexander Stein wrote: > >>>>>>> Am Donnerstag, 27. April 2023, 18:01:38 CEST schrieb Jacopo Mondi: > >>>>>>>> On Thu, Apr 27, 2023 at 04:40:46PM +0200, Alexander Stein wrote: > >>>>>>>>> I have a setup on my TQMa6x (imx6q-mba6a.dts) with a tc358743 attached > >>>>>>>>> to > >>>>>>>>> the MIPI CSI input. > >>>>>>>>> I noticed that since commit 1f391df44607 ("media: v4l2-async: Use > >>>>>>>>> endpoints in __v4l2_async_nf_add_fwnode_remote()") the async subdevice > >>>>>>>>> probing does not work anymore. If I revert that, it is working again, > >>>>>>>>> even on next-20230425. > >>>>>>>> > >>>>>>>> A similar issue has been discussed at > >>>>>>>> https://www.spinics.net/lists/linux-media/msg223351.html > >>>>>>>> > >>>>>>>> Unfortunately there was no conclusion as far as I can tell if not that > >>>>>>>> imx6 is now broken > >>>>>>> > >>>>>>> Thanks for the link, seems like a non-trivial thing :( > >>>>>>> > >>>>>>> From a glimpse, this series seems to deal with multiple async subdevs: > >>>>>>> https://lore.kernel.org/all/20230330115853.1628216-1-sakari.ailus@linux.in > >>>>>>> tel.com/ > >>>>>>> > >>>>>>> So imx-media-csi should be adjusted as well, no? > >>>>>> > >>>>>> It would really be helpful if you can give that series a spin on imx6 > >>>>>> if you already have a test setup. > >>>>> > >>>>> I tried, but it failed to apply on my current development tree. What base does > >>>>> this series apply to? Is there also a repository available I can fetch from? > >>>> > >>>> Sakari could tell, for me it applied on v6.3-rc2 but I recall I had to > >>>> manually fix a few things. > >>> > >>> Don't try v1, it won't work. I missed some object relation changes in the > >>> linked lists. I'll post v2, hopefully some time next week, to address these > >>> issues. > >> > >> Hi, Thorsten here, the Linux kernel's regression tracker. > >> > >> I see that v2[1] got a lot of ACKs, but is not even yet in next. And > >> it's a lot of patches, so maybe too much for backporting to stable > >> kernels. Which leads to the question: Will the regression this thread is > >> about (introduced in 5.19 afaics) ever be fixed in v6.1? > >> Normally/Ideally it should be. > > > > We'll need v3 (at least), a problem that's not trivial to fix was > > identified with v2. There patches aren't really fixes either: it's new > > functionality that wasn't there previously. I.MX6 just happened to work due > > to missing checks in the V4L2 async framework, what it needs was never > > supported (without this set). > > > > Dropping endpoint matching will break adv748x driver that relies on it. > > > > So I'd expect i.MX6 to work again once we have this set in, but I wouldn't > > try to backport the set. > > Thx for the update. Makes me wonder if reverting the culprit[1] is an > option. Assuming the problem still happens. Alexander, is that the case? > > Ciao, Thorsten > > [1] 1f391df4460 ("media: v4l2-async: Use endpoints in > __v4l2_async_nf_add_fwnode_remote()") (v5.19-rc1; authored by Laurent, > commited by Mauro (both now CCed)) I prioritise an in-kernel driver over a staging driver. -- Regards, Sakari Ailus