From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 204DAEB64DB for ; Fri, 16 Jun 2023 14:33:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343842AbjFPOdZ (ORCPT ); Fri, 16 Jun 2023 10:33:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbjFPOdY (ORCPT ); Fri, 16 Jun 2023 10:33:24 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05C9C30E7; Fri, 16 Jun 2023 07:33:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686926003; x=1718462003; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bvGpNDLA3a0FFTGl0eVY+fodubNpqqXghduB4BJyHyg=; b=lMbLfizi9C+rva15GSFUPQboSfuPo0os/zih35nUvpG/tosrS3DwlNIg 5Jh/AT8BZEuwXdZHoEejn8AXZ4aiDsOwftCWjJ6Y+J5gDzXtCzpPoF3QF s+gu5FcqlIed1aFGQY+ojak8IpggztllsYTnQ8Jaz7RPH8zxuDiE5I7Gl pvPHgjgT7gQKOgLuFLFQVrT3EZfIqeoq8hjnm0YB+RU3coo++y8W2tA2c D74b2rMGm8HihqhJvqxUHQnPZQ4hGzAvyboI+64qPxo8R/mw3HE9aUSv1 0AkdB7l7T0jjK70NBZgchJu3zEjIaAQo85n8ji6maI+a5ABQYy+Uypr/1 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="338843656" X-IronPort-AV: E=Sophos;i="6.00,247,1681196400"; d="scan'208";a="338843656" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2023 07:33:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="742691961" X-IronPort-AV: E=Sophos;i="6.00,247,1681196400"; d="scan'208";a="742691961" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 16 Jun 2023 07:33:16 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qAAVl-004Iuf-1D; Fri, 16 Jun 2023 17:33:13 +0300 Date: Fri, 16 Jun 2023 17:33:13 +0300 From: Andy Shevchenko To: Tomi Valkeinen Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Luca Ceresoli , Matti Vaittinen , Laurent Pinchart , Sakari Ailus , Wolfram Sang , Rob Herring , Krzysztof Kozlowski , Mauro Carvalho Chehab , Peter Rosin , Liam Girdwood , Mark Brown , Michael Tretter , Hans Verkuil , Mike Pagano , Krzysztof =?utf-8?Q?Ha=C5=82asa?= , Marek Vasut , Satish Nagireddy Subject: Re: [PATCH v14 15/18] media: i2c: ds90ub953: Handle V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK Message-ID: References: <20230616135922.442979-1-tomi.valkeinen@ideasonboard.com> <20230616135922.442979-16-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230616135922.442979-16-tomi.valkeinen@ideasonboard.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Jun 16, 2023 at 04:59:19PM +0300, Tomi Valkeinen wrote: > Handle V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK flag to configure the CSI-2 RX > continuous/non-continuous clock register. ... > struct regmap *regmap; I forgot if we discussed this along with i2c_client *client nearby. Since I reviewed Hans' patches the pure struct device *dev (instead of *client) might make more sense, despite being duplicative with regmap associated device. > u32 num_data_lanes; > + bool non_cont_clk; > > struct gpio_chip gpio_chip; And also try to place this as a first member and see (by using bloat-o-meter, for example) if it saves bytes. I'm wondering if we have tools like pahole but which suggests the better layout based on the code generation... Maybe something along with clang? -- With Best Regards, Andy Shevchenko