From: Andy Shevchenko <andy@kernel.org>
To: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Rui Miguel Silva <rmfrfs@gmail.com>,
Daniel Scally <dan.scally@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kate Hsuan <hpa@redhat.com>,
Tommaso Merciai <tomm.merciai@gmail.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3 07/29] media: ov2680: Fix ov2680_set_fmt() which == V4L2_SUBDEV_FORMAT_TRY not working
Date: Tue, 27 Jun 2023 19:55:48 +0300 [thread overview]
Message-ID: <ZJsUlErfzcpBNljz@smile.fi.intel.com> (raw)
In-Reply-To: <abnylacvx7hhhvpu7bmcuyf7cwm2g7snmbngwi3ckaowfakuqe@yvk7ghilhru5>
On Tue, Jun 27, 2023 at 05:08:39PM +0200, Jacopo Mondi wrote:
> On Tue, Jun 27, 2023 at 03:18:08PM +0200, Hans de Goede wrote:
...
> > mode = v4l2_find_nearest_size(ov2680_mode_data,
> > - ARRAY_SIZE(ov2680_mode_data), width,
> > - height, fmt->width, fmt->height);
> > + ARRAY_SIZE(ov2680_mode_data),
> > + width, height,
> > + format->format.width,
> > + format->format.height);
> > if (!mode)
> > return -EINVAL;
>
> Nit: only if you have to resend, could this be dropped? mode will be NULL
> only if ov2680_mode_data[] has no entries.
We shouldn't rely on the implementation details of some API if it's not
advertised that way. Even if it is, the robustness of the code is better with
this check.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-27 16:56 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 13:18 [PATCH v3 00/29] media: ov2680: Bugfixes + ACPI + selection(crop-tgt) API support Hans de Goede
2023-06-27 13:18 ` [PATCH v3 01/29] media: ov2680: Remove auto-gain and auto-exposure controls Hans de Goede
2023-06-27 13:18 ` [PATCH v3 02/29] media: ov2680: Fix ov2680_bayer_order() Hans de Goede
2023-06-27 13:18 ` [PATCH v3 03/29] media: ov2680: Fix vflip / hflip set functions Hans de Goede
2023-06-27 14:35 ` Jacopo Mondi
2023-06-27 14:38 ` Hans de Goede
2023-06-27 15:01 ` Jacopo Mondi
2023-06-27 13:18 ` [PATCH v3 04/29] media: ov2680: Use select VIDEO_V4L2_SUBDEV_API Hans de Goede
2023-06-27 13:18 ` [PATCH v3 05/29] media: ov2680: Don't take the lock for try_fmt calls Hans de Goede
2023-06-27 13:18 ` [PATCH v3 06/29] media: ov2680: Add ov2680_fill_format() helper function Hans de Goede
2023-06-27 13:18 ` [PATCH v3 07/29] media: ov2680: Fix ov2680_set_fmt() which == V4L2_SUBDEV_FORMAT_TRY not working Hans de Goede
2023-06-27 14:32 ` Dan Scally
2023-06-27 15:08 ` Jacopo Mondi
2023-06-27 16:55 ` Andy Shevchenko [this message]
2023-06-27 17:17 ` Hans de Goede
2023-06-27 21:49 ` Jacopo Mondi
2023-06-27 13:18 ` [PATCH v3 08/29] media: ov2680: Fix regulators being left enabled on ov2680_power_on() errors Hans de Goede
2023-06-27 13:18 ` [PATCH v3 09/29] media: ov2680: Convert to new CCI register access helpers Hans de Goede
2023-06-27 13:18 ` [PATCH v3 10/29] media: ov2680: Store dev instead of i2c_client in ov2680_dev Hans de Goede
2023-06-27 13:18 ` [PATCH v3 11/29] media: ov2680: Check for "powerdown" GPIO con-id before checking for "reset" GPIO con-id Hans de Goede
2023-06-27 14:40 ` Dan Scally
2023-06-27 13:18 ` [PATCH v3 12/29] media: ov2680: Add runtime-pm support Hans de Goede
2023-06-27 13:18 ` [PATCH v3 13/29] media: ov2680: Drop is_enabled flag Hans de Goede
2023-06-27 14:50 ` Dan Scally
2023-06-27 13:18 ` [PATCH v3 14/29] media: ov2680: Add support for more clk setups Hans de Goede
2023-07-03 6:58 ` Dan Scally
2023-07-03 11:01 ` Tommaso Merciai
2023-07-31 12:44 ` Sakari Ailus
2023-07-31 12:54 ` Hans de Goede
2023-07-31 13:35 ` Sakari Ailus
2023-07-31 13:47 ` Hans de Goede
2023-06-27 13:18 ` [PATCH v3 15/29] media: ov2680: Add support for 19.2 MHz clock Hans de Goede
2023-06-27 13:18 ` [PATCH v3 16/29] media: ov2680: Add endpoint matching support Hans de Goede
2023-06-27 13:18 ` [PATCH v3 17/29] media: ov2680: Add support for ACPI enumeration Hans de Goede
2023-06-27 13:18 ` [PATCH v3 18/29] media: ov2680: Fix ov2680_enum_frame_interval() Hans de Goede
2023-07-03 7:26 ` Dan Scally
2023-08-01 8:28 ` Hans de Goede
2023-06-27 13:18 ` [PATCH v3 19/29] media: ov2680: Annotate the per mode register setting lists Hans de Goede
2023-06-27 13:18 ` [PATCH v3 20/29] media: ov2680: Add ov2680_mode struct Hans de Goede
2023-06-27 13:18 ` [PATCH v3 21/29] media: ov2680: Make setting the mode algorithm based Hans de Goede
2023-07-03 8:50 ` Dan Scally
2023-08-01 8:42 ` Hans de Goede
2023-06-27 13:18 ` [PATCH v3 22/29] media: ov2680: Add an __ov2680_get_pad_format() helper function Hans de Goede
2023-06-27 13:18 ` [PATCH v3 23/29] media: ov2680: Implement selection support Hans de Goede
2023-06-27 13:18 ` [PATCH v3 24/29] media: ov2680: Fix exposure and gain ctrls range and default value Hans de Goede
2023-06-27 15:16 ` Jacopo Mondi
2023-06-27 16:26 ` Hans de Goede
2023-06-27 22:09 ` Jacopo Mondi
2023-06-27 13:18 ` [PATCH v3 25/29] media: ov2680: Add a bunch of register tweaks Hans de Goede
2023-06-27 13:18 ` [PATCH v3 26/29] media: ov2680: Drop unnecessary pad checks Hans de Goede
2023-06-27 13:18 ` [PATCH v3 27/29] media: ov2680: Read and log sensor revision during probe Hans de Goede
2023-06-27 13:18 ` [PATCH v3 28/29] media: ov2680: Add link-freq and pixel-rate controls Hans de Goede
2023-07-04 9:22 ` Dan Scally
2023-07-04 9:44 ` Hans de Goede
2023-07-04 11:23 ` Dave Stevenson
2023-07-04 11:29 ` Hans de Goede
2023-07-04 11:32 ` Hans de Goede
2023-07-04 11:37 ` Dan Scally
2023-07-04 12:19 ` Dave Stevenson
2023-07-04 14:36 ` Andy Shevchenko
2023-06-27 13:18 ` [PATCH v3 29/29] MAINTAINERS: Add Hans de Goede as OV2680 sensor driver maintainer Hans de Goede
2023-07-03 7:24 ` Rui Miguel Silva
2023-07-04 9:23 ` Dan Scally
2023-06-27 14:11 ` [PATCH v3 00/29] media: ov2680: Bugfixes + ACPI + selection(crop-tgt) API support Jacopo Mondi
2023-06-27 14:30 ` Hans de Goede
2023-06-27 14:29 ` [PATCH v3 12/29] media: ov2680: Add runtime-pm support Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJsUlErfzcpBNljz@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rmfrfs@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox