From: Andy Shevchenko <andy@kernel.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Daniel Scally <dan.scally@ideasonboard.com>,
linux-acpi@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kate Hsuan <hpa@redhat.com>, Hao Yao <hao.yao@intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
linux-media@vger.kernel.org, Daniel Scally <djrscally@gmail.com>
Subject: Re: [PATCH v3 14/18] media: i2c: Add driver for DW9719 VCM
Date: Thu, 6 Jul 2023 13:48:25 +0300 [thread overview]
Message-ID: <ZKab+VVFvF0qcIOw@smile.fi.intel.com> (raw)
In-Reply-To: <ZKaXK3uRQxB7UTo0@kekkonen.localdomain>
On Thu, Jul 06, 2023 at 10:27:55AM +0000, Sakari Ailus wrote:
> On Thu, Jul 06, 2023 at 01:06:07PM +0300, Andy Shevchenko wrote:
...
> > > + dw9719->regulator = devm_regulator_get(&client->dev, "vdd");
> > > + if (IS_ERR(dw9719->regulator))
> > > + return dev_err_probe(&client->dev, PTR_ERR(dw9719->regulator),
> >
> > With
> >
> > struct device *dev = &client->dev;
> >
> > code may look neater.
>
> I prefer it as-is.
May I ask what the technical rationale behind your preferences? Esp. taking
into account how picky you are for 80 character limit.
> > > + "getting regulator\n");
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-06 10:48 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 21:29 [PATCH v3 00/18] media: ipu-bridge: Shared with atomisp, rework VCM instantiation Hans de Goede
2023-07-05 21:29 ` [PATCH v3 01/18] media: ipu-bridge: Fix null pointer deref on SSDB/PLD parsing warnings Hans de Goede
2023-07-06 13:07 ` Dan Scally
2023-07-05 21:29 ` [PATCH v3 02/18] media: ipu-bridge: Do not use on stack memory for software_node.name field Hans de Goede
2023-07-05 21:29 ` [PATCH v3 03/18] media: ipu-bridge: Move initialization of node_names.vcm to ipu_bridge_init_swnode_names() Hans de Goede
2023-07-05 21:29 ` [PATCH v3 04/18] media: ipu-bridge: Allow building as module Hans de Goede
2023-07-06 9:47 ` Andy Shevchenko
2023-07-05 21:29 ` [PATCH v3 05/18] media: ipu-bridge: Make ipu_bridge_init() take a regular struct device as argument Hans de Goede
2023-07-05 21:29 ` [PATCH v3 06/18] media: ipu-bridge: Store dev pointer in struct ipu_bridge Hans de Goede
2023-07-05 21:29 ` [PATCH v3 07/18] media: ipu-bridge: Only keep PLD around while parsing Hans de Goede
2023-07-05 21:30 ` [PATCH v3 08/18] media: ipu-bridge: Add a ipu_bridge_parse_ssdb() helper function Hans de Goede
2023-07-05 21:30 ` [PATCH v3 09/18] media: ipu-bridge: Drop early setting of sensor->adev Hans de Goede
2023-07-05 21:30 ` [PATCH v3 10/18] media: ipu-bridge: Add a parse_sensor_fwnode callback to ipu_bridge_init() Hans de Goede
2023-07-06 9:50 ` Andy Shevchenko
2023-07-05 21:30 ` [PATCH v3 11/18] media: ipu-bridge: Move ipu-bridge.h to include/media/ Hans de Goede
2023-07-05 21:30 ` [PATCH v3 12/18] media: ipu-bridge: Add GalaxyCore GC0310 to ipu_supported_sensors[] Hans de Goede
2023-07-05 21:30 ` [PATCH v3 13/18] media: ipu-bridge: Add a runtime-pm device-link between VCM and sensor Hans de Goede
2023-07-05 21:30 ` [PATCH v3 14/18] media: i2c: Add driver for DW9719 VCM Hans de Goede
2023-07-06 7:47 ` Sakari Ailus
2023-07-06 9:14 ` Andy Shevchenko
2023-07-06 9:30 ` Sakari Ailus
2023-07-06 10:06 ` Andy Shevchenko
2023-07-06 10:27 ` Sakari Ailus
2023-07-06 10:48 ` Andy Shevchenko [this message]
2023-07-06 11:02 ` Sakari Ailus
2023-07-06 14:34 ` Hans de Goede
2023-07-06 14:47 ` Andy Shevchenko
2023-07-06 11:18 ` Dave Stevenson
2023-07-06 12:34 ` Hans de Goede
2023-07-06 12:52 ` Hans de Goede
2023-07-05 21:30 ` [PATCH v3 15/18] ACPI: bus: Introduce acpi_match_acpi_device() function Hans de Goede
2023-07-06 9:19 ` Andy Shevchenko
2023-07-06 12:29 ` Hans de Goede
2023-07-06 12:40 ` Andy Shevchenko
2023-07-06 13:26 ` Rafael J. Wysocki
2023-07-06 13:28 ` Hans de Goede
2023-07-06 13:31 ` Andy Shevchenko
2023-07-05 21:30 ` [PATCH v3 16/18] media: atomisp: csi2-bridge: Switch to new common ipu_bridge_init() Hans de Goede
2023-07-05 21:30 ` [PATCH v3 17/18] media: atomisp: csi2-bridge: Add dev_name() to acpi_handle_info() logging Hans de Goede
2023-07-06 10:09 ` Andy Shevchenko
2023-07-06 11:12 ` Laurent Pinchart
2023-07-06 12:23 ` Andy Shevchenko
2023-07-06 13:07 ` Laurent Pinchart
2023-07-06 13:22 ` Andy Shevchenko
2023-07-06 13:43 ` Sakari Ailus
2023-07-05 21:30 ` [PATCH v3 18/18] media: atomisp: csi2-bridge: Add support for VCM I2C-client instantiation Hans de Goede
2023-07-06 10:15 ` Andy Shevchenko
2023-07-06 12:31 ` Hans de Goede
2023-07-06 12:42 ` Andy Shevchenko
2023-07-06 12:47 ` Hans de Goede
2023-07-06 12:56 ` Andy Shevchenko
2023-07-06 12:58 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKab+VVFvF0qcIOw@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=bingbu.cao@intel.com \
--cc=dan.scally@ideasonboard.com \
--cc=djrscally@gmail.com \
--cc=hao.yao@intel.com \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox