From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 665DBC001DF for ; Tue, 1 Aug 2023 13:53:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233188AbjHANx3 (ORCPT ); Tue, 1 Aug 2023 09:53:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232909AbjHANx2 (ORCPT ); Tue, 1 Aug 2023 09:53:28 -0400 Received: from mgamail.intel.com (unknown [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D13D1E4; Tue, 1 Aug 2023 06:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690898005; x=1722434005; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nIYKnL0gLdWiIzoPC3kqGQrPs7uvjKL+Tri0yD1cqF8=; b=XU1wwi/1c8SGDwvErMRYqcZmtG7oWGBSwXXzOsRPwl6pwEIkj/0QwXZt c1WpYg9bOADyaBDo1evfXyg7dnTcd4yiQxM5CssS0inbVxZXIHuyAK2JE IJEyGRQXtwAoVJTWoQEfJuGiQJ6MFwJg1LUY1xytpg26Yz0hq2QZ31Hdz l7B8Fy4sju4A/M18obMCumj6ZvUutIq3B5bEiyXozvJfN8QsdAN6TuSJf 5T4SvSEdWMcoZAvjnHntcQvKHQFyGSI1KwWJOu7XTQgxyExVXZF0rVgkh eRiNMI+kUXImtVEU7MvjiU9LXtEDWwpn65cuKPYSk/5od6rGEuiwVjmaW Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="366769124" X-IronPort-AV: E=Sophos;i="6.01,247,1684825200"; d="scan'208";a="366769124" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 06:53:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="705836404" X-IronPort-AV: E=Sophos;i="6.01,247,1684825200"; d="scan'208";a="705836404" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006.jf.intel.com with ESMTP; 01 Aug 2023 06:53:22 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qQpoO-005Clu-0y; Tue, 01 Aug 2023 16:53:20 +0300 Date: Tue, 1 Aug 2023 16:53:19 +0300 From: Andy Shevchenko To: Tomi Valkeinen Cc: Mauro Carvalho Chehab , Luca Ceresoli , Laurent Pinchart , Sakari Ailus , Hans Verkuil , Satish Nagireddy , Matti Vaittinen , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 7/9] media: i2c: ds90ub953: Restructure clkout management Message-ID: References: <20230731-fpdlink-additions-v3-0-8acfc49c215a@ideasonboard.com> <20230731-fpdlink-additions-v3-7-8acfc49c215a@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230731-fpdlink-additions-v3-7-8acfc49c215a@ideasonboard.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Jul 31, 2023 at 04:24:41PM +0300, Tomi Valkeinen wrote: > Separate clkout calculations and register writes into two functions: > ub953_calc_clkout_params and ub953_write_clkout_regs, and add a struct > ub953_clkout_data that is used to store the clkout parameters. > > This simplifies the clkout management. ... > +#define UB953_DEFAULT_CLKOUT_RATE 25000000UL HZ_PER_MHZ (from units.h)? ... > +struct ub953_clkout_data { > + u32 hs_div; > + u32 m; > + u32 n; > + unsigned long rate; You may save 4 bytes on some architectures (which do not allow 4-byte alignment for 64-bit members) by reshuffling the members. (besides using u32-fract :-) > +}; ... > + dev_dbg(dev, "%s %llu * %u / (8 * %u) = %lu (requested %lu)", > + __func__, fc_rate, m, n, clkout_rate, target_rate); __func__ in dev_dbg() is not needed. It's very rare nowadays to debug a kernel without Dynamic Debug to be on. ... > + dev_dbg(dev, "%s %llu / %u * %u / %u = %lu (requested %lu)", > + __func__, fc_rate, hs_div, m, n, clkout_rate, > + target_rate); Ditto. -- With Best Regards, Andy Shevchenko