From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org,
Andrey Utkin <andrey_utkin@fastmail.com>,
Anton Sviridenko <anton@corp.bluecherry.net>,
Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>,
Banajit Goswami <bgoswami@quicinc.com>,
Bluecherry Maintainers <maintainers@bluecherrydvr.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Ismael Luceno <ismael@iodev.co.uk>,
Lars-Peter Clausen <lars@metafoo.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-media@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t
Date: Mon, 7 Aug 2023 19:00:07 +0300 [thread overview]
Message-ID: <ZNEVB8ZJah9Y9Bua@smile.fi.intel.com> (raw)
In-Reply-To: <87pm3yj2s5.wl-tiwai@suse.de>
On Mon, Aug 07, 2023 at 05:22:18PM +0200, Takashi Iwai wrote:
> On Tue, 01 Aug 2023 19:51:39 +0200, Andy Shevchenko wrote:
> > On Tue, Aug 01, 2023 at 02:54:45PM +0200, Takashi Iwai wrote:
...
> I rather wonder why it can't be simple strncpy().
This is obvious. To avoid compiler warning about 0 (possible) truncation.
...
> > Taking all remarks into account I would rather go with sockptr.h being
> > untouched for now, just a big
> >
> > /* DO NOT USE, it's obsolete, use uniptr.h instead! */
> >
> > to be added.
>
> Possibly that's a safer choice. But the biggest question is whether
> we want a generic type or not. Let's try to ask it first.
>
> Interestingly, this file doesn't belong to any subsystem in
> MAINTAINERS, so I'm not sure who to be Cc'ed. Chirstoph as the
> original author and net dev, maybe.
Yes, but actually it's fine to just copy and change sockptr.h to say
"that's blablabla for net subsystem" (maybe this is implied by the name?).
In that case we just introduce our copy and can do whatever modifications
we want (see previous reply).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-07 16:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 15:46 [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t Takashi Iwai
2023-07-31 15:47 ` [PATCH 16/24] media: solo6x10: Convert to generic PCM copy ops Takashi Iwai
2023-07-31 17:20 ` [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t Mark Brown
2023-07-31 19:30 ` Takashi Iwai
2023-07-31 19:40 ` Mark Brown
2023-08-01 12:54 ` Takashi Iwai
2023-08-01 14:04 ` Mark Brown
2023-08-01 17:51 ` Andy Shevchenko
2023-08-07 15:22 ` Takashi Iwai
2023-08-07 16:00 ` Andy Shevchenko [this message]
2023-08-01 13:57 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNEVB8ZJah9Y9Bua@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrey_utkin@fastmail.com \
--cc=anton@corp.bluecherry.net \
--cc=arnaud.pouliquen@foss.st.com \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=ismael@iodev.co.uk \
--cc=lars@metafoo.de \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=olivier.moysan@foss.st.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox