Re: [GIT PULL FOR v6.7] Minor rc fixes

[Sean Young <sean@mess.org>]

On Wed, Oct 11, 2023 at 04:55:54PM +0200, Hans Verkuil wrote:
> On 11/10/2023 16:53, Sean Young wrote:
> > On Wed, Oct 11, 2023 at 03:51:29PM +0200, Hans Verkuil wrote:
> >> On 11/10/2023 15:40, Sean Young wrote:
> >>> On Wed, Oct 11, 2023 at 02:58:19PM +0200, Hans Verkuil wrote:
> >>>> On 09/10/2023 09:41, Sean Young wrote:
> >>>> These two patches have a Cc to stable, but no Fixes: tag.
> >>>
> >>> I've added the fixes tags and retagged the v6.7c tag in my repo.
> >>
> >> I'll pick it up from your repo again. No need to do anything.
> > 
> > Thanks.
> > 
> > If we have rules like "Cc: stable" requires "Fixes: " then we really need 
> > tooling that picks that up and warns us about it. Otherwise, not everyone
> > will know or remember.
> > 
> > Something for your build-scripts?
> 
> That's why I discovered this: I added that check to the build scripts yesterday :-)

Perfect! I did not do a git pull on the build scripts, so that's my mistake
then.

> I think a Cc to stable is not needed if you have a Fixes tag, though.

That's a fair point. I viewed "Cc: stable" as an strong indicator to the
stable teams that "this should really go in the stable branch" but I guess
this is implied by the Fixes tags.

Thanks,

Sean