[GIT PULL FOR v6.7] Minor rc fixes

[GIT PULL FOR v6.7] Minor rc fixes

[Sean Young]

The following changes since commit 73835b514160dc548f7d77c6cd7fe6a8629d3406:

  media: imon: fix access to invalid resource for the second interface (2023-10-07 10:55:48 +0200)

are available in the Git repository at:

  git://linuxtv.org/syoung/media_tree.git tags/v6.7c

for you to fetch changes up to faf2b9954d9c9fdbac48e4b1d45d5ba2d3f10e52:

  media: lirc: drop trailing space from scancode transmit (2023-10-09 08:22:14 +0100)

----------------------------------------------------------------
v6.7c

----------------------------------------------------------------
Sean Young (2):
      media: sharp: fix sharp encoding
      media: lirc: drop trailing space from scancode transmit

 drivers/media/rc/ir-sharp-decoder.c | 8 +++++---
 drivers/media/rc/lirc_dev.c         | 6 +++++-
 2 files changed, 10 insertions(+), 4 deletions(-)

Re: [GIT PULL FOR v6.7] Minor rc fixes (#95641)

[Jenkins]

From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/ZSOux5a0d0tu9FtE@gofer.mess.org/
Build log: https://builder.linuxtv.org/job/patchwork/346688/
Build time: 00:20:41
Link: https://lore.kernel.org/linux-media/ZSOux5a0d0tu9FtE@gofer.mess.org

gpg: Signature made Mon 09 Oct 2023 07:27:28 AM UTC
gpg:                using RSA key A624251A26084A9ED9E4C8B6425F639D3960FA9E
gpg:                issuer "sean@mess.org"
gpg: Good signature from "Sean Young <sean@mess.org>" [full]

Summary: got 1/2 patches with issues, being 1 at build time

Error/warnings:

patches/0001-media-sharp-fix-sharp-encoding.patch:

    allyesconfig: return code #0:
	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
	../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
	../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:446 gc0310_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2779 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2878 atomisp_cp_morph_table() warn: missing unwind goto?

    allyesconfig: return code #0:
	../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto?
	../drivers/media/usb/dvb-usb-v2/af9035.c: ../drivers/media/usb/dvb-usb-v2/af9035.c:467 af9035_i2c_master_xfer() warn: inconsistent returns '&d->i2c_mutex'.
	  Locked on  : 326,387
	  Unlocked on: 465,467
	../drivers/media/i2c/mt9m114.c: ../drivers/media/i2c/mt9m114.c:2381 mt9m114_probe() warn: missing unwind goto?
	../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687.
	SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
	../drivers/media/pci/cx25821/cx25821-medusa-video.c: ../drivers/media/pci/cx25821/cx25821-medusa-video.c:399 medusa_set_videostandard() parse error: OOM: 3003988Kb sm_state_count = 2158
	../drivers/media/pci/cx25821/cx25821-medusa-video.c: ../drivers/media/pci/cx25821/cx25821-medusa-video.c:399 medusa_set_videostandard() parse error: __split_smt: function too hairy.  Giving up after 4 seconds
	../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2792 mxc_jpeg_probe() warn: missing unwind goto?
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2517 dvb_register() parse error: OOM: 3014560Kb sm_state_count = 1757213
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2517 dvb_register() parse error: __split_smt: function too hairy.  Giving up after 50 seconds
	../drivers/media/pci/mgb4/mgb4_sysfs_out.c: ../drivers/media/pci/mgb4/mgb4_sysfs_out.c:118 video_source_store() warn: potential spectre issue 'mgbdev->vin' [r] (local cap)
	../drivers/media/pci/mgb4/mgb4_sysfs_out.c: ../drivers/media/pci/mgb4/mgb4_sysfs_out.c:122 video_source_store() warn: possible spectre second half.  'loopin_new'
	../drivers/media/pci/ivtv/ivtvfb.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../drivers/media/pci/ivtv/ivtv-driver.h):
	SPARSE:../drivers/media/pci/ivtv/ivtvfb.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression
	../drivers/media/usb/uvc/uvc_v4l2.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../include/linux/rcuwait.h, ...):
	SPARSE:../drivers/media/usb/uvc/uvc_v4l2.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2890 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

Re: [GIT PULL FOR v6.7] Minor rc fixes

[Hans Verkuil]

On 09/10/2023 09:41, Sean Young wrote:
> The following changes since commit 73835b514160dc548f7d77c6cd7fe6a8629d3406:
> 
>   media: imon: fix access to invalid resource for the second interface (2023-10-07 10:55:48 +0200)
> 
> are available in the Git repository at:
> 
>   git://linuxtv.org/syoung/media_tree.git tags/v6.7c
> 
> for you to fetch changes up to faf2b9954d9c9fdbac48e4b1d45d5ba2d3f10e52:
> 
>   media: lirc: drop trailing space from scancode transmit (2023-10-09 08:22:14 +0100)
> 
> ----------------------------------------------------------------
> v6.7c
> 
> ----------------------------------------------------------------
> Sean Young (2):
>       media: sharp: fix sharp encoding
>       media: lirc: drop trailing space from scancode transmit
> 
>  drivers/media/rc/ir-sharp-decoder.c | 8 +++++---
>  drivers/media/rc/lirc_dev.c         | 6 +++++-
>  2 files changed, 10 insertions(+), 4 deletions(-)

These two patches have a Cc to stable, but no Fixes: tag.

Can you provide Fixes tags for these two patches? I can add them
manually.

Regards,

	Hans

Re: [GIT PULL FOR v6.7] Minor rc fixes

[Sean Young]

On Wed, Oct 11, 2023 at 02:58:19PM +0200, Hans Verkuil wrote:
> On 09/10/2023 09:41, Sean Young wrote:
> > The following changes since commit 73835b514160dc548f7d77c6cd7fe6a8629d3406:
> > 
> >   media: imon: fix access to invalid resource for the second interface (2023-10-07 10:55:48 +0200)
> > 
> > are available in the Git repository at:
> > 
> >   git://linuxtv.org/syoung/media_tree.git tags/v6.7c
> > 
> > for you to fetch changes up to faf2b9954d9c9fdbac48e4b1d45d5ba2d3f10e52:
> > 
> >   media: lirc: drop trailing space from scancode transmit (2023-10-09 08:22:14 +0100)
> > 
> > ----------------------------------------------------------------
> > v6.7c
> > 
> > ----------------------------------------------------------------
> > Sean Young (2):
> >       media: sharp: fix sharp encoding
> >       media: lirc: drop trailing space from scancode transmit
> > 
> >  drivers/media/rc/ir-sharp-decoder.c | 8 +++++---
> >  drivers/media/rc/lirc_dev.c         | 6 +++++-
> >  2 files changed, 10 insertions(+), 4 deletions(-)
> 
> These two patches have a Cc to stable, but no Fixes: tag.

I've added the fixes tags and retagged the v6.7c tag in my repo.

> Can you provide Fixes tags for these two patches? I can add them
> manually.

I should have fully read your message before retagging, my bad. What do
you want me to do now? The patches haven't changed, just the commit
messages.


Sean

Re: [GIT PULL FOR v6.7] Minor rc fixes

[Hans Verkuil]

On 11/10/2023 15:40, Sean Young wrote:
> On Wed, Oct 11, 2023 at 02:58:19PM +0200, Hans Verkuil wrote:
>> On 09/10/2023 09:41, Sean Young wrote:
>>> The following changes since commit 73835b514160dc548f7d77c6cd7fe6a8629d3406:
>>>
>>>   media: imon: fix access to invalid resource for the second interface (2023-10-07 10:55:48 +0200)
>>>
>>> are available in the Git repository at:
>>>
>>>   git://linuxtv.org/syoung/media_tree.git tags/v6.7c
>>>
>>> for you to fetch changes up to faf2b9954d9c9fdbac48e4b1d45d5ba2d3f10e52:
>>>
>>>   media: lirc: drop trailing space from scancode transmit (2023-10-09 08:22:14 +0100)
>>>
>>> ----------------------------------------------------------------
>>> v6.7c
>>>
>>> ----------------------------------------------------------------
>>> Sean Young (2):
>>>       media: sharp: fix sharp encoding
>>>       media: lirc: drop trailing space from scancode transmit
>>>
>>>  drivers/media/rc/ir-sharp-decoder.c | 8 +++++---
>>>  drivers/media/rc/lirc_dev.c         | 6 +++++-
>>>  2 files changed, 10 insertions(+), 4 deletions(-)
>>
>> These two patches have a Cc to stable, but no Fixes: tag.
> 
> I've added the fixes tags and retagged the v6.7c tag in my repo.
> 
>> Can you provide Fixes tags for these two patches? I can add them
>> manually.
> 
> I should have fully read your message before retagging, my bad. What do
> you want me to do now? The patches haven't changed, just the commit
> messages.
> 
> 
> Sean

I'll pick it up from your repo again. No need to do anything.

	Hans

Re: [GIT PULL FOR v6.7] Minor rc fixes

[Sean Young]

On Wed, Oct 11, 2023 at 03:51:29PM +0200, Hans Verkuil wrote:
> On 11/10/2023 15:40, Sean Young wrote:
> > On Wed, Oct 11, 2023 at 02:58:19PM +0200, Hans Verkuil wrote:
> >> On 09/10/2023 09:41, Sean Young wrote:
> >> These two patches have a Cc to stable, but no Fixes: tag.
> > 
> > I've added the fixes tags and retagged the v6.7c tag in my repo.
> 
> I'll pick it up from your repo again. No need to do anything.

Thanks.

If we have rules like "Cc: stable" requires "Fixes: " then we really need 
tooling that picks that up and warns us about it. Otherwise, not everyone
will know or remember.

Something for your build-scripts?


Sean

Re: [GIT PULL FOR v6.7] Minor rc fixes

[Hans Verkuil]

On 11/10/2023 16:53, Sean Young wrote:
> On Wed, Oct 11, 2023 at 03:51:29PM +0200, Hans Verkuil wrote:
>> On 11/10/2023 15:40, Sean Young wrote:
>>> On Wed, Oct 11, 2023 at 02:58:19PM +0200, Hans Verkuil wrote:
>>>> On 09/10/2023 09:41, Sean Young wrote:
>>>> These two patches have a Cc to stable, but no Fixes: tag.
>>>
>>> I've added the fixes tags and retagged the v6.7c tag in my repo.
>>
>> I'll pick it up from your repo again. No need to do anything.
> 
> Thanks.
> 
> If we have rules like "Cc: stable" requires "Fixes: " then we really need 
> tooling that picks that up and warns us about it. Otherwise, not everyone
> will know or remember.
> 
> Something for your build-scripts?

That's why I discovered this: I added that check to the build scripts yesterday :-)

I think a Cc to stable is not needed if you have a Fixes tag, though.

Regards,

	Hans

Re: [GIT PULL FOR v6.7] Minor rc fixes

[Sean Young]

On Wed, Oct 11, 2023 at 04:55:54PM +0200, Hans Verkuil wrote:
> On 11/10/2023 16:53, Sean Young wrote:
> > On Wed, Oct 11, 2023 at 03:51:29PM +0200, Hans Verkuil wrote:
> >> On 11/10/2023 15:40, Sean Young wrote:
> >>> On Wed, Oct 11, 2023 at 02:58:19PM +0200, Hans Verkuil wrote:
> >>>> On 09/10/2023 09:41, Sean Young wrote:
> >>>> These two patches have a Cc to stable, but no Fixes: tag.
> >>>
> >>> I've added the fixes tags and retagged the v6.7c tag in my repo.
> >>
> >> I'll pick it up from your repo again. No need to do anything.
> > 
> > Thanks.
> > 
> > If we have rules like "Cc: stable" requires "Fixes: " then we really need 
> > tooling that picks that up and warns us about it. Otherwise, not everyone
> > will know or remember.
> > 
> > Something for your build-scripts?
> 
> That's why I discovered this: I added that check to the build scripts yesterday :-)

Perfect! I did not do a git pull on the build scripts, so that's my mistake
then.

> I think a Cc to stable is not needed if you have a Fixes tag, though.

That's a fair point. I viewed "Cc: stable" as an strong indicator to the
stable teams that "this should really go in the stable branch" but I guess
this is implied by the Fixes tags.

Thanks,

Sean