From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF0B0C00A8F for ; Mon, 23 Oct 2023 11:29:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234014AbjJWL3P (ORCPT ); Mon, 23 Oct 2023 07:29:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234004AbjJWL3M (ORCPT ); Mon, 23 Oct 2023 07:29:12 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85CBC102 for ; Mon, 23 Oct 2023 04:29:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698060550; x=1729596550; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=hnCDExVsQw8nBKnJJnypjueFi485C5DGwBJYCS8KPUA=; b=A7xMFv85kcZt7opYRXI4RQ7LghbpLdAbBN3ykyxvQF7q+1usKF2gTSSB lTRrMsDtwFf0ro2eoEDOl1HOahZ0jY8MYBwSQi2cx4ASyrPxrqRaFO5EA TmpOXDrkPhxmID8XOYpkyVAnFWigKQP7vjueu436FtsqHDu5WSYw+aZpQ OK2p5+8WpB4nLy9DAUP/RBEtcwAo5Dv2Ae23s9TX/7kJvnA8EG0qB+PnM rJO+YMpo8aRqddmZINJp+dHWgAxCT1NCX3qjAOXHVbQ07aN38kHJhNZQc SkRxRLHAfN6k6whSJRPHuS5M2YpFKn9SqhSTN+LUtnotw7KUByYz0pkgq w==; X-IronPort-AV: E=McAfee;i="6600,9927,10871"; a="386633649" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="386633649" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 04:29:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10871"; a="761715769" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="761715769" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 04:29:06 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC2) (envelope-from ) id 1qut7H-00000007vBs-37fQ; Mon, 23 Oct 2023 14:29:03 +0300 Date: Mon, 23 Oct 2023 14:29:03 +0300 From: Andy Shevchenko To: Andreas Helbech Kleist Cc: Hans de Goede , Bingbu Cao , bingbu.cao@intel.com, linux-media@vger.kernel.org, sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com, ilpo.jarvinen@linux.intel.com, tfiga@chromium.org, senozhatsky@chromium.org, tomi.valkeinen@ideasonboard.com, tian.shu.qiu@intel.com, hongju.wang@intel.com, claus.stovgaard@gmail.com Subject: Re: [PATCH 10/15] media: intel/ipu6: add input system driver Message-ID: References: <20230727071558.1148653-1-bingbu.cao@intel.com> <20230727071558.1148653-11-bingbu.cao@intel.com> <1ce2242844b3e1348d7343b84b15dd87e0f66e6a.camel@gmail.com> <900a1efcbf29aa238f2ace788dc739e9c6ad3c26.camel@gmail.com> <9d5d0bd8-41d1-4879-fccf-54e56aaa5073@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Oct 23, 2023 at 08:23:23AM +0200, Andreas Helbech Kleist wrote: > On Fri, 2023-10-20 at 16:39 +0200, Hans de Goede wrote: > > On 10/20/23 12:47, Andreas Helbech Kleist wrote: ... > > But it does have an effect, modprobe will load both the main > > ipu6 driver registering the aux devices as well as this driver > > based on the modalias of the PCI device because with this > > MODULE_DEVICE_TABLE(pci, isys_pci_tbl); statement both drivers > > match that PCI modalias. > > All right. But since the main driver contains the same table, I don't > think there's any need to have it here? > > > But the correct thing to do here would be to switch to > > an auxbus based MODULE_DEVICE_TABLE() for the isys driver. > > The isys_driver already has an auxiliary_device_id table. I'm not sure > if that's what you mean? > > From the bottom of ipu6-isys.c in PATCH 10/15: > > +static const struct auxiliary_device_id ipu6_isys_id_table[] = { > + { > + .name = "intel_ipu6.isys", > + .driver_data = (kernel_ulong_t)&ipu6_isys_auxdrv_data, > + }, Should be {} here... > +}; ...and MODULE_DEVICE_TABLE() here. -- With Best Regards, Andy Shevchenko