From: "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>
To: Andreas Helbech Kleist <andreaskleist@gmail.com>
Cc: "Cao, Bingbu" <bingbu.cao@intel.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
"claus.stovgaard@gmail.com" <claus.stovgaard@gmail.com>,
"tfiga@chromium.org" <tfiga@chromium.org>,
"senozhatsky@chromium.org" <senozhatsky@chromium.org>,
"tomi.valkeinen@ideasonboard.com"
<tomi.valkeinen@ideasonboard.com>,
"bingbu.cao@linux.intel.com" <bingbu.cao@linux.intel.com>,
"Qiu, Tian Shu" <tian.shu.qiu@intel.com>,
"Wang, Hongju" <hongju.wang@intel.com>
Subject: Re: [PATCH v2 08/15] media: intel/ipu6: add IPU6 CSI2 receiver v4l2 sub-device
Date: Wed, 8 Nov 2023 17:32:29 +0200 [thread overview]
Message-ID: <ZUuqDS7xOJcLpXvy@smile.fi.intel.com> (raw)
In-Reply-To: <a22cea646d0d8b8022c3be8e4625d6e67a3eb7bf.camel@gmail.com>
On Wed, Nov 08, 2023 at 04:00:02PM +0100, Andreas Helbech Kleist wrote:
> On Wed, 2023-11-08 at 14:50 +0000, Cao, Bingbu wrote:
...
> Now we're talking about casts. There is a cast to int32_t, but the rest
> of the code uses the s32/u32 typedefs. I don't know if one or the other
> is recommended for new code, but I think it should at least be
> consistent across the driver.
s32/u32 are preferable in the kernel code.
Also if you need to extend the sign bit, we have sign_extendXX() helpers.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-08 15:32 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 11:29 [PATCH v2 00/15] Intel IPU6 and IPU6 input system drivers bingbu.cao
2023-10-24 11:29 ` [PATCH v2 01/15] media: intel/ipu6: add Intel IPU6 PCI device driver bingbu.cao
2023-10-25 12:39 ` Andreas Helbech Kleist
2023-10-25 20:03 ` Andy Shevchenko
2023-11-05 14:43 ` Hans de Goede
2023-11-06 8:55 ` Bingbu Cao
2023-11-08 11:25 ` Hans de Goede
2023-11-08 13:24 ` Andy Shevchenko
2023-11-08 14:10 ` Andreas Helbech Kleist
2023-11-08 14:18 ` Cao, Bingbu
2023-11-17 18:43 ` Hans de Goede
2023-11-17 21:18 ` Andy Shevchenko
2023-11-20 3:54 ` Bingbu Cao
2023-11-23 9:17 ` Andreas Helbech Kleist
2023-10-24 11:29 ` [PATCH v2 02/15] media: intel/ipu6: add IPU auxiliary devices bingbu.cao
2023-10-24 12:58 ` Andy Shevchenko
2023-10-25 7:14 ` Bingbu Cao
2023-10-25 8:35 ` Hans de Goede
2023-10-25 19:57 ` Andy Shevchenko
2023-10-26 3:04 ` Bingbu Cao
2023-10-24 11:29 ` [PATCH v2 03/15] media: intel/ipu6: add IPU6 buttress interface driver bingbu.cao
2024-01-03 9:22 ` Andreas Helbech Kleist
2024-01-03 10:49 ` Laurent Pinchart
2024-01-03 13:33 ` Bingbu Cao
2024-01-03 14:01 ` Laurent Pinchart
2024-01-03 13:11 ` Bingbu Cao
2024-01-03 13:18 ` Bingbu Cao
2024-01-08 10:27 ` Andreas Helbech Kleist
2023-10-24 11:29 ` [PATCH v2 04/15] media: intel/ipu6: CPD parsing for get firmware components bingbu.cao
2023-10-24 11:29 ` [PATCH v2 05/15] media: intel/ipu6: add IPU6 DMA mapping API and MMU table bingbu.cao
2023-12-06 14:53 ` Andreas Helbech Kleist
2023-10-24 11:29 ` [PATCH v2 06/15] media: intel/ipu6: add syscom interfaces between firmware and driver bingbu.cao
2023-11-23 9:33 ` Andreas Helbech Kleist
2023-12-28 6:39 ` Bingbu Cao
2024-01-03 9:25 ` Andreas Helbech Kleist
2024-01-08 4:19 ` Bingbu Cao
2023-10-24 11:29 ` [PATCH v2 07/15] media: intel/ipu6: input system ABI " bingbu.cao
2023-10-24 11:29 ` [PATCH v2 08/15] media: intel/ipu6: add IPU6 CSI2 receiver v4l2 sub-device bingbu.cao
2023-11-08 11:25 ` Andreas Helbech Kleist
2023-11-08 14:50 ` Cao, Bingbu
2023-11-08 14:51 ` Bingbu Cao
2023-11-08 15:00 ` Andreas Helbech Kleist
2023-11-08 15:32 ` andriy.shevchenko [this message]
2023-11-09 1:48 ` Bingbu Cao
2023-10-24 11:29 ` [PATCH v2 09/15] media: intel/ipu6: add the CSI2 DPHY implementation bingbu.cao
2023-10-24 11:29 ` [PATCH v2 10/15] media: intel/ipu6: add input system driver bingbu.cao
2023-11-23 9:37 ` Andreas Helbech Kleist
2024-01-09 13:52 ` Andreas Helbech Kleist
2024-01-10 12:47 ` Andreas Helbech Kleist
2023-10-24 11:29 ` [PATCH v2 11/15] media: intel/ipu6: input system video capture nodes bingbu.cao
2023-11-05 16:59 ` Hans de Goede
2023-11-06 9:18 ` Bingbu Cao
2023-11-06 11:17 ` Andy Shevchenko
2023-12-05 9:15 ` Bingbu Cao
2024-01-09 13:35 ` Andreas Helbech Kleist
2023-10-24 11:29 ` [PATCH v2 12/15] media: add Kconfig and Makefile for IPU6 bingbu.cao
2023-10-24 13:04 ` Andy Shevchenko
2023-10-25 8:43 ` Bingbu Cao
2023-10-25 20:00 ` Andy Shevchenko
2023-10-25 12:21 ` Sakari Ailus
2023-10-25 20:01 ` Andy Shevchenko
2023-10-24 11:29 ` [PATCH v2 13/15] MAINTAINERS: add maintainers for Intel IPU6 input system driver bingbu.cao
2023-10-24 11:29 ` [PATCH v2 14/15] Documentation: add Intel IPU6 ISYS driver admin-guide doc bingbu.cao
2023-10-25 12:15 ` Sakari Ailus
2024-01-08 3:51 ` Bingbu Cao
2024-01-08 9:14 ` Sakari Ailus
2024-01-09 6:34 ` Bingbu Cao
2024-01-09 8:55 ` Sakari Ailus
2024-01-09 11:00 ` Bingbu Cao
2023-10-24 11:29 ` [PATCH v2 15/15] Documentation: add documentation of Intel IPU6 driver and hardware overview bingbu.cao
2023-10-25 12:09 ` Sakari Ailus
2023-10-26 3:38 ` Bingbu Cao
2023-10-26 5:27 ` Sakari Ailus
2023-11-08 11:59 ` [PATCH v2 00/15] Intel IPU6 and IPU6 input system drivers Hans de Goede
2023-11-08 14:31 ` Cao, Bingbu
2023-11-08 15:15 ` Hans de Goede
2023-11-10 12:04 ` Hans de Goede
2023-11-13 10:37 ` Bingbu Cao
2023-12-04 16:35 ` Hans de Goede
2023-12-04 16:49 ` Andy Shevchenko
2024-01-08 4:07 ` Bingbu Cao
2024-01-08 14:23 ` Hans de Goede
2024-01-09 3:51 ` Bingbu Cao
2024-01-15 13:13 ` Hans de Goede
2024-02-07 7:00 ` Sakari Ailus
2024-02-14 9:28 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUuqDS7xOJcLpXvy@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andreaskleist@gmail.com \
--cc=bingbu.cao@intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=claus.stovgaard@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hongju.wang@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=senozhatsky@chromium.org \
--cc=tfiga@chromium.org \
--cc=tian.shu.qiu@intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox