From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="oWjcmV9R" Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B736619BB for ; Fri, 24 Nov 2023 10:00:45 -0800 (PST) Received: from localhost (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dbrouwer) by madras.collabora.co.uk (Postfix) with ESMTPSA id E70076601F11; Fri, 24 Nov 2023 18:00:43 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1700848844; bh=iiAKZ5p0aAAYzWDSMrxhIzRwjCpKlORLgDDwcFSvRhA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oWjcmV9RoMbBbWtk9foy3gOnfo3BqwS/g54OUcPNwb4Mi/C+fLlmPFDOTtU6Wk/Gq UKVMlq3fkwdKPTQ+/3NoCrwSgYuGBjSOm2I4BKvEAE3Sc2kM5Z9dgeNWp15sWlzxQP Vu7ALF+KA/YBohyB9uSpfGAq3FQCkcuROKy1mQ8CxSPuzGI0s55A7PjYr8J2aOw9Nu g3Km4wkjJrvYGOBZnithHvIv10gAaPFsWr50JxU9bRKnqbzAkNUvBGw2SR//Hj3kuv xLJ//8+Y41zL9HivUPbSFpINb8AA71Nl0GwHrRKwpjcZPfqWlljSb0sDlVrEUKM4Hg GK0nr4Q9cLIWg== Date: Fri, 24 Nov 2023 10:00:40 -0800 From: Deborah Brouwer To: Hans Verkuil Cc: linux-media@vger.kernel.org Subject: Re: build scripts: branches with forward slashes in names Message-ID: References: <67201f49-aacb-48a4-a11c-38a8875440b4@xs4all.nl> <4a41ef2f-99d4-4cf2-bf92-a53ec7c34335@xs4all.nl> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4a41ef2f-99d4-4cf2-bf92-a53ec7c34335@xs4all.nl> On Fri, Nov 24, 2023 at 10:37:59AM +0100, Hans Verkuil wrote: > On 24/11/2023 08:23, Hans Verkuil wrote: > > On 23/11/2023 23:22, Deborah Brouwer wrote: > >> Hi Hans, > >> > >> Have you ever had a problem running the build scripts on branches with > >> forward slashes in their names? > >> > >> So, for example, I add my repo to env.sh > >> myrepo=https://gitlab.collabora.com/chipsnmedia/kernel > >> > >> I run ./build.sh setup and I can see it fetching my repo and including > >> my branch "dbrouwer/KConfig_fix", but if try to run: > >> > >> ./build.sh -test all dbrouwer/KConfig_fix > >> > >> I get this error: > >> > >> "fatal: 'dbrouwer/KConfig_fix' is not a commit and a branch 'build-test' cannot be created from it" > >> > >> But then if I change the branch name to remove the forward slash "KConfig_fix" it works fine again. > >> > >> Have you noticed anything similar? Could it be easily fixed? > >> > >> Thanks, > >> Deborah > >> > > > > From the README: > > > > "If is absent, then it will default to media_stage/master. If it > > contains a / character, then the branch name will be used as-is (e.g. > > use / to build a branch on a specific remote), otherwise > > the branch name will be prefixed by main/ (e.g. main/), which > > uses the branch on your '$myrepo' repository." > > > > I never use / in branch names (too confusing with / in pathnames), and since > > I developed these scripts originally for myself, I just grepped for /. > > > > Perhaps the build script should allow for 0-2 arguments at the end: > > nothing means media_stage/master, 1 arg means main/ and 2 args > > means /. > > > > Let me see what I can do. > > I've done exactly that: after the argument you can now add an > optional argument. So branch now supports / in the name. Ah thanks for fixing this, I tested it and it works fine now: "branch 'build-test' set up to track 'main/dbrouwer/KConfig_fix'." > > Regards, > > Hans >