From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="oGPVJn7s" Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C64AA198 for ; Wed, 29 Nov 2023 05:51:28 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 43D7C2000A; Wed, 29 Nov 2023 13:51:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1701265887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iio5lhZ7fDTgwlNACNdVlwnuy5DnkJ33cA5N20DaXYc=; b=oGPVJn7sniLFH47nuUbO4CwBJhoY6bH3i4gh5xbttoOG7D1mbHPM67SJA+5qM9AIQ7HnnW XrL4aBxx5HkD0sf74mv38C4Y1fPYS4qElZ3pIpiTuPVtUm0f4zU9bakGktXkOvASE0kS02 oMJKFgGeYH5Johd8N8xuA6kkQptlwCbIJaQv4vBSrEaGhQdX7h1F+AZxMosMRgfvduHKg4 fr4QWOQ/gjjKr2MP4OxaRTpfKl9Ku9a4cc5jspfbMwDFyMrQ4vKgXzjlTGNChpmAnbMmap FTv5BhN1oRKyOfuU3vBds5j1m4BDLK//bFN8i6QI9QN/5pc9ki36yQFBathBhQ== Date: Wed, 29 Nov 2023 14:51:21 +0100 From: Paul Kocialkowski To: Laurent Pinchart Cc: linux-media@vger.kernel.org, Sakari Ailus , Hans Verkuil , Lars-Peter Clausen , Tomi Valkeinen , Martin Kepplinger , Ricardo Ribalda , Dave Stevenson , Manivannan Sadhasivam , Michael Riesch , Jacopo Mondi , Bingbu Cao , Rui Miguel Silva , Hans de Goede , Tianshu Qiu , Steve Longerbeam , Nicholas Roth , Benjamin Mugnier , Sylvain Petinot , Tim Harvey , Maxime Ripard , Eugen Hristev , Kieran Bingham , Dafna Hirschfeld , Yong Deng , Benoit Parrot , Philipp Zabel , Shuah Khan , Mauro Carvalho Chehab , Hugues Fruchet , Alain Volmat Subject: Re: [PATCH v4 1/1] media: v4l2-subdev: Rename .init_cfg() operation to .init_state() Message-ID: References: <20231127090744.30012-1-laurent.pinchart@ideasonboard.com> <20231127090744.30012-2-laurent.pinchart@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="N9wa/NidUoCPh6m3" Content-Disposition: inline In-Reply-To: <20231127090744.30012-2-laurent.pinchart@ideasonboard.com> X-GND-Sasl: paul.kocialkowski@bootlin.com --N9wa/NidUoCPh6m3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Laurent, On Mon 27 Nov 23, 11:07, Laurent Pinchart wrote: > The subdev .init_cfg() operation is affected by two issues: >=20 > - It has long been extended to initialize a whole v4l2_subdev_state > instead of just a v4l2_subdev_pad_config, but its name has stuck > around. >=20 > - Despite operating on a whole subdev state and not being directly > exposed to the subdev users (either in-kernel or through the userspace > API), .init_cfg() is categorized as a subdev pad operation. >=20 > This participates in making the subdev API confusing for new developers. > Fix it by renaming the operation to .init_state(), and make it a subdev > internal operation. >=20 > Signed-off-by: Laurent Pinchart > Acked-by: Michael Riesch # for imx415 > Acked-by: Shuah Khan # for vimc For the sun6i-csi, sun6i-isp, sun6i-mipi-csi2 and sun8i-a83t-mipi-csi2 driv= ers: Acked-by: Paul Kocialkowski I might submit some cosmetic patch later to reorder things but this can wai= t. Thanks for working on this, it's much cleaner this way :) Cheers, Paul --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --N9wa/NidUoCPh6m3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmVnQdkACgkQ3cLmz3+f v9F3JQf+LlRthaKeOvwJCHOU9Q2X+XQnUF7gemWM+Uhn5mBgRJEgQJaKVEKC3Ws9 d48rQ8vUm6PEqNmR+brozNcazA7ooiF57XSAxOkMMe4DmzI+Ty3v33TgFUSs9Mj5 KKMN86uON2kTUxABosJXzxki8xiKLcHukpSqBu0Bdsf7qihWWjy1fnphh71J+sUB 5d3PnshhRdzckUxQVYBO+gyvRKCC9ayidhoRLETD4wcyOKhrCGolcEfdq5vOcZoB Ddkbr88YAmbDIpj/oPTrZ/yZFKDktPu0o9FKqEyCG1fXFlTKmndgfwEs/Sg4s3J1 KoucOX5VVOLRjdUDhdh1ygcQVPyIBQ== =QniV -----END PGP SIGNATURE----- --N9wa/NidUoCPh6m3--