From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=treblig.org header.i=@treblig.org header.b="d/h4gpa9" Received: from mx.treblig.org (mx.treblig.org [IPv6:2a00:1098:5b::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10D7785 for ; Thu, 30 Nov 2023 06:26:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=/X8jazQUvZoCEMtE1HqE56485lMCZyLGm9Hi7ZQPL/Y=; b=d/h4gpa9bECc+eOAJ4byl1LN+J zrzwxDiNTTB3XhhpygxRRUZwSd5Tn0QEFtBGKWI714Xnb4AB/BqB9ZxKb+cWXZXBhn51b6XQlcx7P gsE/ZzHKDHc7bzulVcKHjeIRtIuCD29b8Kcurj1RzQJcPd9zN6ReBnTfq+INvfl+fNwqNe5+3GDBo QSznctUG9W6Q03hG3NrZqgaf947e/HZJe7saYplFCR6v8TAWX9CcNv2VSA4Hh98ZV6EiICuDY+01c 4Q1lWDccn8lwwJCerIXe/uznItsa+AzLRWNPp7Wl8lUgzydLmdNS3/bJiSvsthwa6YhsWtrVvXadI 0TJJgXfg==; Received: from dg by mx.treblig.org with local (Exim 4.96) (envelope-from ) id 1r8hzY-00Bas2-0W; Thu, 30 Nov 2023 14:26:12 +0000 Date: Thu, 30 Nov 2023 14:26:12 +0000 From: "Dr. David Alan Gilbert" To: Hans Verkuil Cc: linux-media@vger.kernel.org, Deborah Brouwer Subject: Re: [PATCH 0/3] media: bttv: three post-vb2 fixes Message-ID: References: Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: X-Chocolate: 70 percent or better cocoa solids preferably X-Operating-System: Linux/6.1.0-12-amd64 (x86_64) X-Uptime: 14:26:03 up 75 days, 17:24, 1 user, load average: 0.23, 0.11, 0.04 User-Agent: Mutt/2.2.12 (2023-09-09) * Hans Verkuil (hverkuil-cisco@xs4all.nl) wrote: > Dave, thank you for your detailed bttv bug report: > > https://lore.kernel.org/linux-media/ZVK_3UmvmOaCv1tc@gallifrey/ > > It was very helpful and I managed to reproduce these issues. > > This patch series fixes them. > > The first patch is unrelated, just something I noticed while > debugging this. > > The second patch adds back the old bttv behavior of storing the > frame counter in the last 4 bytes of the vbi payload when using > read(). > > The final patch fixes the vbi read() behavior where it was > alternating between valid data and a zeroed buffer. > > I'd appreciate it if you can test this before Dec 11 since I > plan to merge on Dec 11 if I don't hear anything. Sure, I'll get on it. Dave > Regards, > > Hans > > Hans Verkuil (3): > media: bttv: start_streaming should return a proper error code > media: bttv: add back vbi hack > media: videobuf2: request more buffers for vb2_read > > .../media/common/videobuf2/videobuf2-core.c | 9 +++++-- > drivers/media/pci/bt8xx/bttv-driver.c | 27 ++++++++++++++++--- > drivers/media/pci/bt8xx/bttv-vbi.c | 8 +++--- > 3 files changed, 33 insertions(+), 11 deletions(-) > > -- > 2.42.0 > -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/