Re: [PATCH v4 5/7] i2c: core: Do not dereference fwnode in struct device

Andy Shevchenko
2025-04-16T07:26:39Z

On Wed, Apr 16, 2025 at 09:20:52AM +0200, Wolfram Sang wrote:
> On Wed, Apr 16, 2025 at 10:02:15AM +0300, Andy Shevchenko wrote:
> > On Wed, Apr 16, 2025 at 08:55:27AM +0200, Wolfram Sang wrote:
> > > On Mon, Apr 14, 2025 at 01:01:55PM +0300, Andy Shevchenko wrote:
> > > > In order to make the underneath API easier to change in the future,
> > > > prevent users from dereferencing fwnode from struct device.
> > > > Instead, use the specific device_set_node() API for that.
> > > >
> > > > Tested-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> > > > Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > > > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > >
> > > I'll check this patch later today. Rest of the series looks good to me
> > > already.
> >
> > Note, I'm planning to send a v5 shortly with the style fixes and commit
> > messages as you suggested.
>
> Please wait with that like half an hour.

Too late, I have sent it already...

--
With Best Regards,
Andy Shevchenko