From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Samuel Wein <sam@samwein.com>
Cc: linux-media@vger.kernel.org, bingbu.cao@linux.intel.com
Subject: Re: [PATCH v2] media: Fix examples in ipu6-isys admin-guide
Date: Mon, 27 May 2024 12:11:08 +0000 [thread overview]
Message-ID: <ZlR4XMhAqeChUdD3@kekkonen.localdomain> (raw)
In-Reply-To: <20240522114656.30472-1-sam@samwein.com>
Hi Samuel,
Thanks for the update.
On Wed, May 22, 2024 at 11:47:26AM +0000, Samuel Wein wrote:
> Fix flags in X1 Yoga example. MEDIA_LNK_FL_DYNAMIC (0x4 in the link flag)
> was removed in V4 Intel IPU6 and IPU6 input system drivers.
> Added -V flag to media-ctl commands for X1 Yoga, lower-case v only makes it verbose
> upper-case V sets the format.
>
> Signed-off-by: Samuel Wein <sam@samwein.com>
> ---
> Documentation/admin-guide/media/ipu6-isys.rst | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/admin-guide/media/ipu6-isys.rst b/Documentation/admin-guide/media/ipu6-isys.rst
> index 0721e920b5e6..ac7595a876f1 100644
> --- a/Documentation/admin-guide/media/ipu6-isys.rst
> +++ b/Documentation/admin-guide/media/ipu6-isys.rst
> @@ -135,16 +135,16 @@ sensor ov2740 on Lenovo X1 Yoga laptop.
> .. code-block:: none
>
> media-ctl -l "\"ov2740 14-0036\":0 -> \"Intel IPU6 CSI2 1\":0[1]"
> - media-ctl -l "\"Intel IPU6 CSI2 1\":1 -> \"Intel IPU6 ISYS Capture 0\":0[5]"
> - media-ctl -l "\"Intel IPU6 CSI2 1\":2 -> \"Intel IPU6 ISYS Capture 1\":0[5]"
> + media-ctl -l "\"Intel IPU6 CSI2 1\":1 -> \"Intel IPU6 ISYS Capture 0\":0[1]"
> + media-ctl -l "\"Intel IPU6 CSI2 1\":2 -> \"Intel IPU6 ISYS Capture 1\":0[1]"
>
> # set routing
> media-ctl -v -R "\"Intel IPU6 CSI2 1\" [0/0->1/0[1],0/1->2/1[1]]"
This -v should be dropped, too. I missed that earlier.
V3 might be the easiest way to do that.
>
> - media-ctl -v "\"Intel IPU6 CSI2 1\":0/0 [fmt:SGRBG10/1932x1092]"
> - media-ctl -v "\"Intel IPU6 CSI2 1\":0/1 [fmt:GENERIC_8/97x1]"
> - media-ctl -v "\"Intel IPU6 CSI2 1\":1/0 [fmt:SGRBG10/1932x1092]"
> - media-ctl -v "\"Intel IPU6 CSI2 1\":2/1 [fmt:GENERIC_8/97x1]"
> + media-ctl -V "\"Intel IPU6 CSI2 1\":0/0 [fmt:SGRBG10/1932x1092]"
> + media-ctl -V "\"Intel IPU6 CSI2 1\":0/1 [fmt:GENERIC_8/97x1]"
> + media-ctl -V "\"Intel IPU6 CSI2 1\":1/0 [fmt:SGRBG10/1932x1092]"
> + media-ctl -V "\"Intel IPU6 CSI2 1\":2/1 [fmt:GENERIC_8/97x1]"
>
> CAPTURE_DEV=$(media-ctl -e "Intel IPU6 ISYS Capture 0")
> ./yavta --data-prefix -c100 -n5 -I -s1932x1092 --file=/tmp/frame-#.bin \
--
Regards,
Sakari Ailus
prev parent reply other threads:[~2024-05-27 12:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 11:47 [PATCH v2] media: Fix examples in ipu6-isys admin-guide Samuel Wein
2024-05-27 12:11 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlR4XMhAqeChUdD3@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=sam@samwein.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox