* [PATCH] media: i2c: Kconfig: Fix missing firmware upload config select
@ 2024-06-20 10:25 Kory Maincent
2024-06-20 10:33 ` Laurent Pinchart
2024-06-20 12:23 ` Paul Elder
0 siblings, 2 replies; 3+ messages in thread
From: Kory Maincent @ 2024-06-20 10:25 UTC (permalink / raw)
To: Laurent Pinchart, Sakari Ailus, Paul Elder, Hans Verkuil,
linux-media, linux-kernel
Cc: Kory Maincent, thomas.petazzoni, Mauro Carvalho Chehab
FW_LOADER config only selects the firmware loader API, but we also need
the sysfs_upload symbols for firmware_upload_unregister() and
firmware_upload_register() to function properly.
Fixes: 7a52ab415b43 ("media: i2c: Add driver for THine THP7312")
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index c6d3ee472d81..742bc665602e 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -679,6 +679,7 @@ config VIDEO_THP7312
tristate "THine THP7312 support"
depends on I2C
select FW_LOADER
+ select FW_UPLOAD
select MEDIA_CONTROLLER
select V4L2_CCI_I2C
select V4L2_FWNODE
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] media: i2c: Kconfig: Fix missing firmware upload config select
2024-06-20 10:25 [PATCH] media: i2c: Kconfig: Fix missing firmware upload config select Kory Maincent
@ 2024-06-20 10:33 ` Laurent Pinchart
2024-06-20 12:23 ` Paul Elder
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2024-06-20 10:33 UTC (permalink / raw)
To: Kory Maincent
Cc: Sakari Ailus, Paul Elder, Hans Verkuil, linux-media, linux-kernel,
thomas.petazzoni, Mauro Carvalho Chehab
Hi Kory,
Thank you for the patch.
On Thu, Jun 20, 2024 at 12:25:43PM +0200, Kory Maincent wrote:
> FW_LOADER config only selects the firmware loader API, but we also need
> the sysfs_upload symbols for firmware_upload_unregister() and
> firmware_upload_register() to function properly.
>
> Fixes: 7a52ab415b43 ("media: i2c: Add driver for THine THP7312")
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index c6d3ee472d81..742bc665602e 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -679,6 +679,7 @@ config VIDEO_THP7312
> tristate "THine THP7312 support"
> depends on I2C
> select FW_LOADER
> + select FW_UPLOAD
> select MEDIA_CONTROLLER
> select V4L2_CCI_I2C
> select V4L2_FWNODE
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: i2c: Kconfig: Fix missing firmware upload config select
2024-06-20 10:25 [PATCH] media: i2c: Kconfig: Fix missing firmware upload config select Kory Maincent
2024-06-20 10:33 ` Laurent Pinchart
@ 2024-06-20 12:23 ` Paul Elder
1 sibling, 0 replies; 3+ messages in thread
From: Paul Elder @ 2024-06-20 12:23 UTC (permalink / raw)
To: Kory Maincent
Cc: Laurent Pinchart, Sakari Ailus, Hans Verkuil, linux-media,
linux-kernel, thomas.petazzoni, Mauro Carvalho Chehab
On Thu, Jun 20, 2024 at 12:25:43PM +0200, Kory Maincent wrote:
> FW_LOADER config only selects the firmware loader API, but we also need
> the sysfs_upload symbols for firmware_upload_unregister() and
> firmware_upload_register() to function properly.
>
> Fixes: 7a52ab415b43 ("media: i2c: Add driver for THine THP7312")
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index c6d3ee472d81..742bc665602e 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -679,6 +679,7 @@ config VIDEO_THP7312
> tristate "THine THP7312 support"
> depends on I2C
> select FW_LOADER
> + select FW_UPLOAD
> select MEDIA_CONTROLLER
> select V4L2_CCI_I2C
> select V4L2_FWNODE
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-20 12:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-20 10:25 [PATCH] media: i2c: Kconfig: Fix missing firmware upload config select Kory Maincent
2024-06-20 10:33 ` Laurent Pinchart
2024-06-20 12:23 ` Paul Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).