From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Tsuchiya Yuto <kitakar@gmail.com>,
Yury Luneff <yury.lunev@gmail.com>,
Nable <nable.maininbox@googlemail.com>,
andrey.i.trufanov@gmail.com, Fabio Aiuto <fabioaiuto83@gmail.com>,
Kate Hsuan <hpa@redhat.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH 2/3] media: atomisp: Drop dev_dbg() calls from hmm_[alloc|free]()
Date: Mon, 2 Sep 2024 14:06:57 +0300 [thread overview]
Message-ID: <ZtWcUc0MO0f8ofKu@smile.fi.intel.com> (raw)
In-Reply-To: <20240902095229.59059-2-hdegoede@redhat.com>
On Mon, Sep 02, 2024 at 11:52:28AM +0200, Hans de Goede wrote:
> Debug logging every alloc + free just polutes the debug logs without
> adding much value, remove the alloc + free dev_dbg() calls.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Agree on the point and ideally we should remove/replace most of (all?) the
messages by trace points.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-02 11:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 9:52 [PATCH 1/3] media: atomisp: csi2-bridge: Add DMI quirk for t4ka3 on Xiaomi Mipad2 Hans de Goede
2024-09-02 9:52 ` [PATCH 2/3] media: atomisp: Drop dev_dbg() calls from hmm_[alloc|free]() Hans de Goede
2024-09-02 11:06 ` Andy Shevchenko [this message]
2024-09-02 9:52 ` [PATCH 3/3] media: atomisp: Improve binary finding debug logging Hans de Goede
2024-09-02 12:03 ` Andy Shevchenko
2024-09-03 9:27 ` Hans de Goede
2024-09-03 10:30 ` Andy Shevchenko
2024-09-03 11:12 ` Hans de Goede
2024-09-02 10:37 ` [PATCH 1/3] media: atomisp: csi2-bridge: Add DMI quirk for t4ka3 on Xiaomi Mipad2 Hans de Goede
2024-09-02 11:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtWcUc0MO0f8ofKu@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=andrey.i.trufanov@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=kitakar@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=nable.maininbox@googlemail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=yury.lunev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox